All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Collingbourne <pcc@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
	Alexander Potapenko <glider@google.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jann Horn <jannh@google.com>,
	Evgenii Stepanov <eugenis@google.com>,
	linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/4] mm: arch: remove indirection level in alloc_zeroed_user_highpage_movable()
Date: Fri, 4 Jun 2021 10:45:47 +0100	[thread overview]
Message-ID: <20210604094546.GA31173@arm.com> (raw)
In-Reply-To: <20210602235230.3928842-2-pcc@google.com>

On Wed, Jun 02, 2021 at 04:52:27PM -0700, Peter Collingbourne wrote:
> In an upcoming change we would like to add a flag to
> GFP_HIGHUSER_MOVABLE so that it would no longer be an OR
> of GFP_HIGHUSER and __GFP_MOVABLE. This poses a problem for
> alloc_zeroed_user_highpage_movable() which passes __GFP_MOVABLE
> into an arch-specific __alloc_zeroed_user_highpage() hook which ORs
> in GFP_HIGHUSER.
> 
> Since __alloc_zeroed_user_highpage() is only ever called from
> alloc_zeroed_user_highpage_movable(), we can remove one level
> of indirection here. Remove __alloc_zeroed_user_highpage(),
> make alloc_zeroed_user_highpage_movable() the hook, and use
> GFP_HIGHUSER_MOVABLE in the hook implementations so that they will
> pick up the new flag that we are going to add.
> 
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> Link: https://linux-review.googlesource.com/id/Ic6361c657b2cdcd896adbe0cf7cb5a7fbb1ed7bf

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Collingbourne <pcc@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
	Alexander Potapenko <glider@google.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jann Horn <jannh@google.com>,
	Evgenii Stepanov <eugenis@google.com>,
	linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/4] mm: arch: remove indirection level in alloc_zeroed_user_highpage_movable()
Date: Fri, 4 Jun 2021 10:45:47 +0100	[thread overview]
Message-ID: <20210604094546.GA31173@arm.com> (raw)
In-Reply-To: <20210602235230.3928842-2-pcc@google.com>

On Wed, Jun 02, 2021 at 04:52:27PM -0700, Peter Collingbourne wrote:
> In an upcoming change we would like to add a flag to
> GFP_HIGHUSER_MOVABLE so that it would no longer be an OR
> of GFP_HIGHUSER and __GFP_MOVABLE. This poses a problem for
> alloc_zeroed_user_highpage_movable() which passes __GFP_MOVABLE
> into an arch-specific __alloc_zeroed_user_highpage() hook which ORs
> in GFP_HIGHUSER.
> 
> Since __alloc_zeroed_user_highpage() is only ever called from
> alloc_zeroed_user_highpage_movable(), we can remove one level
> of indirection here. Remove __alloc_zeroed_user_highpage(),
> make alloc_zeroed_user_highpage_movable() the hook, and use
> GFP_HIGHUSER_MOVABLE in the hook implementations so that they will
> pick up the new flag that we are going to add.
> 
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> Link: https://linux-review.googlesource.com/id/Ic6361c657b2cdcd896adbe0cf7cb5a7fbb1ed7bf

Acked-by: Catalin Marinas <catalin.marinas@arm.com>


  reply	other threads:[~2021-06-04  9:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 23:52 [PATCH v6 0/4] arm64: improve efficiency of setting tags for user pages Peter Collingbourne
2021-06-02 23:52 ` Peter Collingbourne
2021-06-02 23:52 ` [PATCH v6 1/4] mm: arch: remove indirection level in alloc_zeroed_user_highpage_movable() Peter Collingbourne
2021-06-02 23:52   ` Peter Collingbourne
2021-06-04  9:45   ` Catalin Marinas [this message]
2021-06-04  9:45     ` Catalin Marinas
2021-06-02 23:52 ` [PATCH v6 2/4] kasan: use separate (un)poison implementation for integrated init Peter Collingbourne
2021-06-02 23:52   ` Peter Collingbourne
2021-06-02 23:52 ` [PATCH v6 3/4] arm64: mte: handle tags zeroing at page allocation time Peter Collingbourne
2021-06-02 23:52   ` Peter Collingbourne
2021-06-02 23:52 ` [PATCH v6 4/4] kasan: disable freed user page poisoning with HW tags Peter Collingbourne
2021-06-02 23:52   ` Peter Collingbourne
2021-06-04  3:03 ` [PATCH v6 0/4] arm64: improve efficiency of setting tags for user pages Andrew Morton
2021-06-04  3:03   ` Andrew Morton
2021-06-04 18:31   ` Will Deacon
2021-06-04 18:31     ` Will Deacon
2021-06-04 19:48 ` Will Deacon
2021-06-04 19:48   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210604094546.GA31173@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=eugenis@google.com \
    --cc=glider@google.com \
    --cc=jannh@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=pcc@google.com \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.