From: Rob Herring <robh@kernel.org>
To: Yanan Wang <wangyanan55@huawei.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, wanghaibin.wang@huawei.com
Subject: Re: [PATCH] Documentation: dt-bindings: Fix incorrect statement
Date: Fri, 4 Jun 2021 14:41:59 -0500 [thread overview]
Message-ID: <20210604194159.GA3781429@robh.at.kernel.org> (raw)
In-Reply-To: <20210521095720.5592-1-wangyanan55@huawei.com>
On Fri, May 21, 2021 at 05:57:20PM +0800, Yanan Wang wrote:
> It's found when reading the Doc.
Please improve the subject so we have some clue as to what the change is
and what it applies to.
> In a SMP system, the hierarchy of CPUs now can be defined through
> four not three entities (socket/cluster/core/thread), so correct
> the statement to avoid possible confusion.
>
> Since we are already there, also drop an extra space and tweak
> the title alignment. No real context change at all.
Since already here, converting to schema would be preferred over trivial
fixes.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
> Documentation/devicetree/bindings/cpu/cpu-topology.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/cpu/cpu-topology.txt b/Documentation/devicetree/bindings/cpu/cpu-topology.txt
> index 9bd530a35d14..8b23a98c283c 100644
> --- a/Documentation/devicetree/bindings/cpu/cpu-topology.txt
> +++ b/Documentation/devicetree/bindings/cpu/cpu-topology.txt
> @@ -6,7 +6,7 @@ CPU topology binding description
> 1 - Introduction
> ===========================================
>
> -In a SMP system, the hierarchy of CPUs is defined through three entities that
> +In a SMP system, the hierarchy of CPUs is defined through four entities that
> are used to describe the layout of physical CPUs in the system:
>
> - socket
> @@ -75,7 +75,7 @@ whose bindings are described in paragraph 3.
>
> The nodes describing the CPU topology (socket/cluster/core/thread) can
> only be defined within the cpu-map node and every core/thread in the
> -system must be defined within the topology. Any other configuration is
> +system must be defined within the topology. Any other configuration is
> invalid and therefore must be ignored.
>
> ===========================================
> @@ -91,9 +91,9 @@ cpu-map child nodes which do not share a common parent node can have the same
> name (ie same number N as other cpu-map child nodes at different device tree
> levels) since name uniqueness will be guaranteed by the device tree hierarchy.
>
> -===========================================
> +============================================
> 3 - socket/cluster/core/thread node bindings
> -===========================================
> +============================================
>
> Bindings for socket/cluster/cpu/thread nodes are defined as follows:
>
> --
> 2.19.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Yanan Wang <wangyanan55@huawei.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, wanghaibin.wang@huawei.com
Subject: Re: [PATCH] Documentation: dt-bindings: Fix incorrect statement
Date: Fri, 4 Jun 2021 14:41:59 -0500 [thread overview]
Message-ID: <20210604194159.GA3781429@robh.at.kernel.org> (raw)
In-Reply-To: <20210521095720.5592-1-wangyanan55@huawei.com>
On Fri, May 21, 2021 at 05:57:20PM +0800, Yanan Wang wrote:
> It's found when reading the Doc.
Please improve the subject so we have some clue as to what the change is
and what it applies to.
> In a SMP system, the hierarchy of CPUs now can be defined through
> four not three entities (socket/cluster/core/thread), so correct
> the statement to avoid possible confusion.
>
> Since we are already there, also drop an extra space and tweak
> the title alignment. No real context change at all.
Since already here, converting to schema would be preferred over trivial
fixes.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
> Documentation/devicetree/bindings/cpu/cpu-topology.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/cpu/cpu-topology.txt b/Documentation/devicetree/bindings/cpu/cpu-topology.txt
> index 9bd530a35d14..8b23a98c283c 100644
> --- a/Documentation/devicetree/bindings/cpu/cpu-topology.txt
> +++ b/Documentation/devicetree/bindings/cpu/cpu-topology.txt
> @@ -6,7 +6,7 @@ CPU topology binding description
> 1 - Introduction
> ===========================================
>
> -In a SMP system, the hierarchy of CPUs is defined through three entities that
> +In a SMP system, the hierarchy of CPUs is defined through four entities that
> are used to describe the layout of physical CPUs in the system:
>
> - socket
> @@ -75,7 +75,7 @@ whose bindings are described in paragraph 3.
>
> The nodes describing the CPU topology (socket/cluster/core/thread) can
> only be defined within the cpu-map node and every core/thread in the
> -system must be defined within the topology. Any other configuration is
> +system must be defined within the topology. Any other configuration is
> invalid and therefore must be ignored.
>
> ===========================================
> @@ -91,9 +91,9 @@ cpu-map child nodes which do not share a common parent node can have the same
> name (ie same number N as other cpu-map child nodes at different device tree
> levels) since name uniqueness will be guaranteed by the device tree hierarchy.
>
> -===========================================
> +============================================
> 3 - socket/cluster/core/thread node bindings
> -===========================================
> +============================================
>
> Bindings for socket/cluster/cpu/thread nodes are defined as follows:
>
> --
> 2.19.1
next prev parent reply other threads:[~2021-06-04 19:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 9:57 [PATCH] Documentation: dt-bindings: Fix incorrect statement Yanan Wang
2021-05-21 9:57 ` Yanan Wang
2021-06-04 19:41 ` Rob Herring [this message]
2021-06-04 19:41 ` Rob Herring
2021-06-07 2:13 ` wangyanan (Y)
2021-06-07 2:13 ` wangyanan (Y)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210604194159.GA3781429@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=wanghaibin.wang@huawei.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.