* [linux-next:master 7125/8019] net/netfilter/nfnetlink_hook.c:76:7: error: implicit declaration of function 'nft_is_active'
@ 2021-06-08 13:43 ` kernel test robot
0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2021-06-08 13:43 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3145 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: ab5803bc555fe68b9b0d37b9a850d3ec601b938a
commit: e2cf17d3774c323ef6dab6e9f7c0cfc5e742afd9 [7125/8019] netfilter: add new hook nfnl subsystem
config: arc-randconfig-r031-20210608 (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=e2cf17d3774c323ef6dab6e9f7c0cfc5e742afd9
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout e2cf17d3774c323ef6dab6e9f7c0cfc5e742afd9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/netfilter/nfnetlink_hook.c: In function 'nfnl_hook_put_nft_chain_info':
>> net/netfilter/nfnetlink_hook.c:76:7: error: implicit declaration of function 'nft_is_active' [-Werror=implicit-function-declaration]
76 | if (!nft_is_active(net, chain))
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/nft_is_active +76 net/netfilter/nfnetlink_hook.c
58
59 static int nfnl_hook_put_nft_chain_info(struct sk_buff *nlskb,
60 const struct nfnl_dump_hook_data *ctx,
61 unsigned int seq,
62 const struct nf_hook_ops *ops)
63 {
64 struct net *net = sock_net(nlskb->sk);
65 struct nlattr *nest, *nest2;
66 struct nft_chain *chain;
67 int ret = 0;
68
69 if (ops->hook_ops_type != NF_HOOK_OP_NF_TABLES)
70 return 0;
71
72 chain = ops->priv;
73 if (WARN_ON_ONCE(!chain))
74 return 0;
75
> 76 if (!nft_is_active(net, chain))
77 return 0;
78
79 nest = nla_nest_start(nlskb, NFNLA_HOOK_CHAIN_INFO);
80 if (!nest)
81 return -EMSGSIZE;
82
83 ret = nla_put_be32(nlskb, NFNLA_HOOK_INFO_TYPE,
84 htonl(NFNL_HOOK_TYPE_NFTABLES));
85 if (ret)
86 goto cancel_nest;
87
88 nest2 = nla_nest_start(nlskb, NFNLA_HOOK_INFO_DESC);
89 if (!nest2)
90 goto cancel_nest;
91
92 ret = nla_put_string(nlskb, NFTA_CHAIN_TABLE, chain->table->name);
93 if (ret)
94 goto cancel_nest;
95
96 ret = nla_put_string(nlskb, NFTA_CHAIN_NAME, chain->name);
97 if (ret)
98 goto cancel_nest;
99
100 nla_nest_end(nlskb, nest2);
101 nla_nest_end(nlskb, nest);
102 return ret;
103
104 cancel_nest:
105 nla_nest_cancel(nlskb, nest);
106 return -EMSGSIZE;
107 }
108
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26244 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [linux-next:master 7125/8019] net/netfilter/nfnetlink_hook.c:76:7: error: implicit declaration of function 'nft_is_active'
@ 2021-06-08 13:43 ` kernel test robot
0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2021-06-08 13:43 UTC (permalink / raw)
To: Florian Westphal
Cc: kbuild-all, Linux Memory Management List, Pablo Neira Ayuso
[-- Attachment #1: Type: text/plain, Size: 3059 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: ab5803bc555fe68b9b0d37b9a850d3ec601b938a
commit: e2cf17d3774c323ef6dab6e9f7c0cfc5e742afd9 [7125/8019] netfilter: add new hook nfnl subsystem
config: arc-randconfig-r031-20210608 (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=e2cf17d3774c323ef6dab6e9f7c0cfc5e742afd9
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout e2cf17d3774c323ef6dab6e9f7c0cfc5e742afd9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/netfilter/nfnetlink_hook.c: In function 'nfnl_hook_put_nft_chain_info':
>> net/netfilter/nfnetlink_hook.c:76:7: error: implicit declaration of function 'nft_is_active' [-Werror=implicit-function-declaration]
76 | if (!nft_is_active(net, chain))
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/nft_is_active +76 net/netfilter/nfnetlink_hook.c
58
59 static int nfnl_hook_put_nft_chain_info(struct sk_buff *nlskb,
60 const struct nfnl_dump_hook_data *ctx,
61 unsigned int seq,
62 const struct nf_hook_ops *ops)
63 {
64 struct net *net = sock_net(nlskb->sk);
65 struct nlattr *nest, *nest2;
66 struct nft_chain *chain;
67 int ret = 0;
68
69 if (ops->hook_ops_type != NF_HOOK_OP_NF_TABLES)
70 return 0;
71
72 chain = ops->priv;
73 if (WARN_ON_ONCE(!chain))
74 return 0;
75
> 76 if (!nft_is_active(net, chain))
77 return 0;
78
79 nest = nla_nest_start(nlskb, NFNLA_HOOK_CHAIN_INFO);
80 if (!nest)
81 return -EMSGSIZE;
82
83 ret = nla_put_be32(nlskb, NFNLA_HOOK_INFO_TYPE,
84 htonl(NFNL_HOOK_TYPE_NFTABLES));
85 if (ret)
86 goto cancel_nest;
87
88 nest2 = nla_nest_start(nlskb, NFNLA_HOOK_INFO_DESC);
89 if (!nest2)
90 goto cancel_nest;
91
92 ret = nla_put_string(nlskb, NFTA_CHAIN_TABLE, chain->table->name);
93 if (ret)
94 goto cancel_nest;
95
96 ret = nla_put_string(nlskb, NFTA_CHAIN_NAME, chain->name);
97 if (ret)
98 goto cancel_nest;
99
100 nla_nest_end(nlskb, nest2);
101 nla_nest_end(nlskb, nest);
102 return ret;
103
104 cancel_nest:
105 nla_nest_cancel(nlskb, nest);
106 return -EMSGSIZE;
107 }
108
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26244 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH nf-next] nfilter: nf_hooks: fix build failure with NF_TABLES=n
2021-06-08 13:43 ` kernel test robot
(?)
@ 2021-06-08 14:42 ` Florian Westphal
2021-06-08 15:46 ` Pablo Neira Ayuso
-1 siblings, 1 reply; 7+ messages in thread
From: Florian Westphal @ 2021-06-08 14:42 UTC (permalink / raw)
To: netfilter-devel; +Cc: Florian Westphal, kernel test robot
nfnetlink_hook.c: In function 'nfnl_hook_put_nft_chain_info':
nfnetlink_hook.c:76:7: error: implicit declaration of 'nft_is_active'
This macro is only defined when NF_TABLES is enabled.
Add IS_ENABLED guards for this.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 252956528caa ("netfilter: add new hook nfnl subsystem")
Signed-off-by: Florian Westphal <fw@strlen.de>
---
net/netfilter/nfnetlink_hook.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/netfilter/nfnetlink_hook.c b/net/netfilter/nfnetlink_hook.c
index 04586dfa2acd..d624805e977c 100644
--- a/net/netfilter/nfnetlink_hook.c
+++ b/net/netfilter/nfnetlink_hook.c
@@ -61,6 +61,7 @@ static int nfnl_hook_put_nft_chain_info(struct sk_buff *nlskb,
unsigned int seq,
const struct nf_hook_ops *ops)
{
+#if IS_ENABLED(CONFIG_NF_TABLES)
struct net *net = sock_net(nlskb->sk);
struct nlattr *nest, *nest2;
struct nft_chain *chain;
@@ -104,6 +105,9 @@ static int nfnl_hook_put_nft_chain_info(struct sk_buff *nlskb,
cancel_nest:
nla_nest_cancel(nlskb, nest);
return -EMSGSIZE;
+#else
+ return 0;
+#endif
}
static int nfnl_hook_dump_one(struct sk_buff *nlskb,
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH nf-next] nfilter: nf_hooks: fix build failure with NF_TABLES=n
2021-06-08 14:42 ` [PATCH nf-next] nfilter: nf_hooks: fix build failure with NF_TABLES=n Florian Westphal
@ 2021-06-08 15:46 ` Pablo Neira Ayuso
2021-06-08 15:53 ` Florian Westphal
0 siblings, 1 reply; 7+ messages in thread
From: Pablo Neira Ayuso @ 2021-06-08 15:46 UTC (permalink / raw)
To: Florian Westphal; +Cc: netfilter-devel, kernel test robot
Maybe from Kconfig, select CONFIG_NF_TABLES from NFNETLINK_HOOK to
reduce ifdef pollution?
On Tue, Jun 08, 2021 at 04:42:37PM +0200, Florian Westphal wrote:
> nfnetlink_hook.c: In function 'nfnl_hook_put_nft_chain_info':
> nfnetlink_hook.c:76:7: error: implicit declaration of 'nft_is_active'
>
> This macro is only defined when NF_TABLES is enabled.
> Add IS_ENABLED guards for this.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 252956528caa ("netfilter: add new hook nfnl subsystem")
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> net/netfilter/nfnetlink_hook.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/net/netfilter/nfnetlink_hook.c b/net/netfilter/nfnetlink_hook.c
> index 04586dfa2acd..d624805e977c 100644
> --- a/net/netfilter/nfnetlink_hook.c
> +++ b/net/netfilter/nfnetlink_hook.c
> @@ -61,6 +61,7 @@ static int nfnl_hook_put_nft_chain_info(struct sk_buff *nlskb,
> unsigned int seq,
> const struct nf_hook_ops *ops)
> {
> +#if IS_ENABLED(CONFIG_NF_TABLES)
> struct net *net = sock_net(nlskb->sk);
> struct nlattr *nest, *nest2;
> struct nft_chain *chain;
> @@ -104,6 +105,9 @@ static int nfnl_hook_put_nft_chain_info(struct sk_buff *nlskb,
> cancel_nest:
> nla_nest_cancel(nlskb, nest);
> return -EMSGSIZE;
> +#else
> + return 0;
> +#endif
> }
>
> static int nfnl_hook_dump_one(struct sk_buff *nlskb,
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH nf-next] nfilter: nf_hooks: fix build failure with NF_TABLES=n
2021-06-08 15:46 ` Pablo Neira Ayuso
@ 2021-06-08 15:53 ` Florian Westphal
2021-06-08 16:03 ` Pablo Neira Ayuso
0 siblings, 1 reply; 7+ messages in thread
From: Florian Westphal @ 2021-06-08 15:53 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Florian Westphal, netfilter-devel, kernel test robot
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Maybe from Kconfig, select CONFIG_NF_TABLES from NFNETLINK_HOOK to
> reduce ifdef pollution?
Why? It doesn't depend on nftables?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH nf-next] nfilter: nf_hooks: fix build failure with NF_TABLES=n
2021-06-08 15:53 ` Florian Westphal
@ 2021-06-08 16:03 ` Pablo Neira Ayuso
2021-06-08 20:11 ` Florian Westphal
0 siblings, 1 reply; 7+ messages in thread
From: Pablo Neira Ayuso @ 2021-06-08 16:03 UTC (permalink / raw)
To: Florian Westphal; +Cc: netfilter-devel, kernel test robot
On Tue, Jun 08, 2021 at 05:53:26PM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Maybe from Kconfig, select CONFIG_NF_TABLES from NFNETLINK_HOOK to
> > reduce ifdef pollution?
>
> Why? It doesn't depend on nftables?
From kernelside, yes. But you have to compile userspace nftables to
use this infra, unless there is separated tooling, userspace library
or you code your own netlink userspace code.
Adding the "depends on" might also help signal distros that this
subsystem is useful to be turned on.
The #ifdef is perfectly fine to fix the kbuild robot issue, I was just
thinking if it is probably better a different path when looking at the
whole picture.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH nf-next] nfilter: nf_hooks: fix build failure with NF_TABLES=n
2021-06-08 16:03 ` Pablo Neira Ayuso
@ 2021-06-08 20:11 ` Florian Westphal
0 siblings, 0 replies; 7+ messages in thread
From: Florian Westphal @ 2021-06-08 20:11 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Florian Westphal, netfilter-devel, kernel test robot
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Tue, Jun 08, 2021 at 05:53:26PM +0200, Florian Westphal wrote:
> > Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > Maybe from Kconfig, select CONFIG_NF_TABLES from NFNETLINK_HOOK to
> > > reduce ifdef pollution?
> >
> > Why? It doesn't depend on nftables?
>
> From kernelside, yes. But you have to compile userspace nftables to
> use this infra, unless there is separated tooling, userspace library
> or you code your own netlink userspace code.
>
> Adding the "depends on" might also help signal distros that this
> subsystem is useful to be turned on.
>
> The #ifdef is perfectly fine to fix the kbuild robot issue, I was just
> thinking if it is probably better a different path when looking at the
> whole picture.
Fair enough, please discard this, I will send the depends-on patch then.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-06-08 20:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-08 13:43 [linux-next:master 7125/8019] net/netfilter/nfnetlink_hook.c:76:7: error: implicit declaration of function 'nft_is_active' kernel test robot
2021-06-08 13:43 ` kernel test robot
2021-06-08 14:42 ` [PATCH nf-next] nfilter: nf_hooks: fix build failure with NF_TABLES=n Florian Westphal
2021-06-08 15:46 ` Pablo Neira Ayuso
2021-06-08 15:53 ` Florian Westphal
2021-06-08 16:03 ` Pablo Neira Ayuso
2021-06-08 20:11 ` Florian Westphal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.