From: Tyler Hicks <tyhicks@linux.microsoft.com>
To: Jens Wiklander <jens.wiklander@linaro.org>
Cc: "Sumit Garg" <sumit.garg@linaro.org>,
Rijo-john.Thomas@amd.com,
"Allen Pais" <apais@linux.microsoft.com>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jarkko Sakkinen" <jarkko@kernel.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Vikas Gupta" <vikas.gupta@broadcom.com>,
"Thirupathaiah Annapureddy" <thiruan@microsoft.com>,
"Pavel Tatashin" <pasha.tatashin@soleen.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
op-tee@lists.trustedfirmware.org,
linux-integrity <linux-integrity@vger.kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-mips@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 5/7] tee: Support shm registration without dma-buf backing
Date: Thu, 10 Jun 2021 16:00:56 -0500 [thread overview]
Message-ID: <20210610210056.GO4910@sequoia> (raw)
In-Reply-To: <20210610073424.GB2753553@jade>
On 2021-06-10 09:34:24, Jens Wiklander wrote:
> On Wed, Jun 09, 2021 at 08:51:04AM -0500, Tyler Hicks wrote:
> [snip]
> > > > I've just posted "[PATCH 0/7] tee: shared memory updates",
> > > > https://lore.kernel.org/lkml/20210609102324.2222332-1-jens.wiklander@linaro.org/
> > > >
> > > > Where tee_shm_alloc() is replaced by among other functions
> > > > tee_shm_alloc_kernel_buf(). tee_shm_alloc_kernel_buf() takes care of the
> > > > problem with TEE_SHM_DMA_BUF.
> > >
> > > Thanks! At first glance, that series would take care of the last three
> > > patches in my kexec/kdump series.
> >
> > Correction: Your series would not completely take care of the last three
> > patches in my kexec/kdump series because your series doesn't implement
> > the .shutdown() hook for tee_bnxt_fw.
> >
> > Does it make sense to take my series first and then rebase your series
> > on top of it? That would allow my fixes to flow back to stable, then
> > your changes would greatly clean up the implementation in future
> > releases.
>
> Yes, we could try that. I'd like to see tee_shm_alloc_kernel_buf() being
> used instead of tee_shm_alloc() in ftpm_tee_probe() and
> tee_bnxt_fw_probe(). So it would be great if you could include "tee: add
> tee_shm_alloc_kernel_buf()" in your patch set.
That would be no problem at all. I like that idea and I've prepared a v4
with that change. I'll send it out shortly once I've finished testing.
> My patch set would then shrink a bit. By the way, thanks for reviewing
> it.
No problem! I feel like I'm starting to understand the TEE subsystem and
OP-TEE driver a bit so I'm happy to help out.
Tyler
>
> Cheers,
> Jens
>
WARNING: multiple messages have this Message-ID (diff)
From: Tyler Hicks <tyhicks@linux.microsoft.com>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH v3 5/7] tee: Support shm registration without dma-buf backing
Date: Thu, 10 Jun 2021 16:00:56 -0500 [thread overview]
Message-ID: <20210610210056.GO4910@sequoia> (raw)
In-Reply-To: <20210610073424.GB2753553@jade>
[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]
On 2021-06-10 09:34:24, Jens Wiklander wrote:
> On Wed, Jun 09, 2021 at 08:51:04AM -0500, Tyler Hicks wrote:
> [snip]
> > > > I've just posted "[PATCH 0/7] tee: shared memory updates",
> > > > https://lore.kernel.org/lkml/20210609102324.2222332-1-jens.wiklander(a)linaro.org/
> > > >
> > > > Where tee_shm_alloc() is replaced by among other functions
> > > > tee_shm_alloc_kernel_buf(). tee_shm_alloc_kernel_buf() takes care of the
> > > > problem with TEE_SHM_DMA_BUF.
> > >
> > > Thanks! At first glance, that series would take care of the last three
> > > patches in my kexec/kdump series.
> >
> > Correction: Your series would not completely take care of the last three
> > patches in my kexec/kdump series because your series doesn't implement
> > the .shutdown() hook for tee_bnxt_fw.
> >
> > Does it make sense to take my series first and then rebase your series
> > on top of it? That would allow my fixes to flow back to stable, then
> > your changes would greatly clean up the implementation in future
> > releases.
>
> Yes, we could try that. I'd like to see tee_shm_alloc_kernel_buf() being
> used instead of tee_shm_alloc() in ftpm_tee_probe() and
> tee_bnxt_fw_probe(). So it would be great if you could include "tee: add
> tee_shm_alloc_kernel_buf()" in your patch set.
That would be no problem at all. I like that idea and I've prepared a v4
with that change. I'll send it out shortly once I've finished testing.
> My patch set would then shrink a bit. By the way, thanks for reviewing
> it.
No problem! I feel like I'm starting to understand the TEE subsystem and
OP-TEE driver a bit so I'm happy to help out.
Tyler
>
> Cheers,
> Jens
>
next prev parent reply other threads:[~2021-06-10 21:01 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 0:23 [PATCH v3 0/7] tee: Improve support for kexec and kdump Tyler Hicks
2021-06-09 0:23 ` Tyler Hicks
2021-06-09 0:23 ` [PATCH v3 1/7] optee: Fix memory leak when failing to register shm pages Tyler Hicks
2021-06-09 0:23 ` Tyler Hicks
2021-06-09 0:23 ` [PATCH v3 2/7] optee: Refuse to load the driver under the kdump kernel Tyler Hicks
2021-06-09 0:23 ` Tyler Hicks
2021-06-09 0:23 ` [PATCH v3 3/7] optee: fix tee out of memory failure seen during kexec reboot Tyler Hicks
2021-06-09 0:23 ` Tyler Hicks
2021-06-09 0:23 ` [PATCH v3 4/7] optee: Clear stale cache entries during initialization Tyler Hicks
2021-06-09 0:23 ` Tyler Hicks
2021-06-09 0:23 ` [PATCH v3 5/7] tee: Support shm registration without dma-buf backing Tyler Hicks
2021-06-09 0:23 ` Tyler Hicks
2021-06-09 4:29 ` Sumit Garg
2021-06-09 4:29 ` Sumit Garg
2021-06-09 5:46 ` Tyler Hicks
2021-06-09 5:46 ` Tyler Hicks
2021-06-09 10:52 ` Sumit Garg
2021-06-09 10:52 ` Sumit Garg
2021-06-09 12:15 ` Jens Wiklander
2021-06-09 12:15 ` Jens Wiklander
2021-06-09 13:42 ` Tyler Hicks
2021-06-09 13:42 ` Tyler Hicks
2021-06-09 13:51 ` Tyler Hicks
2021-06-09 13:51 ` Tyler Hicks
2021-06-10 7:34 ` Jens Wiklander
2021-06-10 7:34 ` Jens Wiklander
2021-06-10 21:00 ` Tyler Hicks [this message]
2021-06-10 21:00 ` Tyler Hicks
2021-06-10 7:49 ` Jens Wiklander
2021-06-10 7:49 ` Jens Wiklander
2021-06-10 21:05 ` Tyler Hicks
2021-06-10 21:05 ` Tyler Hicks
2021-06-10 7:40 ` Allen Pais
2021-06-10 7:40 ` Allen Pais
2021-06-10 7:18 ` Jens Wiklander
2021-06-10 7:18 ` Jens Wiklander
2021-06-10 12:14 ` Sumit Garg
2021-06-10 12:14 ` Sumit Garg
2021-06-09 0:23 ` [PATCH v3 6/7] tpm_ftpm_tee: Free and unregister dynamic shared memory during kexec Tyler Hicks
2021-06-09 0:23 ` Tyler Hicks
2021-06-09 0:23 ` [PATCH v3 7/7] firmware: tee_bnxt: Release shm, session, and context " Tyler Hicks
2021-06-09 0:23 ` Tyler Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610210056.GO4910@sequoia \
--to=tyhicks@linux.microsoft.com \
--cc=Rijo-john.Thomas@amd.com \
--cc=apais@linux.microsoft.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jarkko@kernel.org \
--cc=jens.wiklander@linaro.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=pasha.tatashin@soleen.com \
--cc=peterhuewe@gmx.de \
--cc=sumit.garg@linaro.org \
--cc=thiruan@microsoft.com \
--cc=vikas.gupta@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.