All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: robh+dt@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sl: add PXP module
Date: Sat, 12 Jun 2021 15:04:17 +0800	[thread overview]
Message-ID: <20210612070416.GV29138@dragon> (raw)
In-Reply-To: <20210527210742.2609-1-andreas@kemnade.info>

On Thu, May 27, 2021 at 11:07:42PM +0200, Andreas Kemnade wrote:
> While the EPDC is optional, all editions have the PXP module, so adding
> it to the corresponding .dtsi
> Information taken from freescale kernel, compared with the
> reference manual and tested by a separate program.
> 
> Since it does not depend on external wiring, the
> status = "disabled" is left out here.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/imx6sl.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 997b96c1c47b..6be83e863f19 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -762,8 +762,11 @@
>  			};
>  
>  			pxp: pxp@20f0000 {
> +				compatible = "fsl,imx6sl-pxp", "fsl,imx6ull-pxp";

"fsl,imx6sl-pxp" needs to be documented.

Shawn

>  				reg = <0x020f0000 0x4000>;
>  				interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX6SL_CLK_PXP_AXI>;
> +				clock-names = "axi";
>  			};
>  
>  			epdc: epdc@20f4000 {
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: robh+dt@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sl: add PXP module
Date: Sat, 12 Jun 2021 15:04:17 +0800	[thread overview]
Message-ID: <20210612070416.GV29138@dragon> (raw)
In-Reply-To: <20210527210742.2609-1-andreas@kemnade.info>

On Thu, May 27, 2021 at 11:07:42PM +0200, Andreas Kemnade wrote:
> While the EPDC is optional, all editions have the PXP module, so adding
> it to the corresponding .dtsi
> Information taken from freescale kernel, compared with the
> reference manual and tested by a separate program.
> 
> Since it does not depend on external wiring, the
> status = "disabled" is left out here.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/imx6sl.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 997b96c1c47b..6be83e863f19 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -762,8 +762,11 @@
>  			};
>  
>  			pxp: pxp@20f0000 {
> +				compatible = "fsl,imx6sl-pxp", "fsl,imx6ull-pxp";

"fsl,imx6sl-pxp" needs to be documented.

Shawn

>  				reg = <0x020f0000 0x4000>;
>  				interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX6SL_CLK_PXP_AXI>;
> +				clock-names = "axi";
>  			};
>  
>  			epdc: epdc@20f4000 {
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-12  7:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 21:07 [PATCH] ARM: dts: imx6sl: add PXP module Andreas Kemnade
2021-05-27 21:07 ` Andreas Kemnade
2021-06-12  7:04 ` Shawn Guo [this message]
2021-06-12  7:04   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210612070416.GV29138@dragon \
    --to=shawnguo@kernel.org \
    --cc=andreas@kemnade.info \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.