* [Buildroot] [PATCH 0/1] mtd-utils-2.1.2: ubihealthd depends on ubifs support
@ 2021-06-09 23:48 Markus Mayer
2021-06-09 23:48 ` [Buildroot] [PATCH 1/1] " Markus Mayer
0 siblings, 1 reply; 6+ messages in thread
From: Markus Mayer @ 2021-06-09 23:48 UTC (permalink / raw)
To: buildroot
Hi all,
With the enabling of ubihealthd, we are experiencing a new build
failure.
https://git.buildroot.net/buildroot/commit/?id=77a0167155c3
Here is what is happening:
>>> mtd 2.1.2 Installing to target
[...]
/usr/bin/install -D -m 0755
/home/mmayer/Development/br-current/output/arm64/build/mtd-2.1.2/ubiformat
/home/mmayer/Development/br-current/output/arm64/target/usr/sbin/ubiformat
/usr/bin/install -D -m 0755
/home/mmayer/Development/br-current/output/arm64/build/mtd-2.1.2/ubihealthd
/home/mmayer/Development/br-current/output/arm64/target/usr/sbin/ubihealthd
/usr/bin/install: cannot stat
'/home/mmayer/Development/br-current/output/arm64/build/mtd-2.1.2/ubihealthd':
No such file or directory
make[1]: *** [package/pkg-generic.mk:341:
/home/mmayer/Development/br-current/output/arm64/build/mtd-2.1.2/.stamp_target_installed]
Error 1
make: *** [Makefile:27: _all] Error 2
The problem is the following:
1. We are building with BR2_PACKAGE_MTD_UBIFS_UTILS unset and,
therefore, with --without-ubifs.
2. Building without ubifs leads to "configure" setting its internal
variable need_getrandom="no", which trickles down through the autoconf
environment.
3. Without getrandom, ubihealthd is not being built
?
From mtd-2.1.2/ubi-utils/Makemodule.am:
?49 if WITH_GETRANDOM
?50 UBI_BINS += ubihealthd
?51 endif
The mtd-utils package is consistent within itself. Everything works as
long as "make install" is being called, because it won't try to install
ubihealthd, unless it also built it. However, Buildroot has its own
install routine. It thinks ubihealthd is enabled and has been built.
Therefore, it tries to install it -- which doesn't work if
BR2_PACKAGE_MTD_UBIFS_UTILS is unset.
This patch mirrors the --with-ubifs -> ubihealthd dependency within
Buildroot. In my tests, it worked either way. It will built and install
ubihealthd (when BR2_PACKAGE_MTD_MKFSUBIFS=y) or it will skip building
and installing ubihealthd (when BR2_PACKAGE_MTD_MKFSUBIFS is unset).
Thanks,
-Markus
Markus Mayer (1):
mtd-utils-2.1.2: ubihealthd depends on ubifs support
package/mtd/Config.in | 1 +
1 file changed, 1 insertion(+)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] mtd-utils-2.1.2: ubihealthd depends on ubifs support
2021-06-09 23:48 [Buildroot] [PATCH 0/1] mtd-utils-2.1.2: ubihealthd depends on ubifs support Markus Mayer
@ 2021-06-09 23:48 ` Markus Mayer
2021-06-10 4:36 ` Heiko Thiery
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Markus Mayer @ 2021-06-09 23:48 UTC (permalink / raw)
To: buildroot
ubihealthd is only being built, if mtd-utils are being built
--with-ubifs. Reflect that dependency within buildroot.
Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---
package/mtd/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/mtd/Config.in b/package/mtd/Config.in
index c7ad3b3cdc9c..64a7ae19a7e2 100644
--- a/package/mtd/Config.in
+++ b/package/mtd/Config.in
@@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT
config BR2_PACKAGE_MTD_UBIHEALTHD
bool "ubihealthd"
+ depends on BR2_PACKAGE_MTD_UBIFS_UTILS
default y
config BR2_PACKAGE_MTD_UBIMKVOL
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] mtd-utils-2.1.2: ubihealthd depends on ubifs support
2021-06-09 23:48 ` [Buildroot] [PATCH 1/1] " Markus Mayer
@ 2021-06-10 4:36 ` Heiko Thiery
2021-06-10 18:56 ` Markus Mayer
2021-06-10 19:25 ` Heiko Thiery
2021-06-13 12:35 ` Yann E. MORIN
2 siblings, 1 reply; 6+ messages in thread
From: Heiko Thiery @ 2021-06-10 4:36 UTC (permalink / raw)
To: buildroot
Hallo Markus,
Am Do., 10. Juni 2021 um 01:54 Uhr schrieb Markus Mayer via buildroot
<buildroot@busybox.net>:
>
> ubihealthd is only being built, if mtd-utils are being built
> --with-ubifs. Reflect that dependency within buildroot.
>
This seems to fix the issue reported to the commiter:
http://lists.busybox.net/pipermail/buildroot/2021-June/311951.html
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
> package/mtd/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/mtd/Config.in b/package/mtd/Config.in
> index c7ad3b3cdc9c..64a7ae19a7e2 100644
> --- a/package/mtd/Config.in
> +++ b/package/mtd/Config.in
> @@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT
>
> config BR2_PACKAGE_MTD_UBIHEALTHD
> bool "ubihealthd"
> + depends on BR2_PACKAGE_MTD_UBIFS_UTILS
> default y
>
> config BR2_PACKAGE_MTD_UBIMKVOL
Thanks
--
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] mtd-utils-2.1.2: ubihealthd depends on ubifs support
2021-06-10 4:36 ` Heiko Thiery
@ 2021-06-10 18:56 ` Markus Mayer
0 siblings, 0 replies; 6+ messages in thread
From: Markus Mayer @ 2021-06-10 18:56 UTC (permalink / raw)
To: buildroot
On Wed, 9 Jun 2021 at 21:36, Heiko Thiery <heiko.thiery@gmail.com> wrote:
> > ubihealthd is only being built, if mtd-utils are being built
> > --with-ubifs. Reflect that dependency within buildroot.
> >
>
> This seems to fix the issue reported to the commiter:
> http://lists.busybox.net/pipermail/buildroot/2021-June/311951.html
Yes, it does look like it would address this issue. Have you been able
to confirm that it addresses the problem? If so, can you reply with a
Tested-by?
Thanks,
-Markus
> > Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> > ---
> > package/mtd/Config.in | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/package/mtd/Config.in b/package/mtd/Config.in
> > index c7ad3b3cdc9c..64a7ae19a7e2 100644
> > --- a/package/mtd/Config.in
> > +++ b/package/mtd/Config.in
> > @@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT
> >
> > config BR2_PACKAGE_MTD_UBIHEALTHD
> > bool "ubihealthd"
> > + depends on BR2_PACKAGE_MTD_UBIFS_UTILS
> > default y
> >
> > config BR2_PACKAGE_MTD_UBIMKVOL
>
> Thanks
> --
> Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] mtd-utils-2.1.2: ubihealthd depends on ubifs support
2021-06-09 23:48 ` [Buildroot] [PATCH 1/1] " Markus Mayer
2021-06-10 4:36 ` Heiko Thiery
@ 2021-06-10 19:25 ` Heiko Thiery
2021-06-13 12:35 ` Yann E. MORIN
2 siblings, 0 replies; 6+ messages in thread
From: Heiko Thiery @ 2021-06-10 19:25 UTC (permalink / raw)
To: buildroot
Hi Markus,
Am Do., 10. Juni 2021 um 01:54 Uhr schrieb Markus Mayer via buildroot
<buildroot@busybox.net>:
>
> ubihealthd is only being built, if mtd-utils are being built
> --with-ubifs. Reflect that dependency within buildroot.
>
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
Tested-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> package/mtd/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/mtd/Config.in b/package/mtd/Config.in
> index c7ad3b3cdc9c..64a7ae19a7e2 100644
> --- a/package/mtd/Config.in
> +++ b/package/mtd/Config.in
> @@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT
>
> config BR2_PACKAGE_MTD_UBIHEALTHD
> bool "ubihealthd"
> + depends on BR2_PACKAGE_MTD_UBIFS_UTILS
> default y
>
> config BR2_PACKAGE_MTD_UBIMKVOL
Thanks
--
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] mtd-utils-2.1.2: ubihealthd depends on ubifs support
2021-06-09 23:48 ` [Buildroot] [PATCH 1/1] " Markus Mayer
2021-06-10 4:36 ` Heiko Thiery
2021-06-10 19:25 ` Heiko Thiery
@ 2021-06-13 12:35 ` Yann E. MORIN
2 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2021-06-13 12:35 UTC (permalink / raw)
To: buildroot
Markus, All,
On 2021-06-09 16:48 -0700, Markus Mayer via buildroot spake thusly:
> ubihealthd is only being built, if mtd-utils are being built
> --with-ubifs. Reflect that dependency within buildroot.
>
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
> package/mtd/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/mtd/Config.in b/package/mtd/Config.in
> index c7ad3b3cdc9c..64a7ae19a7e2 100644
> --- a/package/mtd/Config.in
> +++ b/package/mtd/Config.in
> @@ -139,6 +139,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT
>
> config BR2_PACKAGE_MTD_UBIHEALTHD
> bool "ubihealthd"
> + depends on BR2_PACKAGE_MTD_UBIFS_UTILS
# make check-package
package/mtd/Config.in:143: attributes order: type, default, depends on, select, help (http://nightly.buildroot.org/#_config_files)
Applied to master with the above fixed, thanks.
Regards,
Yann E. MORIN.
> default y
>
> config BR2_PACKAGE_MTD_UBIMKVOL
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-13 12:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-09 23:48 [Buildroot] [PATCH 0/1] mtd-utils-2.1.2: ubihealthd depends on ubifs support Markus Mayer
2021-06-09 23:48 ` [Buildroot] [PATCH 1/1] " Markus Mayer
2021-06-10 4:36 ` Heiko Thiery
2021-06-10 18:56 ` Markus Mayer
2021-06-10 19:25 ` Heiko Thiery
2021-06-13 12:35 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.