From: Catalin Marinas <catalin.marinas@arm.com>
To: Will Deacon <will@kernel.org>
Cc: Yu Zhao <yuzhao@google.com>, Jia He <justin.he@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <maz@kernel.org>,
Suzuki Poulose <Suzuki.Poulose@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: mm: fix warning in arch_faults_on_old_pte()
Date: Tue, 15 Jun 2021 14:47:33 +0100 [thread overview]
Message-ID: <20210615134733.GI26027@arm.com> (raw)
In-Reply-To: <20210615105230.GD20225@willie-the-truck>
On Tue, Jun 15, 2021 at 11:52:30AM +0100, Will Deacon wrote:
> On Sun, Jun 13, 2021 at 03:47:28PM -0600, Yu Zhao wrote:
> > cow_user_page() doesn't disable preemption, and it triggers the
> > warning in arch_faults_on_old_pte() when CONFIG_PREEMPT_COUNT=y.
>
> Doesn't kmap_atomic() disable preemption?
Good point, I missed that. I wonder whether there are additional patches
on top that replace it with kmap_local_page(). I couldn't see any in
-next.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-15 14:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 21:47 [PATCH] arm64: mm: fix warning in arch_faults_on_old_pte() Yu Zhao
2021-06-14 17:07 ` Catalin Marinas
2021-06-14 18:35 ` Yu Zhao
2021-06-15 10:35 ` Catalin Marinas
2021-06-15 10:48 ` Will Deacon
2021-06-15 10:40 ` Suzuki K Poulose
2021-06-15 10:52 ` Will Deacon
2021-06-15 13:47 ` Catalin Marinas [this message]
2021-06-16 7:27 ` Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615134733.GI26027@arm.com \
--to=catalin.marinas@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=justin.he@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=will@kernel.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.