* [PATCH 0/2] phy: Add support for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-04 19:03 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-04 19:03 UTC (permalink / raw) To: robh+dt, linux-phy, devicetree, linux-amlogic Cc: kishon, vkoul, linux-arm-kernel, linux-kernel, Martin Blumenstingl Amlogic Meson8/8b/8m2 SoCs embed a HDMI TX PHY. Unfortunately there is no (public) documentation for this hardware. The best thing we have is the 3.10 vendor kernel, which unfortunately doesn't document most register bits (only a few are named there, the rest is all magic numbers). It is possible that this is a TranSwitch HDMI TX PHY based core, but this is pure speculation. Adding a driver for the HDMI TX PHY gets us one step closer to video output on these older SoCs. Martin Blumenstingl (2): dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 ++++++ drivers/phy/amlogic/Kconfig | 11 ++ drivers/phy/amlogic/Makefile | 1 + drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 ++++++++++++++++++ 4 files changed, 213 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c -- 2.31.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 0/2] phy: Add support for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-04 19:03 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-04 19:03 UTC (permalink / raw) To: robh+dt, linux-phy, devicetree, linux-amlogic Cc: kishon, vkoul, linux-arm-kernel, linux-kernel, Martin Blumenstingl Amlogic Meson8/8b/8m2 SoCs embed a HDMI TX PHY. Unfortunately there is no (public) documentation for this hardware. The best thing we have is the 3.10 vendor kernel, which unfortunately doesn't document most register bits (only a few are named there, the rest is all magic numbers). It is possible that this is a TranSwitch HDMI TX PHY based core, but this is pure speculation. Adding a driver for the HDMI TX PHY gets us one step closer to video output on these older SoCs. Martin Blumenstingl (2): dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 ++++++ drivers/phy/amlogic/Kconfig | 11 ++ drivers/phy/amlogic/Makefile | 1 + drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 ++++++++++++++++++ 4 files changed, 213 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c -- 2.31.1 ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 0/2] phy: Add support for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-04 19:03 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-04 19:03 UTC (permalink / raw) To: robh+dt, linux-phy, devicetree, linux-amlogic Cc: kishon, vkoul, linux-arm-kernel, linux-kernel, Martin Blumenstingl Amlogic Meson8/8b/8m2 SoCs embed a HDMI TX PHY. Unfortunately there is no (public) documentation for this hardware. The best thing we have is the 3.10 vendor kernel, which unfortunately doesn't document most register bits (only a few are named there, the rest is all magic numbers). It is possible that this is a TranSwitch HDMI TX PHY based core, but this is pure speculation. Adding a driver for the HDMI TX PHY gets us one step closer to video output on these older SoCs. Martin Blumenstingl (2): dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 ++++++ drivers/phy/amlogic/Kconfig | 11 ++ drivers/phy/amlogic/Makefile | 1 + drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 ++++++++++++++++++ 4 files changed, 213 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c -- 2.31.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 0/2] phy: Add support for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-04 19:03 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-04 19:03 UTC (permalink / raw) To: robh+dt, linux-phy, devicetree, linux-amlogic Cc: kishon, vkoul, linux-arm-kernel, linux-kernel, Martin Blumenstingl Amlogic Meson8/8b/8m2 SoCs embed a HDMI TX PHY. Unfortunately there is no (public) documentation for this hardware. The best thing we have is the 3.10 vendor kernel, which unfortunately doesn't document most register bits (only a few are named there, the rest is all magic numbers). It is possible that this is a TranSwitch HDMI TX PHY based core, but this is pure speculation. Adding a driver for the HDMI TX PHY gets us one step closer to video output on these older SoCs. Martin Blumenstingl (2): dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 ++++++ drivers/phy/amlogic/Kconfig | 11 ++ drivers/phy/amlogic/Makefile | 1 + drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 ++++++++++++++++++ 4 files changed, 213 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c -- 2.31.1 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings 2021-06-04 19:03 ` Martin Blumenstingl (?) (?) @ 2021-06-04 19:03 ` Martin Blumenstingl -1 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-04 19:03 UTC (permalink / raw) To: robh+dt, linux-phy, devicetree, linux-amlogic Cc: kishon, vkoul, linux-arm-kernel, linux-kernel, Martin Blumenstingl Amlogic Meson8, Meson8b and Meson8m2 all include an identical (or at least very similar) HDMI TX PHY. The PHY registers are part of the HHI register area. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml new file mode 100644 index 000000000000..18a123b9bb0a --- /dev/null +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/amlogic,meson8-hdmi-tx-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic Meson8, Meson8b and Meson8m2 HDMI TX PHY + +maintainers: + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> + +description: |+ + The HDMI TX PHY node should be the child of a syscon node with the + required property: + + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" + + Refer to the bindings described in + Documentation/devicetree/bindings/mfd/syscon.yaml + +properties: + $nodename: + pattern: "^hdmi-phy$" + + compatible: + enum: + - amlogic,meson8-hdmi-tx-phy + - amlogic,meson8b-hdmi-tx-phy + - amlogic,meson8m2-hdmi-tx-phy + + clocks: + minItems: 1 + description: + HDMI TMDS clock + + "#phy-cells": + const: 0 + +required: + - compatible + - "#phy-cells" + +additionalProperties: false + +examples: + - | + hdmi_tx_phy: hdmi-phy { + compatible = "amlogic,meson8-hdmi-tx-phy"; + clocks = <&tmds_clock>; + #phy-cells = <0>; + }; -- 2.31.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings @ 2021-06-04 19:03 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-04 19:03 UTC (permalink / raw) To: robh+dt, linux-phy, devicetree, linux-amlogic Cc: kishon, vkoul, linux-arm-kernel, linux-kernel, Martin Blumenstingl Amlogic Meson8, Meson8b and Meson8m2 all include an identical (or at least very similar) HDMI TX PHY. The PHY registers are part of the HHI register area. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml new file mode 100644 index 000000000000..18a123b9bb0a --- /dev/null +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/amlogic,meson8-hdmi-tx-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic Meson8, Meson8b and Meson8m2 HDMI TX PHY + +maintainers: + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> + +description: |+ + The HDMI TX PHY node should be the child of a syscon node with the + required property: + + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" + + Refer to the bindings described in + Documentation/devicetree/bindings/mfd/syscon.yaml + +properties: + $nodename: + pattern: "^hdmi-phy$" + + compatible: + enum: + - amlogic,meson8-hdmi-tx-phy + - amlogic,meson8b-hdmi-tx-phy + - amlogic,meson8m2-hdmi-tx-phy + + clocks: + minItems: 1 + description: + HDMI TMDS clock + + "#phy-cells": + const: 0 + +required: + - compatible + - "#phy-cells" + +additionalProperties: false + +examples: + - | + hdmi_tx_phy: hdmi-phy { + compatible = "amlogic,meson8-hdmi-tx-phy"; + clocks = <&tmds_clock>; + #phy-cells = <0>; + }; -- 2.31.1 ^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings @ 2021-06-04 19:03 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-04 19:03 UTC (permalink / raw) To: robh+dt, linux-phy, devicetree, linux-amlogic Cc: kishon, vkoul, linux-arm-kernel, linux-kernel, Martin Blumenstingl Amlogic Meson8, Meson8b and Meson8m2 all include an identical (or at least very similar) HDMI TX PHY. The PHY registers are part of the HHI register area. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml new file mode 100644 index 000000000000..18a123b9bb0a --- /dev/null +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/amlogic,meson8-hdmi-tx-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic Meson8, Meson8b and Meson8m2 HDMI TX PHY + +maintainers: + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> + +description: |+ + The HDMI TX PHY node should be the child of a syscon node with the + required property: + + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" + + Refer to the bindings described in + Documentation/devicetree/bindings/mfd/syscon.yaml + +properties: + $nodename: + pattern: "^hdmi-phy$" + + compatible: + enum: + - amlogic,meson8-hdmi-tx-phy + - amlogic,meson8b-hdmi-tx-phy + - amlogic,meson8m2-hdmi-tx-phy + + clocks: + minItems: 1 + description: + HDMI TMDS clock + + "#phy-cells": + const: 0 + +required: + - compatible + - "#phy-cells" + +additionalProperties: false + +examples: + - | + hdmi_tx_phy: hdmi-phy { + compatible = "amlogic,meson8-hdmi-tx-phy"; + clocks = <&tmds_clock>; + #phy-cells = <0>; + }; -- 2.31.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings @ 2021-06-04 19:03 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-04 19:03 UTC (permalink / raw) To: robh+dt, linux-phy, devicetree, linux-amlogic Cc: kishon, vkoul, linux-arm-kernel, linux-kernel, Martin Blumenstingl Amlogic Meson8, Meson8b and Meson8m2 all include an identical (or at least very similar) HDMI TX PHY. The PHY registers are part of the HHI register area. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml new file mode 100644 index 000000000000..18a123b9bb0a --- /dev/null +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/amlogic,meson8-hdmi-tx-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic Meson8, Meson8b and Meson8m2 HDMI TX PHY + +maintainers: + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> + +description: |+ + The HDMI TX PHY node should be the child of a syscon node with the + required property: + + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" + + Refer to the bindings described in + Documentation/devicetree/bindings/mfd/syscon.yaml + +properties: + $nodename: + pattern: "^hdmi-phy$" + + compatible: + enum: + - amlogic,meson8-hdmi-tx-phy + - amlogic,meson8b-hdmi-tx-phy + - amlogic,meson8m2-hdmi-tx-phy + + clocks: + minItems: 1 + description: + HDMI TMDS clock + + "#phy-cells": + const: 0 + +required: + - compatible + - "#phy-cells" + +additionalProperties: false + +examples: + - | + hdmi_tx_phy: hdmi-phy { + compatible = "amlogic,meson8-hdmi-tx-phy"; + clocks = <&tmds_clock>; + #phy-cells = <0>; + }; -- 2.31.1 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings 2021-06-04 19:03 ` Martin Blumenstingl (?) (?) @ 2021-06-16 23:31 ` Rob Herring -1 siblings, 0 replies; 28+ messages in thread From: Rob Herring @ 2021-06-16 23:31 UTC (permalink / raw) To: Martin Blumenstingl Cc: linux-phy, devicetree, linux-amlogic, kishon, vkoul, linux-arm-kernel, linux-kernel On Fri, Jun 04, 2021 at 09:03:37PM +0200, Martin Blumenstingl wrote: > Amlogic Meson8, Meson8b and Meson8m2 all include an identical (or at > least very similar) HDMI TX PHY. The PHY registers are part of the HHI > register area. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > new file mode 100644 > index 000000000000..18a123b9bb0a > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson8-hdmi-tx-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic Meson8, Meson8b and Meson8m2 HDMI TX PHY > + > +maintainers: > + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> > + > +description: |+ > + The HDMI TX PHY node should be the child of a syscon node with the > + required property: > + > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" Is there a sub range of registers for this functionality in "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property. > + > + Refer to the bindings described in > + Documentation/devicetree/bindings/mfd/syscon.yaml > + > +properties: > + $nodename: > + pattern: "^hdmi-phy$" > + > + compatible: > + enum: > + - amlogic,meson8-hdmi-tx-phy > + - amlogic,meson8b-hdmi-tx-phy > + - amlogic,meson8m2-hdmi-tx-phy > + > + clocks: > + minItems: 1 > + description: > + HDMI TMDS clock > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + hdmi_tx_phy: hdmi-phy { > + compatible = "amlogic,meson8-hdmi-tx-phy"; > + clocks = <&tmds_clock>; > + #phy-cells = <0>; > + }; > -- > 2.31.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings @ 2021-06-16 23:31 ` Rob Herring 0 siblings, 0 replies; 28+ messages in thread From: Rob Herring @ 2021-06-16 23:31 UTC (permalink / raw) To: Martin Blumenstingl Cc: linux-phy, devicetree, linux-amlogic, kishon, vkoul, linux-arm-kernel, linux-kernel On Fri, Jun 04, 2021 at 09:03:37PM +0200, Martin Blumenstingl wrote: > Amlogic Meson8, Meson8b and Meson8m2 all include an identical (or at > least very similar) HDMI TX PHY. The PHY registers are part of the HHI > register area. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > new file mode 100644 > index 000000000000..18a123b9bb0a > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson8-hdmi-tx-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic Meson8, Meson8b and Meson8m2 HDMI TX PHY > + > +maintainers: > + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> > + > +description: |+ > + The HDMI TX PHY node should be the child of a syscon node with the > + required property: > + > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" Is there a sub range of registers for this functionality in "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property. > + > + Refer to the bindings described in > + Documentation/devicetree/bindings/mfd/syscon.yaml > + > +properties: > + $nodename: > + pattern: "^hdmi-phy$" > + > + compatible: > + enum: > + - amlogic,meson8-hdmi-tx-phy > + - amlogic,meson8b-hdmi-tx-phy > + - amlogic,meson8m2-hdmi-tx-phy > + > + clocks: > + minItems: 1 > + description: > + HDMI TMDS clock > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + hdmi_tx_phy: hdmi-phy { > + compatible = "amlogic,meson8-hdmi-tx-phy"; > + clocks = <&tmds_clock>; > + #phy-cells = <0>; > + }; > -- > 2.31.1 ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings @ 2021-06-16 23:31 ` Rob Herring 0 siblings, 0 replies; 28+ messages in thread From: Rob Herring @ 2021-06-16 23:31 UTC (permalink / raw) To: Martin Blumenstingl Cc: linux-phy, devicetree, linux-amlogic, kishon, vkoul, linux-arm-kernel, linux-kernel On Fri, Jun 04, 2021 at 09:03:37PM +0200, Martin Blumenstingl wrote: > Amlogic Meson8, Meson8b and Meson8m2 all include an identical (or at > least very similar) HDMI TX PHY. The PHY registers are part of the HHI > register area. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > new file mode 100644 > index 000000000000..18a123b9bb0a > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson8-hdmi-tx-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic Meson8, Meson8b and Meson8m2 HDMI TX PHY > + > +maintainers: > + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> > + > +description: |+ > + The HDMI TX PHY node should be the child of a syscon node with the > + required property: > + > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" Is there a sub range of registers for this functionality in "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property. > + > + Refer to the bindings described in > + Documentation/devicetree/bindings/mfd/syscon.yaml > + > +properties: > + $nodename: > + pattern: "^hdmi-phy$" > + > + compatible: > + enum: > + - amlogic,meson8-hdmi-tx-phy > + - amlogic,meson8b-hdmi-tx-phy > + - amlogic,meson8m2-hdmi-tx-phy > + > + clocks: > + minItems: 1 > + description: > + HDMI TMDS clock > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + hdmi_tx_phy: hdmi-phy { > + compatible = "amlogic,meson8-hdmi-tx-phy"; > + clocks = <&tmds_clock>; > + #phy-cells = <0>; > + }; > -- > 2.31.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings @ 2021-06-16 23:31 ` Rob Herring 0 siblings, 0 replies; 28+ messages in thread From: Rob Herring @ 2021-06-16 23:31 UTC (permalink / raw) To: Martin Blumenstingl Cc: linux-phy, devicetree, linux-amlogic, kishon, vkoul, linux-arm-kernel, linux-kernel On Fri, Jun 04, 2021 at 09:03:37PM +0200, Martin Blumenstingl wrote: > Amlogic Meson8, Meson8b and Meson8m2 all include an identical (or at > least very similar) HDMI TX PHY. The PHY registers are part of the HHI > register area. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > .../phy/amlogic,meson8-hdmi-tx-phy.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > new file mode 100644 > index 000000000000..18a123b9bb0a > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson8-hdmi-tx-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic Meson8, Meson8b and Meson8m2 HDMI TX PHY > + > +maintainers: > + - Martin Blumenstingl <martin.blumenstingl@googlemail.com> > + > +description: |+ > + The HDMI TX PHY node should be the child of a syscon node with the > + required property: > + > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" Is there a sub range of registers for this functionality in "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property. > + > + Refer to the bindings described in > + Documentation/devicetree/bindings/mfd/syscon.yaml > + > +properties: > + $nodename: > + pattern: "^hdmi-phy$" > + > + compatible: > + enum: > + - amlogic,meson8-hdmi-tx-phy > + - amlogic,meson8b-hdmi-tx-phy > + - amlogic,meson8m2-hdmi-tx-phy > + > + clocks: > + minItems: 1 > + description: > + HDMI TMDS clock > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + hdmi_tx_phy: hdmi-phy { > + compatible = "amlogic,meson8-hdmi-tx-phy"; > + clocks = <&tmds_clock>; > + #phy-cells = <0>; > + }; > -- > 2.31.1 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings 2021-06-16 23:31 ` Rob Herring (?) (?) @ 2021-06-17 22:30 ` Martin Blumenstingl -1 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-17 22:30 UTC (permalink / raw) To: Rob Herring Cc: linux-phy, devicetree, linux-amlogic, kishon, vkoul, linux-arm-kernel, linux-kernel Hi Rob, On Thu, Jun 17, 2021 at 1:31 AM Rob Herring <robh@kernel.org> wrote: [...] > > +description: |+ > > + The HDMI TX PHY node should be the child of a syscon node with the > > + required property: > > + > > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" > > Is there a sub range of registers for this functionality in > "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property. yes, for this part of the HHI registers there's a dedicated sub range. I'll add a reg property with register offset and size one question about .dts validation: at least the clock controller (which is also a sub-node of this) does not have a dedicated sub range. Is it still OK in this case to set #size-cells = <1> and #address-cells = <1> in the HHI node? Best regards, Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings @ 2021-06-17 22:30 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-17 22:30 UTC (permalink / raw) To: Rob Herring Cc: linux-phy, devicetree, linux-amlogic, kishon, vkoul, linux-arm-kernel, linux-kernel Hi Rob, On Thu, Jun 17, 2021 at 1:31 AM Rob Herring <robh@kernel.org> wrote: [...] > > +description: |+ > > + The HDMI TX PHY node should be the child of a syscon node with the > > + required property: > > + > > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" > > Is there a sub range of registers for this functionality in > "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property. yes, for this part of the HHI registers there's a dedicated sub range. I'll add a reg property with register offset and size one question about .dts validation: at least the clock controller (which is also a sub-node of this) does not have a dedicated sub range. Is it still OK in this case to set #size-cells = <1> and #address-cells = <1> in the HHI node? Best regards, Martin ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings @ 2021-06-17 22:30 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-17 22:30 UTC (permalink / raw) To: Rob Herring Cc: linux-phy, devicetree, linux-amlogic, kishon, vkoul, linux-arm-kernel, linux-kernel Hi Rob, On Thu, Jun 17, 2021 at 1:31 AM Rob Herring <robh@kernel.org> wrote: [...] > > +description: |+ > > + The HDMI TX PHY node should be the child of a syscon node with the > > + required property: > > + > > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" > > Is there a sub range of registers for this functionality in > "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property. yes, for this part of the HHI registers there's a dedicated sub range. I'll add a reg property with register offset and size one question about .dts validation: at least the clock controller (which is also a sub-node of this) does not have a dedicated sub range. Is it still OK in this case to set #size-cells = <1> and #address-cells = <1> in the HHI node? Best regards, Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings @ 2021-06-17 22:30 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-17 22:30 UTC (permalink / raw) To: Rob Herring Cc: linux-phy, devicetree, linux-amlogic, kishon, vkoul, linux-arm-kernel, linux-kernel Hi Rob, On Thu, Jun 17, 2021 at 1:31 AM Rob Herring <robh@kernel.org> wrote: [...] > > +description: |+ > > + The HDMI TX PHY node should be the child of a syscon node with the > > + required property: > > + > > + compatible = "amlogic,meson-hhi-sysctrl", "simple-mfd", "syscon" > > Is there a sub range of registers for this functionality in > "amlogic,meson-hhi-sysctrl"? If so, please add a 'reg' property. yes, for this part of the HHI registers there's a dedicated sub range. I'll add a reg property with register offset and size one question about .dts validation: at least the clock controller (which is also a sub-node of this) does not have a dedicated sub range. Is it still OK in this case to set #size-cells = <1> and #address-cells = <1> in the HHI node? Best regards, Martin -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 2021-06-04 19:03 ` Martin Blumenstingl (?) (?) @ 2021-06-04 19:03 ` Martin Blumenstingl -1 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-04 19:03 UTC (permalink / raw) To: robh+dt, linux-phy, devicetree, linux-amlogic Cc: kishon, vkoul, linux-arm-kernel, linux-kernel, Martin Blumenstingl Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register region. Unfortunately only few register bits are documented. For HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor kernel. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/phy/amlogic/Kconfig | 11 ++ drivers/phy/amlogic/Makefile | 1 + drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ 3 files changed, 162 insertions(+) create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig index db5d0cd757e3..e6c3a2a8b769 100644 --- a/drivers/phy/amlogic/Kconfig +++ b/drivers/phy/amlogic/Kconfig @@ -2,6 +2,17 @@ # # Phy drivers for Amlogic platforms # +config PHY_MESON8_HDMI_TX + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" + default ARCH_MESON + depends on (ARCH_MESON && ARM) || COMPILE_TEST + depends on OF + select MFD_SYSCON + help + Enable this to support the HDMI TX PHYs found in Meson8, + Meson8b and Meson8m2 SoCs. + If unsure, say N. + config PHY_MESON8B_USB2 tristate "Meson8, Meson8b, Meson8m2 and GXBB USB2 PHY driver" default ARCH_MESON diff --git a/drivers/phy/amlogic/Makefile b/drivers/phy/amlogic/Makefile index 8fa07fbd0d92..c0886c850bb0 100644 --- a/drivers/phy/amlogic/Makefile +++ b/drivers/phy/amlogic/Makefile @@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_PHY_MESON8_HDMI_TX) += phy-meson8-hdmi-tx.o obj-$(CONFIG_PHY_MESON8B_USB2) += phy-meson8b-usb2.o obj-$(CONFIG_PHY_MESON_GXL_USB2) += phy-meson-gxl-usb2.o obj-$(CONFIG_PHY_MESON_G12A_USB2) += phy-meson-g12a-usb2.o diff --git a/drivers/phy/amlogic/phy-meson8-hdmi-tx.c b/drivers/phy/amlogic/phy-meson8-hdmi-tx.c new file mode 100644 index 000000000000..8f13960a4492 --- /dev/null +++ b/drivers/phy/amlogic/phy-meson8-hdmi-tx.c @@ -0,0 +1,150 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. + * + * Copyright (C) 2020 Martin Blumenstingl <martin.blumenstingl@googlemail.com> + */ + +#include <linux/bitfield.h> +#include <linux/bits.h> +#include <linux/clk.h> +#include <linux/mfd/syscon.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/phy/phy.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> + +#define HHI_HDMI_PHY_CNTL0 0x3a0 + #define HHI_HDMI_PHY_CNTL0_HDMI_CTL1 GENMASK(31, 16) + #define HHI_HDMI_PHY_CNTL0_HDMI_CTL0 GENMASK(15, 0) + +#define HHI_HDMI_PHY_CNTL1 0x3a4 + #define HHI_HDMI_PHY_CNTL1_CLOCK_ENABLE BIT(1) + #define HHI_HDMI_PHY_CNTL1_SOFT_RESET BIT(0) + +#define HHI_HDMI_PHY_CNTL2 0x3a8 + +struct phy_meson8_hdmi_tx_priv { + struct regmap *hhi; + struct clk *tmds_clk; +}; + +static int phy_meson8_hdmi_tx_init(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + + return clk_prepare_enable(priv->tmds_clk); +} + +static int phy_meson8_hdmi_tx_exit(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + + clk_disable_unprepare(priv->tmds_clk); + + return 0; +} + +static int phy_meson8_hdmi_tx_power_on(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + unsigned int i; + u16 hdmi_ctl0; + + if (clk_get_rate(priv->tmds_clk) >= 2970UL * 1000 * 1000) + hdmi_ctl0 = 0x1e8b; + else + hdmi_ctl0 = 0x4d0b; + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL0, + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL1, 0x08c3) | + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL0, hdmi_ctl0)); + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, 0x00000000); + + /* Reset three times, just like the vendor driver does */ + for (i = 0; i < 3; i++) { + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, + HHI_HDMI_PHY_CNTL1_CLOCK_ENABLE | + HHI_HDMI_PHY_CNTL1_SOFT_RESET); + usleep_range(1000, 2000); + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, + HHI_HDMI_PHY_CNTL1_CLOCK_ENABLE); + usleep_range(1000, 2000); + } + + return 0; +} + +static int phy_meson8_hdmi_tx_power_off(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL0, + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL1, 0x0841) | + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL0, 0x8d00)); + + return 0; +} + +static const struct phy_ops phy_meson8_hdmi_tx_ops = { + .init = phy_meson8_hdmi_tx_init, + .exit = phy_meson8_hdmi_tx_exit, + .power_on = phy_meson8_hdmi_tx_power_on, + .power_off = phy_meson8_hdmi_tx_power_off, + .owner = THIS_MODULE, +}; + +static int phy_meson8_hdmi_tx_probe(struct platform_device *pdev) +{ + struct device_node *np = pdev->dev.of_node; + struct phy_meson8_hdmi_tx_priv *priv; + struct phy_provider *phy_provider; + struct phy *phy; + + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->hhi = syscon_node_to_regmap(np->parent); + if (IS_ERR(priv->hhi)) + return PTR_ERR(priv->hhi); + + priv->tmds_clk = devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(priv->tmds_clk)) + return PTR_ERR(priv->tmds_clk); + + phy = devm_phy_create(&pdev->dev, np, &phy_meson8_hdmi_tx_ops); + if (IS_ERR(phy)) + return PTR_ERR(phy); + + phy_set_drvdata(phy, priv); + + phy_provider = devm_of_phy_provider_register(&pdev->dev, + of_phy_simple_xlate); + + return PTR_ERR_OR_ZERO(phy_provider); +} + +static const struct of_device_id phy_meson8_hdmi_tx_of_match[] = { + { .compatible = "amlogic,meson8-hdmi-tx-phy" }, + { .compatible = "amlogic,meson8b-hdmi-tx-phy" }, + { .compatible = "amlogic,meson8m2-hdmi-tx-phy" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, phy_meson8_hdmi_tx_of_match); + +static struct platform_driver phy_meson8_hdmi_tx_driver = { + .probe = phy_meson8_hdmi_tx_probe, + .driver = { + .name = "phy-meson8-hdmi-tx", + .of_match_table = phy_meson8_hdmi_tx_of_match, + }, +}; +module_platform_driver(phy_meson8_hdmi_tx_driver); + +MODULE_AUTHOR("Martin Blumenstingl <martin.blumenstingl@googlemail.com>"); +MODULE_DESCRIPTION("Meson8, Meson8b and Meson8m2 HDMI TX PHY driver"); +MODULE_LICENSE("GPL v2"); -- 2.31.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-04 19:03 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-04 19:03 UTC (permalink / raw) To: robh+dt, linux-phy, devicetree, linux-amlogic Cc: kishon, vkoul, linux-arm-kernel, linux-kernel, Martin Blumenstingl Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register region. Unfortunately only few register bits are documented. For HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor kernel. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/phy/amlogic/Kconfig | 11 ++ drivers/phy/amlogic/Makefile | 1 + drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ 3 files changed, 162 insertions(+) create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig index db5d0cd757e3..e6c3a2a8b769 100644 --- a/drivers/phy/amlogic/Kconfig +++ b/drivers/phy/amlogic/Kconfig @@ -2,6 +2,17 @@ # # Phy drivers for Amlogic platforms # +config PHY_MESON8_HDMI_TX + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" + default ARCH_MESON + depends on (ARCH_MESON && ARM) || COMPILE_TEST + depends on OF + select MFD_SYSCON + help + Enable this to support the HDMI TX PHYs found in Meson8, + Meson8b and Meson8m2 SoCs. + If unsure, say N. + config PHY_MESON8B_USB2 tristate "Meson8, Meson8b, Meson8m2 and GXBB USB2 PHY driver" default ARCH_MESON diff --git a/drivers/phy/amlogic/Makefile b/drivers/phy/amlogic/Makefile index 8fa07fbd0d92..c0886c850bb0 100644 --- a/drivers/phy/amlogic/Makefile +++ b/drivers/phy/amlogic/Makefile @@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_PHY_MESON8_HDMI_TX) += phy-meson8-hdmi-tx.o obj-$(CONFIG_PHY_MESON8B_USB2) += phy-meson8b-usb2.o obj-$(CONFIG_PHY_MESON_GXL_USB2) += phy-meson-gxl-usb2.o obj-$(CONFIG_PHY_MESON_G12A_USB2) += phy-meson-g12a-usb2.o diff --git a/drivers/phy/amlogic/phy-meson8-hdmi-tx.c b/drivers/phy/amlogic/phy-meson8-hdmi-tx.c new file mode 100644 index 000000000000..8f13960a4492 --- /dev/null +++ b/drivers/phy/amlogic/phy-meson8-hdmi-tx.c @@ -0,0 +1,150 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. + * + * Copyright (C) 2020 Martin Blumenstingl <martin.blumenstingl@googlemail.com> + */ + +#include <linux/bitfield.h> +#include <linux/bits.h> +#include <linux/clk.h> +#include <linux/mfd/syscon.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/phy/phy.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> + +#define HHI_HDMI_PHY_CNTL0 0x3a0 + #define HHI_HDMI_PHY_CNTL0_HDMI_CTL1 GENMASK(31, 16) + #define HHI_HDMI_PHY_CNTL0_HDMI_CTL0 GENMASK(15, 0) + +#define HHI_HDMI_PHY_CNTL1 0x3a4 + #define HHI_HDMI_PHY_CNTL1_CLOCK_ENABLE BIT(1) + #define HHI_HDMI_PHY_CNTL1_SOFT_RESET BIT(0) + +#define HHI_HDMI_PHY_CNTL2 0x3a8 + +struct phy_meson8_hdmi_tx_priv { + struct regmap *hhi; + struct clk *tmds_clk; +}; + +static int phy_meson8_hdmi_tx_init(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + + return clk_prepare_enable(priv->tmds_clk); +} + +static int phy_meson8_hdmi_tx_exit(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + + clk_disable_unprepare(priv->tmds_clk); + + return 0; +} + +static int phy_meson8_hdmi_tx_power_on(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + unsigned int i; + u16 hdmi_ctl0; + + if (clk_get_rate(priv->tmds_clk) >= 2970UL * 1000 * 1000) + hdmi_ctl0 = 0x1e8b; + else + hdmi_ctl0 = 0x4d0b; + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL0, + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL1, 0x08c3) | + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL0, hdmi_ctl0)); + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, 0x00000000); + + /* Reset three times, just like the vendor driver does */ + for (i = 0; i < 3; i++) { + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, + HHI_HDMI_PHY_CNTL1_CLOCK_ENABLE | + HHI_HDMI_PHY_CNTL1_SOFT_RESET); + usleep_range(1000, 2000); + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, + HHI_HDMI_PHY_CNTL1_CLOCK_ENABLE); + usleep_range(1000, 2000); + } + + return 0; +} + +static int phy_meson8_hdmi_tx_power_off(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL0, + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL1, 0x0841) | + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL0, 0x8d00)); + + return 0; +} + +static const struct phy_ops phy_meson8_hdmi_tx_ops = { + .init = phy_meson8_hdmi_tx_init, + .exit = phy_meson8_hdmi_tx_exit, + .power_on = phy_meson8_hdmi_tx_power_on, + .power_off = phy_meson8_hdmi_tx_power_off, + .owner = THIS_MODULE, +}; + +static int phy_meson8_hdmi_tx_probe(struct platform_device *pdev) +{ + struct device_node *np = pdev->dev.of_node; + struct phy_meson8_hdmi_tx_priv *priv; + struct phy_provider *phy_provider; + struct phy *phy; + + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->hhi = syscon_node_to_regmap(np->parent); + if (IS_ERR(priv->hhi)) + return PTR_ERR(priv->hhi); + + priv->tmds_clk = devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(priv->tmds_clk)) + return PTR_ERR(priv->tmds_clk); + + phy = devm_phy_create(&pdev->dev, np, &phy_meson8_hdmi_tx_ops); + if (IS_ERR(phy)) + return PTR_ERR(phy); + + phy_set_drvdata(phy, priv); + + phy_provider = devm_of_phy_provider_register(&pdev->dev, + of_phy_simple_xlate); + + return PTR_ERR_OR_ZERO(phy_provider); +} + +static const struct of_device_id phy_meson8_hdmi_tx_of_match[] = { + { .compatible = "amlogic,meson8-hdmi-tx-phy" }, + { .compatible = "amlogic,meson8b-hdmi-tx-phy" }, + { .compatible = "amlogic,meson8m2-hdmi-tx-phy" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, phy_meson8_hdmi_tx_of_match); + +static struct platform_driver phy_meson8_hdmi_tx_driver = { + .probe = phy_meson8_hdmi_tx_probe, + .driver = { + .name = "phy-meson8-hdmi-tx", + .of_match_table = phy_meson8_hdmi_tx_of_match, + }, +}; +module_platform_driver(phy_meson8_hdmi_tx_driver); + +MODULE_AUTHOR("Martin Blumenstingl <martin.blumenstingl@googlemail.com>"); +MODULE_DESCRIPTION("Meson8, Meson8b and Meson8m2 HDMI TX PHY driver"); +MODULE_LICENSE("GPL v2"); -- 2.31.1 ^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-04 19:03 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-04 19:03 UTC (permalink / raw) To: robh+dt, linux-phy, devicetree, linux-amlogic Cc: kishon, vkoul, linux-arm-kernel, linux-kernel, Martin Blumenstingl Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register region. Unfortunately only few register bits are documented. For HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor kernel. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/phy/amlogic/Kconfig | 11 ++ drivers/phy/amlogic/Makefile | 1 + drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ 3 files changed, 162 insertions(+) create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig index db5d0cd757e3..e6c3a2a8b769 100644 --- a/drivers/phy/amlogic/Kconfig +++ b/drivers/phy/amlogic/Kconfig @@ -2,6 +2,17 @@ # # Phy drivers for Amlogic platforms # +config PHY_MESON8_HDMI_TX + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" + default ARCH_MESON + depends on (ARCH_MESON && ARM) || COMPILE_TEST + depends on OF + select MFD_SYSCON + help + Enable this to support the HDMI TX PHYs found in Meson8, + Meson8b and Meson8m2 SoCs. + If unsure, say N. + config PHY_MESON8B_USB2 tristate "Meson8, Meson8b, Meson8m2 and GXBB USB2 PHY driver" default ARCH_MESON diff --git a/drivers/phy/amlogic/Makefile b/drivers/phy/amlogic/Makefile index 8fa07fbd0d92..c0886c850bb0 100644 --- a/drivers/phy/amlogic/Makefile +++ b/drivers/phy/amlogic/Makefile @@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_PHY_MESON8_HDMI_TX) += phy-meson8-hdmi-tx.o obj-$(CONFIG_PHY_MESON8B_USB2) += phy-meson8b-usb2.o obj-$(CONFIG_PHY_MESON_GXL_USB2) += phy-meson-gxl-usb2.o obj-$(CONFIG_PHY_MESON_G12A_USB2) += phy-meson-g12a-usb2.o diff --git a/drivers/phy/amlogic/phy-meson8-hdmi-tx.c b/drivers/phy/amlogic/phy-meson8-hdmi-tx.c new file mode 100644 index 000000000000..8f13960a4492 --- /dev/null +++ b/drivers/phy/amlogic/phy-meson8-hdmi-tx.c @@ -0,0 +1,150 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. + * + * Copyright (C) 2020 Martin Blumenstingl <martin.blumenstingl@googlemail.com> + */ + +#include <linux/bitfield.h> +#include <linux/bits.h> +#include <linux/clk.h> +#include <linux/mfd/syscon.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/phy/phy.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> + +#define HHI_HDMI_PHY_CNTL0 0x3a0 + #define HHI_HDMI_PHY_CNTL0_HDMI_CTL1 GENMASK(31, 16) + #define HHI_HDMI_PHY_CNTL0_HDMI_CTL0 GENMASK(15, 0) + +#define HHI_HDMI_PHY_CNTL1 0x3a4 + #define HHI_HDMI_PHY_CNTL1_CLOCK_ENABLE BIT(1) + #define HHI_HDMI_PHY_CNTL1_SOFT_RESET BIT(0) + +#define HHI_HDMI_PHY_CNTL2 0x3a8 + +struct phy_meson8_hdmi_tx_priv { + struct regmap *hhi; + struct clk *tmds_clk; +}; + +static int phy_meson8_hdmi_tx_init(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + + return clk_prepare_enable(priv->tmds_clk); +} + +static int phy_meson8_hdmi_tx_exit(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + + clk_disable_unprepare(priv->tmds_clk); + + return 0; +} + +static int phy_meson8_hdmi_tx_power_on(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + unsigned int i; + u16 hdmi_ctl0; + + if (clk_get_rate(priv->tmds_clk) >= 2970UL * 1000 * 1000) + hdmi_ctl0 = 0x1e8b; + else + hdmi_ctl0 = 0x4d0b; + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL0, + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL1, 0x08c3) | + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL0, hdmi_ctl0)); + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, 0x00000000); + + /* Reset three times, just like the vendor driver does */ + for (i = 0; i < 3; i++) { + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, + HHI_HDMI_PHY_CNTL1_CLOCK_ENABLE | + HHI_HDMI_PHY_CNTL1_SOFT_RESET); + usleep_range(1000, 2000); + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, + HHI_HDMI_PHY_CNTL1_CLOCK_ENABLE); + usleep_range(1000, 2000); + } + + return 0; +} + +static int phy_meson8_hdmi_tx_power_off(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL0, + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL1, 0x0841) | + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL0, 0x8d00)); + + return 0; +} + +static const struct phy_ops phy_meson8_hdmi_tx_ops = { + .init = phy_meson8_hdmi_tx_init, + .exit = phy_meson8_hdmi_tx_exit, + .power_on = phy_meson8_hdmi_tx_power_on, + .power_off = phy_meson8_hdmi_tx_power_off, + .owner = THIS_MODULE, +}; + +static int phy_meson8_hdmi_tx_probe(struct platform_device *pdev) +{ + struct device_node *np = pdev->dev.of_node; + struct phy_meson8_hdmi_tx_priv *priv; + struct phy_provider *phy_provider; + struct phy *phy; + + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->hhi = syscon_node_to_regmap(np->parent); + if (IS_ERR(priv->hhi)) + return PTR_ERR(priv->hhi); + + priv->tmds_clk = devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(priv->tmds_clk)) + return PTR_ERR(priv->tmds_clk); + + phy = devm_phy_create(&pdev->dev, np, &phy_meson8_hdmi_tx_ops); + if (IS_ERR(phy)) + return PTR_ERR(phy); + + phy_set_drvdata(phy, priv); + + phy_provider = devm_of_phy_provider_register(&pdev->dev, + of_phy_simple_xlate); + + return PTR_ERR_OR_ZERO(phy_provider); +} + +static const struct of_device_id phy_meson8_hdmi_tx_of_match[] = { + { .compatible = "amlogic,meson8-hdmi-tx-phy" }, + { .compatible = "amlogic,meson8b-hdmi-tx-phy" }, + { .compatible = "amlogic,meson8m2-hdmi-tx-phy" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, phy_meson8_hdmi_tx_of_match); + +static struct platform_driver phy_meson8_hdmi_tx_driver = { + .probe = phy_meson8_hdmi_tx_probe, + .driver = { + .name = "phy-meson8-hdmi-tx", + .of_match_table = phy_meson8_hdmi_tx_of_match, + }, +}; +module_platform_driver(phy_meson8_hdmi_tx_driver); + +MODULE_AUTHOR("Martin Blumenstingl <martin.blumenstingl@googlemail.com>"); +MODULE_DESCRIPTION("Meson8, Meson8b and Meson8m2 HDMI TX PHY driver"); +MODULE_LICENSE("GPL v2"); -- 2.31.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-04 19:03 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-04 19:03 UTC (permalink / raw) To: robh+dt, linux-phy, devicetree, linux-amlogic Cc: kishon, vkoul, linux-arm-kernel, linux-kernel, Martin Blumenstingl Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register region. Unfortunately only few register bits are documented. For HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor kernel. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/phy/amlogic/Kconfig | 11 ++ drivers/phy/amlogic/Makefile | 1 + drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ 3 files changed, 162 insertions(+) create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig index db5d0cd757e3..e6c3a2a8b769 100644 --- a/drivers/phy/amlogic/Kconfig +++ b/drivers/phy/amlogic/Kconfig @@ -2,6 +2,17 @@ # # Phy drivers for Amlogic platforms # +config PHY_MESON8_HDMI_TX + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" + default ARCH_MESON + depends on (ARCH_MESON && ARM) || COMPILE_TEST + depends on OF + select MFD_SYSCON + help + Enable this to support the HDMI TX PHYs found in Meson8, + Meson8b and Meson8m2 SoCs. + If unsure, say N. + config PHY_MESON8B_USB2 tristate "Meson8, Meson8b, Meson8m2 and GXBB USB2 PHY driver" default ARCH_MESON diff --git a/drivers/phy/amlogic/Makefile b/drivers/phy/amlogic/Makefile index 8fa07fbd0d92..c0886c850bb0 100644 --- a/drivers/phy/amlogic/Makefile +++ b/drivers/phy/amlogic/Makefile @@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_PHY_MESON8_HDMI_TX) += phy-meson8-hdmi-tx.o obj-$(CONFIG_PHY_MESON8B_USB2) += phy-meson8b-usb2.o obj-$(CONFIG_PHY_MESON_GXL_USB2) += phy-meson-gxl-usb2.o obj-$(CONFIG_PHY_MESON_G12A_USB2) += phy-meson-g12a-usb2.o diff --git a/drivers/phy/amlogic/phy-meson8-hdmi-tx.c b/drivers/phy/amlogic/phy-meson8-hdmi-tx.c new file mode 100644 index 000000000000..8f13960a4492 --- /dev/null +++ b/drivers/phy/amlogic/phy-meson8-hdmi-tx.c @@ -0,0 +1,150 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. + * + * Copyright (C) 2020 Martin Blumenstingl <martin.blumenstingl@googlemail.com> + */ + +#include <linux/bitfield.h> +#include <linux/bits.h> +#include <linux/clk.h> +#include <linux/mfd/syscon.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/phy/phy.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> + +#define HHI_HDMI_PHY_CNTL0 0x3a0 + #define HHI_HDMI_PHY_CNTL0_HDMI_CTL1 GENMASK(31, 16) + #define HHI_HDMI_PHY_CNTL0_HDMI_CTL0 GENMASK(15, 0) + +#define HHI_HDMI_PHY_CNTL1 0x3a4 + #define HHI_HDMI_PHY_CNTL1_CLOCK_ENABLE BIT(1) + #define HHI_HDMI_PHY_CNTL1_SOFT_RESET BIT(0) + +#define HHI_HDMI_PHY_CNTL2 0x3a8 + +struct phy_meson8_hdmi_tx_priv { + struct regmap *hhi; + struct clk *tmds_clk; +}; + +static int phy_meson8_hdmi_tx_init(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + + return clk_prepare_enable(priv->tmds_clk); +} + +static int phy_meson8_hdmi_tx_exit(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + + clk_disable_unprepare(priv->tmds_clk); + + return 0; +} + +static int phy_meson8_hdmi_tx_power_on(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + unsigned int i; + u16 hdmi_ctl0; + + if (clk_get_rate(priv->tmds_clk) >= 2970UL * 1000 * 1000) + hdmi_ctl0 = 0x1e8b; + else + hdmi_ctl0 = 0x4d0b; + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL0, + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL1, 0x08c3) | + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL0, hdmi_ctl0)); + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, 0x00000000); + + /* Reset three times, just like the vendor driver does */ + for (i = 0; i < 3; i++) { + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, + HHI_HDMI_PHY_CNTL1_CLOCK_ENABLE | + HHI_HDMI_PHY_CNTL1_SOFT_RESET); + usleep_range(1000, 2000); + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, + HHI_HDMI_PHY_CNTL1_CLOCK_ENABLE); + usleep_range(1000, 2000); + } + + return 0; +} + +static int phy_meson8_hdmi_tx_power_off(struct phy *phy) +{ + struct phy_meson8_hdmi_tx_priv *priv = phy_get_drvdata(phy); + + regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL0, + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL1, 0x0841) | + FIELD_PREP(HHI_HDMI_PHY_CNTL0_HDMI_CTL0, 0x8d00)); + + return 0; +} + +static const struct phy_ops phy_meson8_hdmi_tx_ops = { + .init = phy_meson8_hdmi_tx_init, + .exit = phy_meson8_hdmi_tx_exit, + .power_on = phy_meson8_hdmi_tx_power_on, + .power_off = phy_meson8_hdmi_tx_power_off, + .owner = THIS_MODULE, +}; + +static int phy_meson8_hdmi_tx_probe(struct platform_device *pdev) +{ + struct device_node *np = pdev->dev.of_node; + struct phy_meson8_hdmi_tx_priv *priv; + struct phy_provider *phy_provider; + struct phy *phy; + + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->hhi = syscon_node_to_regmap(np->parent); + if (IS_ERR(priv->hhi)) + return PTR_ERR(priv->hhi); + + priv->tmds_clk = devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(priv->tmds_clk)) + return PTR_ERR(priv->tmds_clk); + + phy = devm_phy_create(&pdev->dev, np, &phy_meson8_hdmi_tx_ops); + if (IS_ERR(phy)) + return PTR_ERR(phy); + + phy_set_drvdata(phy, priv); + + phy_provider = devm_of_phy_provider_register(&pdev->dev, + of_phy_simple_xlate); + + return PTR_ERR_OR_ZERO(phy_provider); +} + +static const struct of_device_id phy_meson8_hdmi_tx_of_match[] = { + { .compatible = "amlogic,meson8-hdmi-tx-phy" }, + { .compatible = "amlogic,meson8b-hdmi-tx-phy" }, + { .compatible = "amlogic,meson8m2-hdmi-tx-phy" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, phy_meson8_hdmi_tx_of_match); + +static struct platform_driver phy_meson8_hdmi_tx_driver = { + .probe = phy_meson8_hdmi_tx_probe, + .driver = { + .name = "phy-meson8-hdmi-tx", + .of_match_table = phy_meson8_hdmi_tx_of_match, + }, +}; +module_platform_driver(phy_meson8_hdmi_tx_driver); + +MODULE_AUTHOR("Martin Blumenstingl <martin.blumenstingl@googlemail.com>"); +MODULE_DESCRIPTION("Meson8, Meson8b and Meson8m2 HDMI TX PHY driver"); +MODULE_LICENSE("GPL v2"); -- 2.31.1 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 2021-06-04 19:03 ` Martin Blumenstingl (?) (?) @ 2021-06-21 6:18 ` Vinod Koul -1 siblings, 0 replies; 28+ messages in thread From: Vinod Koul @ 2021-06-21 6:18 UTC (permalink / raw) To: Martin Blumenstingl Cc: robh+dt, linux-phy, devicetree, linux-amlogic, kishon, linux-arm-kernel, linux-kernel On 04-06-21, 21:03, Martin Blumenstingl wrote: > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > region. Unfortunately only few register bits are documented. For > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > kernel. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > drivers/phy/amlogic/Kconfig | 11 ++ > drivers/phy/amlogic/Makefile | 1 + > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > 3 files changed, 162 insertions(+) > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > index db5d0cd757e3..e6c3a2a8b769 100644 > --- a/drivers/phy/amlogic/Kconfig > +++ b/drivers/phy/amlogic/Kconfig > @@ -2,6 +2,17 @@ > # > # Phy drivers for Amlogic platforms > # > +config PHY_MESON8_HDMI_TX > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > + default ARCH_MESON > + depends on (ARCH_MESON && ARM) || COMPILE_TEST depends on ARM seems redundant.. > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > + * > + * Copyright (C) 2020 Martin Blumenstingl <martin.blumenstingl@googlemail.com> 2021.. -- ~Vinod _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-21 6:18 ` Vinod Koul 0 siblings, 0 replies; 28+ messages in thread From: Vinod Koul @ 2021-06-21 6:18 UTC (permalink / raw) To: Martin Blumenstingl Cc: robh+dt, linux-phy, devicetree, linux-amlogic, kishon, linux-arm-kernel, linux-kernel On 04-06-21, 21:03, Martin Blumenstingl wrote: > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > region. Unfortunately only few register bits are documented. For > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > kernel. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > drivers/phy/amlogic/Kconfig | 11 ++ > drivers/phy/amlogic/Makefile | 1 + > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > 3 files changed, 162 insertions(+) > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > index db5d0cd757e3..e6c3a2a8b769 100644 > --- a/drivers/phy/amlogic/Kconfig > +++ b/drivers/phy/amlogic/Kconfig > @@ -2,6 +2,17 @@ > # > # Phy drivers for Amlogic platforms > # > +config PHY_MESON8_HDMI_TX > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > + default ARCH_MESON > + depends on (ARCH_MESON && ARM) || COMPILE_TEST depends on ARM seems redundant.. > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > + * > + * Copyright (C) 2020 Martin Blumenstingl <martin.blumenstingl@googlemail.com> 2021.. -- ~Vinod ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-21 6:18 ` Vinod Koul 0 siblings, 0 replies; 28+ messages in thread From: Vinod Koul @ 2021-06-21 6:18 UTC (permalink / raw) To: Martin Blumenstingl Cc: robh+dt, linux-phy, devicetree, linux-amlogic, kishon, linux-arm-kernel, linux-kernel On 04-06-21, 21:03, Martin Blumenstingl wrote: > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > region. Unfortunately only few register bits are documented. For > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > kernel. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > drivers/phy/amlogic/Kconfig | 11 ++ > drivers/phy/amlogic/Makefile | 1 + > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > 3 files changed, 162 insertions(+) > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > index db5d0cd757e3..e6c3a2a8b769 100644 > --- a/drivers/phy/amlogic/Kconfig > +++ b/drivers/phy/amlogic/Kconfig > @@ -2,6 +2,17 @@ > # > # Phy drivers for Amlogic platforms > # > +config PHY_MESON8_HDMI_TX > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > + default ARCH_MESON > + depends on (ARCH_MESON && ARM) || COMPILE_TEST depends on ARM seems redundant.. > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > + * > + * Copyright (C) 2020 Martin Blumenstingl <martin.blumenstingl@googlemail.com> 2021.. -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-21 6:18 ` Vinod Koul 0 siblings, 0 replies; 28+ messages in thread From: Vinod Koul @ 2021-06-21 6:18 UTC (permalink / raw) To: Martin Blumenstingl Cc: robh+dt, linux-phy, devicetree, linux-amlogic, kishon, linux-arm-kernel, linux-kernel On 04-06-21, 21:03, Martin Blumenstingl wrote: > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > region. Unfortunately only few register bits are documented. For > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > kernel. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > drivers/phy/amlogic/Kconfig | 11 ++ > drivers/phy/amlogic/Makefile | 1 + > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > 3 files changed, 162 insertions(+) > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > index db5d0cd757e3..e6c3a2a8b769 100644 > --- a/drivers/phy/amlogic/Kconfig > +++ b/drivers/phy/amlogic/Kconfig > @@ -2,6 +2,17 @@ > # > # Phy drivers for Amlogic platforms > # > +config PHY_MESON8_HDMI_TX > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > + default ARCH_MESON > + depends on (ARCH_MESON && ARM) || COMPILE_TEST depends on ARM seems redundant.. > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > + * > + * Copyright (C) 2020 Martin Blumenstingl <martin.blumenstingl@googlemail.com> 2021.. -- ~Vinod -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 2021-06-21 6:18 ` Vinod Koul (?) (?) @ 2021-06-22 19:57 ` Martin Blumenstingl -1 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-22 19:57 UTC (permalink / raw) To: Vinod Koul Cc: robh+dt, linux-phy, devicetree, linux-amlogic, kishon, linux-arm-kernel, linux-kernel Hi Vinod, thanks for taking the time to review this! On Mon, Jun 21, 2021 at 8:18 AM Vinod Koul <vkoul@kernel.org> wrote: > > On 04-06-21, 21:03, Martin Blumenstingl wrote: > > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > > region. Unfortunately only few register bits are documented. For > > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > > kernel. > > > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > --- > > drivers/phy/amlogic/Kconfig | 11 ++ > > drivers/phy/amlogic/Makefile | 1 + > > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > > 3 files changed, 162 insertions(+) > > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > > index db5d0cd757e3..e6c3a2a8b769 100644 > > --- a/drivers/phy/amlogic/Kconfig > > +++ b/drivers/phy/amlogic/Kconfig > > @@ -2,6 +2,17 @@ > > # > > # Phy drivers for Amlogic platforms > > # > > +config PHY_MESON8_HDMI_TX > > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > > + default ARCH_MESON > > + depends on (ARCH_MESON && ARM) || COMPILE_TEST > > depends on ARM seems redundant.. config ARCH_MESON exists in arch/arm as well as arch/arm64 my idea was to hide it from the 64-bit SoCs since it's not used there While reading your comment I spotted something for myself: I think "default ARCH_MESON" should not be there. > > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > > + * > > + * Copyright (C) 2020 Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > 2021.. good catch, I'll fix this in v2 Best regards, Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-22 19:57 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-22 19:57 UTC (permalink / raw) To: Vinod Koul Cc: robh+dt, linux-phy, devicetree, linux-amlogic, kishon, linux-arm-kernel, linux-kernel Hi Vinod, thanks for taking the time to review this! On Mon, Jun 21, 2021 at 8:18 AM Vinod Koul <vkoul@kernel.org> wrote: > > On 04-06-21, 21:03, Martin Blumenstingl wrote: > > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > > region. Unfortunately only few register bits are documented. For > > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > > kernel. > > > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > --- > > drivers/phy/amlogic/Kconfig | 11 ++ > > drivers/phy/amlogic/Makefile | 1 + > > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > > 3 files changed, 162 insertions(+) > > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > > index db5d0cd757e3..e6c3a2a8b769 100644 > > --- a/drivers/phy/amlogic/Kconfig > > +++ b/drivers/phy/amlogic/Kconfig > > @@ -2,6 +2,17 @@ > > # > > # Phy drivers for Amlogic platforms > > # > > +config PHY_MESON8_HDMI_TX > > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > > + default ARCH_MESON > > + depends on (ARCH_MESON && ARM) || COMPILE_TEST > > depends on ARM seems redundant.. config ARCH_MESON exists in arch/arm as well as arch/arm64 my idea was to hide it from the 64-bit SoCs since it's not used there While reading your comment I spotted something for myself: I think "default ARCH_MESON" should not be there. > > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > > + * > > + * Copyright (C) 2020 Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > 2021.. good catch, I'll fix this in v2 Best regards, Martin ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-22 19:57 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-22 19:57 UTC (permalink / raw) To: Vinod Koul Cc: robh+dt, linux-phy, devicetree, linux-amlogic, kishon, linux-arm-kernel, linux-kernel Hi Vinod, thanks for taking the time to review this! On Mon, Jun 21, 2021 at 8:18 AM Vinod Koul <vkoul@kernel.org> wrote: > > On 04-06-21, 21:03, Martin Blumenstingl wrote: > > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > > region. Unfortunately only few register bits are documented. For > > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > > kernel. > > > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > --- > > drivers/phy/amlogic/Kconfig | 11 ++ > > drivers/phy/amlogic/Makefile | 1 + > > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > > 3 files changed, 162 insertions(+) > > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > > index db5d0cd757e3..e6c3a2a8b769 100644 > > --- a/drivers/phy/amlogic/Kconfig > > +++ b/drivers/phy/amlogic/Kconfig > > @@ -2,6 +2,17 @@ > > # > > # Phy drivers for Amlogic platforms > > # > > +config PHY_MESON8_HDMI_TX > > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > > + default ARCH_MESON > > + depends on (ARCH_MESON && ARM) || COMPILE_TEST > > depends on ARM seems redundant.. config ARCH_MESON exists in arch/arm as well as arch/arm64 my idea was to hide it from the 64-bit SoCs since it's not used there While reading your comment I spotted something for myself: I think "default ARCH_MESON" should not be there. > > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > > + * > > + * Copyright (C) 2020 Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > 2021.. good catch, I'll fix this in v2 Best regards, Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 @ 2021-06-22 19:57 ` Martin Blumenstingl 0 siblings, 0 replies; 28+ messages in thread From: Martin Blumenstingl @ 2021-06-22 19:57 UTC (permalink / raw) To: Vinod Koul Cc: robh+dt, linux-phy, devicetree, linux-amlogic, kishon, linux-arm-kernel, linux-kernel Hi Vinod, thanks for taking the time to review this! On Mon, Jun 21, 2021 at 8:18 AM Vinod Koul <vkoul@kernel.org> wrote: > > On 04-06-21, 21:03, Martin Blumenstingl wrote: > > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > > region. Unfortunately only few register bits are documented. For > > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > > kernel. > > > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > --- > > drivers/phy/amlogic/Kconfig | 11 ++ > > drivers/phy/amlogic/Makefile | 1 + > > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > > 3 files changed, 162 insertions(+) > > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > > index db5d0cd757e3..e6c3a2a8b769 100644 > > --- a/drivers/phy/amlogic/Kconfig > > +++ b/drivers/phy/amlogic/Kconfig > > @@ -2,6 +2,17 @@ > > # > > # Phy drivers for Amlogic platforms > > # > > +config PHY_MESON8_HDMI_TX > > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > > + default ARCH_MESON > > + depends on (ARCH_MESON && ARM) || COMPILE_TEST > > depends on ARM seems redundant.. config ARCH_MESON exists in arch/arm as well as arch/arm64 my idea was to hide it from the 64-bit SoCs since it's not used there While reading your comment I spotted something for myself: I think "default ARCH_MESON" should not be there. > > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > > + * > > + * Copyright (C) 2020 Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > 2021.. good catch, I'll fix this in v2 Best regards, Martin -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2021-06-22 20:00 UTC | newest] Thread overview: 28+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-06-04 19:03 [PATCH 0/2] phy: Add support for the HDMI TX PHY on Meson8/8b/8m2 Martin Blumenstingl 2021-06-04 19:03 ` Martin Blumenstingl 2021-06-04 19:03 ` Martin Blumenstingl 2021-06-04 19:03 ` Martin Blumenstingl 2021-06-04 19:03 ` [PATCH 1/2] dt-bindings: phy: Add the Amlogic Meson8 HDMI TX PHY bindings Martin Blumenstingl 2021-06-04 19:03 ` Martin Blumenstingl 2021-06-04 19:03 ` Martin Blumenstingl 2021-06-04 19:03 ` Martin Blumenstingl 2021-06-16 23:31 ` Rob Herring 2021-06-16 23:31 ` Rob Herring 2021-06-16 23:31 ` Rob Herring 2021-06-16 23:31 ` Rob Herring 2021-06-17 22:30 ` Martin Blumenstingl 2021-06-17 22:30 ` Martin Blumenstingl 2021-06-17 22:30 ` Martin Blumenstingl 2021-06-17 22:30 ` Martin Blumenstingl 2021-06-04 19:03 ` [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 Martin Blumenstingl 2021-06-04 19:03 ` Martin Blumenstingl 2021-06-04 19:03 ` Martin Blumenstingl 2021-06-04 19:03 ` Martin Blumenstingl 2021-06-21 6:18 ` Vinod Koul 2021-06-21 6:18 ` Vinod Koul 2021-06-21 6:18 ` Vinod Koul 2021-06-21 6:18 ` Vinod Koul 2021-06-22 19:57 ` Martin Blumenstingl 2021-06-22 19:57 ` Martin Blumenstingl 2021-06-22 19:57 ` Martin Blumenstingl 2021-06-22 19:57 ` Martin Blumenstingl
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.