All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Robin Hsu <robinh3123@gmail.com>
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] sload.f2fs: Reword "IMMUTABLE" in strings/comments
Date: Tue, 22 Jun 2021 15:33:58 +0200	[thread overview]
Message-ID: <20210622133357.GA1003@bug> (raw)
In-Reply-To: <20210611073111.947552-1-robinh3123@gmail.com>

Hi!

> Since the IMMUTABLE flag for compression is now changed
> to F2FS_COMPRESS_RELEASED, some 'IMMUTABLE' words should be changed too:
> 	1. sload help page
> 	2. inline comments
> 
> Signed-off-by: Robin Hsu <robinhsu@google.com>

> @@ -650,7 +651,7 @@ void f2fs_parse_options(int argc, char *argv[])
>  				}
>  				c.compress.min_blocks = val;
>  				break;
> -			case 'r': /* compress file to set IMMUTABLE */
> +			case 'r': /* for setting F2FS_COMOPRESS_RELEASE */

Typo.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Robin Hsu <robinh3123@gmail.com>
Cc: linux-f2fs-devel@lists.sourceforge.net, jaegeuk@kernel.org,
	chao@kernel.org, linux-kernel@vger.kernel.org,
	Robin Hsu <robinhsu@google.com>
Subject: Re: [PATCH] sload.f2fs: Reword "IMMUTABLE" in strings/comments
Date: Tue, 22 Jun 2021 15:33:58 +0200	[thread overview]
Message-ID: <20210622133357.GA1003@bug> (raw)
In-Reply-To: <20210611073111.947552-1-robinh3123@gmail.com>

Hi!

> Since the IMMUTABLE flag for compression is now changed
> to F2FS_COMPRESS_RELEASED, some 'IMMUTABLE' words should be changed too:
> 	1. sload help page
> 	2. inline comments
> 
> Signed-off-by: Robin Hsu <robinhsu@google.com>

> @@ -650,7 +651,7 @@ void f2fs_parse_options(int argc, char *argv[])
>  				}
>  				c.compress.min_blocks = val;
>  				break;
> -			case 'r': /* compress file to set IMMUTABLE */
> +			case 'r': /* for setting F2FS_COMOPRESS_RELEASE */

Typo.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2021-06-22 13:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11  7:31 [f2fs-dev] [PATCH] sload.f2fs: Reword "IMMUTABLE" in strings/comments Robin Hsu
2021-06-11  7:31 ` Robin Hsu
2021-06-22 13:33 ` Pavel Machek [this message]
2021-06-22 13:33   ` Pavel Machek
2021-06-22 15:10   ` [f2fs-dev] " Jaegeuk Kim
2021-06-22 15:10     ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210622133357.GA1003@bug \
    --to=pavel@ucw.cz \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robinh3123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.