Re: [RFC PATCH 2/6] fs: ext4: move fstrim to file_operation

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3602 bytes --]

Hi "Enrico,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on kdave/for-next]
[also build test ERROR on linux/master linus/master v5.13-rc7]
[cannot apply to ext4/dev next-20210622]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Enrico-Weigelt-metux-IT-consult/fs-generic-file-operation-for-fstrim/20210622-211217
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/2f26b6809e1541cf945da594ef5251e51ba73d3b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Enrico-Weigelt-metux-IT-consult/fs-generic-file-operation-for-fstrim/20210622-211217
        git checkout 2f26b6809e1541cf945da594ef5251e51ba73d3b
        # save the attached .config to linux build tree
        make W=1 ARCH=um SUBARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> fs/ext4/file.c:930:3: error: 'const struct file_operations' has no member named 'fitrim'; did you mean 'fstrim'?
     930 |  .fitrim  = ext4_fitrim,
         |   ^~~~~~
         |   fstrim
>> fs/ext4/file.c:930:13: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     930 |  .fitrim  = ext4_fitrim,
         |             ^~~~~~~~~~~
   fs/ext4/file.c:930:13: note: (near initialization for 'ext4_file_operations')
>> fs/ext4/file.c:930:13: error: initialization of 'void (*)(struct seq_file *, struct file *)' from incompatible pointer type 'long int (*)(struct file *, struct fstrim_range *)' [-Werror=incompatible-pointer-types]
   fs/ext4/file.c:930:13: note: (near initialization for 'ext4_file_operations.show_fdinfo')
   cc1: some warnings being treated as errors
--
   fs/ext4/ioctl.c: In function 'ext4_fitrim':
>> fs/ext4/ioctl.c:805:43: error: 'sb' undeclared (first use in this function); did you mean 's8'?
     805 |  struct request_queue *q = bdev_get_queue(sb->s_bdev);
         |                                           ^~
         |                                           s8
   fs/ext4/ioctl.c:805:43: note: each undeclared identifier is reported only once for each function it appears in


vim +930 fs/ext4/file.c

   911	
   912	const struct file_operations ext4_file_operations = {
   913		.llseek		= ext4_llseek,
   914		.read_iter	= ext4_file_read_iter,
   915		.write_iter	= ext4_file_write_iter,
   916		.iopoll		= iomap_dio_iopoll,
   917		.unlocked_ioctl = ext4_ioctl,
   918	#ifdef CONFIG_COMPAT
   919		.compat_ioctl	= ext4_compat_ioctl,
   920	#endif
   921		.mmap		= ext4_file_mmap,
   922		.mmap_supported_flags = MAP_SYNC,
   923		.open		= ext4_file_open,
   924		.release	= ext4_release_file,
   925		.fsync		= ext4_sync_file,
   926		.get_unmapped_area = thp_get_unmapped_area,
   927		.splice_read	= generic_file_splice_read,
   928		.splice_write	= iter_file_splice_write,
   929		.fallocate	= ext4_fallocate,
 > 930		.fitrim		= ext4_fitrim,
   931	};
   932	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 8645 bytes --]