Re: [RFC PATCH 6/6] fs: f2fs: move fstrim to file_operation

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5824 bytes --]

Hi "Enrico,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on kdave/for-next]
[also build test ERROR on linux/master linus/master v5.13-rc7]
[cannot apply to ext4/dev next-20210622]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Enrico-Weigelt-metux-IT-consult/fs-generic-file-operation-for-fstrim/20210622-211217
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
config: m68k-randconfig-s031-20210622 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/a244db0d686be8dbc08aba54a817438247fe1405
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Enrico-Weigelt-metux-IT-consult/fs-generic-file-operation-for-fstrim/20210622-211217
        git checkout a244db0d686be8dbc08aba54a817438247fe1405
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   fs/f2fs/file.c: In function 'f2fs_ioc_fitrim':
>> fs/f2fs/file.c:2257:35: error: 'filp' undeclared (first use in this function); did you mean 'file'?
    2257 |  struct inode *inode = file_inode(filp);
         |                                   ^~~~
         |                                   file
   fs/f2fs/file.c:2257:35: note: each undeclared identifier is reported only once for each function it appears in
   fs/f2fs/file.c: At top level:
>> fs/f2fs/file.c:4450:3: error: 'const struct file_operations' has no member named 'fitrim'; did you mean 'fstrim'?
    4450 |  .fitrim  = f2fs_ioc_fitrim,
         |   ^~~~~~
         |   fstrim
>> fs/f2fs/file.c:4450:13: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
    4450 |  .fitrim  = f2fs_ioc_fitrim,
         |             ^~~~~~~~~~~~~~~
   fs/f2fs/file.c:4450:13: note: (near initialization for 'f2fs_file_operations')
>> fs/f2fs/file.c:4450:13: error: initialization of 'ssize_t (*)(struct file *, loff_t *, struct pipe_inode_info *, size_t,  unsigned int)' {aka 'int (*)(struct file *, long long int *, struct pipe_inode_info *, unsigned int,  unsigned int)'} from incompatible pointer type 'long int (*)(struct file *, struct fstrim_range *)' [-Werror=incompatible-pointer-types]
   fs/f2fs/file.c:4450:13: note: (near initialization for 'f2fs_file_operations.splice_read')
>> fs/f2fs/file.c:4450:13: warning: initialized field overwritten [-Woverride-init]
   fs/f2fs/file.c:4450:13: note: (near initialization for 'f2fs_file_operations.splice_read')
   cc1: some warnings being treated as errors


vim +2257 fs/f2fs/file.c

1abff93d01edda Jaegeuk Kim                      2015-01-08  2254  
a244db0d686be8 Enrico Weigelt, metux IT consult 2021-06-22  2255  static long f2fs_ioc_fitrim(struct file *file, struct fstrim_range *range)
4b2fecc8465505 Jaegeuk Kim                      2014-09-20  2256  {
52656e6cf7be69 Jaegeuk Kim                      2014-09-24 @2257  	struct inode *inode = file_inode(filp);
4b2fecc8465505 Jaegeuk Kim                      2014-09-20  2258  	struct super_block *sb = inode->i_sb;
4b2fecc8465505 Jaegeuk Kim                      2014-09-20  2259  	struct request_queue *q = bdev_get_queue(sb->s_bdev);
52656e6cf7be69 Jaegeuk Kim                      2014-09-24  2260  	int ret;
4b2fecc8465505 Jaegeuk Kim                      2014-09-20  2261  
7d20c8abb2edcf Chao Yu                          2018-09-04  2262  	if (!f2fs_hw_support_discard(F2FS_SB(sb)))
4b2fecc8465505 Jaegeuk Kim                      2014-09-20  2263  		return -EOPNOTSUPP;
4b2fecc8465505 Jaegeuk Kim                      2014-09-20  2264  
7fb17fe44b70c8 Chao Yu                          2016-05-09  2265  	ret = mnt_want_write_file(filp);
7fb17fe44b70c8 Chao Yu                          2016-05-09  2266  	if (ret)
7fb17fe44b70c8 Chao Yu                          2016-05-09  2267  		return ret;
7fb17fe44b70c8 Chao Yu                          2016-05-09  2268  
a244db0d686be8 Enrico Weigelt, metux IT consult 2021-06-22  2269  	range->minlen = max((unsigned int)range->minlen,
4b2fecc8465505 Jaegeuk Kim                      2014-09-20  2270  				q->limits.discard_granularity);
a244db0d686be8 Enrico Weigelt, metux IT consult 2021-06-22  2271  	ret = f2fs_trim_fs(F2FS_SB(sb), range);
7fb17fe44b70c8 Chao Yu                          2016-05-09  2272  	mnt_drop_write_file(filp);
4b2fecc8465505 Jaegeuk Kim                      2014-09-20  2273  	if (ret < 0)
4b2fecc8465505 Jaegeuk Kim                      2014-09-20  2274  		return ret;
4b2fecc8465505 Jaegeuk Kim                      2014-09-20  2275  
d0239e1bf5204d Jaegeuk Kim                      2016-01-08  2276  	f2fs_update_time(F2FS_I_SB(inode), REQ_TIME);
4b2fecc8465505 Jaegeuk Kim                      2014-09-20  2277  	return 0;
4b2fecc8465505 Jaegeuk Kim                      2014-09-20  2278  }
52656e6cf7be69 Jaegeuk Kim                      2014-09-24  2279  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39928 bytes --]