Re: [yocto] [meta-rockchip][PATCH 1/4] centralize console settings

["Trevor Woerner" <twoerner@gmail.com>]

On Wed 2021-06-23 @ 08:10:07 PM, ydirson@free.fr wrote:
> > De: "Khem Raj" <raj.khem@gmail.com>
> > À: "Trevor Woerner" <twoerner@gmail.com>
> > Cc: "Yocto-mailing-list" <yocto@lists.yoctoproject.org>
> > Envoyé: Mercredi 23 Juin 2021 11:32:57
> > Objet: Re: [yocto] [meta-rockchip][PATCH 1/4] centralize console settings

> > > +RK_CONSOLE_BAUD = "115200"
> > > +RK_CONSOLE_DEVICE = "ttyFIQ0"
> > 
> > while I appreciate this change, it does have an effect of removing
> > the
> > users away from
> > BSP variables that core metadata layers have, e.g. SERIAL_CONSOLES is
> > a well defined
> > and documented variable and if we synthesize it then its hidden which
> > is fine if we document
> > the new variables equally well although that means every BSP will
> > invent these kind of
> > variables so if a person was doing RPI and comes to work on rockchip
> > boards he has more
> > learnings to do.

Good point, thanks for mentioning it.

> What about making this change at the poky level, then ?

I suspect it would break things in all sorts of unimaginable ways ;-)

For example, SERIAL_CONSOLES (note: plural) can contain more than one
baud+device pair so if we try to break out the baud and device then we'd need
an array (?) so we could break out multiple baud and device pairs (?), and
then that would get messy...  ugh!