From: "Yann Dirson" <ydirson@free.fr>
To: Trevor Woerner <twoerner@gmail.com>
Cc: Khem Raj <raj.khem@gmail.com>,
Yocto-mailing-list <yocto@lists.yoctoproject.org>
Subject: Re: [yocto] [meta-rockchip][PATCH 1/4] centralize console settings
Date: Wed, 23 Jun 2021 21:38:23 +0200 (CEST) [thread overview]
Message-ID: <588488616.865322321.1624477103694.JavaMail.root@zimbra39-e7> (raw)
In-Reply-To: <20210623185139.GA13329@localhost>
> De: "Trevor Woerner" <twoerner@gmail.com>
> À: ydirson@free.fr
> Cc: "Khem Raj" <raj.khem@gmail.com>, "Yocto-mailing-list" <yocto@lists.yoctoproject.org>
> Envoyé: Mercredi 23 Juin 2021 14:51:39
> Objet: Re: [yocto] [meta-rockchip][PATCH 1/4] centralize console settings
>
> On Wed 2021-06-23 @ 08:10:07 PM, ydirson@free.fr wrote:
> > > De: "Khem Raj" <raj.khem@gmail.com>
> > > À: "Trevor Woerner" <twoerner@gmail.com>
> > > Cc: "Yocto-mailing-list" <yocto@lists.yoctoproject.org>
> > > Envoyé: Mercredi 23 Juin 2021 11:32:57
> > > Objet: Re: [yocto] [meta-rockchip][PATCH 1/4] centralize console
> > > settings
>
> > > > +RK_CONSOLE_BAUD = "115200"
> > > > +RK_CONSOLE_DEVICE = "ttyFIQ0"
> > >
> > > while I appreciate this change, it does have an effect of
> > > removing
> > > the
> > > users away from
> > > BSP variables that core metadata layers have, e.g.
> > > SERIAL_CONSOLES is
> > > a well defined
> > > and documented variable and if we synthesize it then its hidden
> > > which
> > > is fine if we document
> > > the new variables equally well although that means every BSP will
> > > invent these kind of
> > > variables so if a person was doing RPI and comes to work on
> > > rockchip
> > > boards he has more
> > > learnings to do.
>
> Good point, thanks for mentioning it.
>
> > What about making this change at the poky level, then ?
>
> I suspect it would break things in all sorts of unimaginable ways ;-)
>
> For example, SERIAL_CONSOLES (note: plural) can contain more than one
> baud+device pair so if we try to break out the baud and device then
> we'd need
> an array (?) so we could break out multiple baud and device pairs
> (?), and
> then that would get messy... ugh!
Damned that makes things more complicated :)
That could push us along the following lines ?
CONSOLE_DEVICES = "/dev/ttyS2 /dev/tty1"
CONSOLE_BAUD_ttyS2 = "1500000"
CONSOLE_BAUD_tty1 = "115200"
(well, with /dev/ being what it is, CONSOLE_DEVICES = "ttyS2 tty1" could
even be decided as sufficient, removing any possibility for syntactic
ambiguities)
or maybe even this ?
CONSOLE_BAUD = <default value>
CONSOLE_BAUD[/dev/ttyS2] = <overriden value>
prev parent reply other threads:[~2021-06-23 19:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 15:24 [meta-rockchip][PATCH 1/4] centralize console settings Trevor Woerner
2021-06-23 15:24 ` [meta-rockchip][PATCH 2/4] wic console device and baud Trevor Woerner
2021-06-23 15:24 ` [meta-rockchip][PATCH 3/4] machine common include cleanup Trevor Woerner
2021-06-23 15:24 ` [meta-rockchip][PATCH 4/4] wic/wks cleanup Trevor Woerner
2021-06-23 15:32 ` [yocto] [meta-rockchip][PATCH 1/4] centralize console settings Khem Raj
2021-06-23 18:10 ` Yann Dirson
2021-06-23 18:51 ` Trevor Woerner
2021-06-23 19:38 ` Yann Dirson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=588488616.865322321.1624477103694.JavaMail.root@zimbra39-e7 \
--to=ydirson@free.fr \
--cc=raj.khem@gmail.com \
--cc=twoerner@gmail.com \
--cc=yocto@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.