From: Marek Behun <marek.behun@nic.cz>
To: Ling Pei Lee <pei.lee.ling@intel.com>
Cc: Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
davem@davemloft.net, Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
weifeng.voon@intel.com, vee.khee.wong@linux.intel.com,
vee.khee.wong@intel.com
Subject: Re: [PATCH net-next] net: phy: marvell10g: enable WoL for mv2110
Date: Wed, 23 Jun 2021 23:38:54 +0200 [thread overview]
Message-ID: <20210623233854.03ed9240@thinkpad> (raw)
In-Reply-To: <20210623130929.805559-1-pei.lee.ling@intel.com>
On Wed, 23 Jun 2021 21:09:29 +0800
Ling Pei Lee <pei.lee.ling@intel.com> wrote:
> + /* Enable the WOL interrupt */
> + ret = phy_set_bits_mmd(phydev, MDIO_MMD_VEND2,
> + MV_V2_PORT_INTR_MASK,
> + MV_V2_WOL_INTR_EN);
> +
> + if (ret < 0)
> + return ret;
Hi, in addition to what Russell said, please remove the extra newline
between function call and return value check, i.e. instead of
ret = phy_xyz(...);
if (ret)
return ret;
ret = phy_xyz(...);
if (ret)
return ret;
do
ret = phy_xyz(...);
if (ret)
return ret;
ret = phy_xyz(...);
if (ret)
return ret;
This is how this driver does this everywhere else.
Do you have a device that uses this WoL feature?
Marek
next prev parent reply other threads:[~2021-06-23 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 13:09 [PATCH net-next] net: phy: marvell10g: enable WoL for mv2110 Ling Pei Lee
2021-06-23 20:06 ` Russell King (Oracle)
2021-06-24 15:27 ` Wong Vee Khee
2021-06-23 21:38 ` Marek Behun [this message]
2021-06-24 2:56 ` Wong Vee Khee
2021-06-24 15:34 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623233854.03ed9240@thinkpad \
--to=marek.behun@nic.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pei.lee.ling@intel.com \
--cc=vee.khee.wong@intel.com \
--cc=vee.khee.wong@linux.intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.