All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: 13145886936@163.com
Cc: tony@atomide.com, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	gushengxian <gushengxian@yulong.com>
Subject: Re: [PATCH] ARM: omap2: remove unneeded variable: "errata"
Date: Thu, 24 Jun 2021 08:28:38 +0100	[thread overview]
Message-ID: <20210624072838.GA1343@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210624032751.24315-1-13145886936@163.com>

On Wed, Jun 23, 2021 at 08:27:51PM -0700, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
> 
> Remove unneeded variable: "errata".
> 
> Signed-off-by: gushengxian <gushengxian@yulong.com>

NAK.

> diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
> index dfc9b21ff19b..ba4a48e3d264 100644
> --- a/arch/arm/mach-omap2/dma.c
> +++ b/arch/arm/mach-omap2/dma.c
> @@ -79,7 +79,6 @@ static const struct omap_dma_reg reg_map[] = {
>  
>  static unsigned configure_dma_errata(void)
>  {
> -	unsigned errata = 0;
>  
>  	/*
>  	 * Errata applicable for OMAP2430ES1.0 and all omap2420
> @@ -158,7 +157,7 @@ static unsigned configure_dma_errata(void)
>  	if (cpu_is_omap34xx() && (omap_type() != OMAP2_DEVICE_TYPE_GP))
>  		SET_DMA_ERRATA(DMA_ROMCODE_BUG);
>  
> -	return errata;
> +	return 0;

It is _not_ "unneeded" and you clearly have not compiled the resulting
code from your patch.

#define SET_DMA_ERRATA(id)              (errata |= (id))

errata is used inside the SET_DMA_ERRATA() macro. Hence, building
mach-omap2/dma.c would have failed.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: 13145886936@163.com
Cc: tony@atomide.com, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	gushengxian <gushengxian@yulong.com>
Subject: Re: [PATCH] ARM: omap2: remove unneeded variable: "errata"
Date: Thu, 24 Jun 2021 08:28:38 +0100	[thread overview]
Message-ID: <20210624072838.GA1343@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210624032751.24315-1-13145886936@163.com>

On Wed, Jun 23, 2021 at 08:27:51PM -0700, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
> 
> Remove unneeded variable: "errata".
> 
> Signed-off-by: gushengxian <gushengxian@yulong.com>

NAK.

> diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
> index dfc9b21ff19b..ba4a48e3d264 100644
> --- a/arch/arm/mach-omap2/dma.c
> +++ b/arch/arm/mach-omap2/dma.c
> @@ -79,7 +79,6 @@ static const struct omap_dma_reg reg_map[] = {
>  
>  static unsigned configure_dma_errata(void)
>  {
> -	unsigned errata = 0;
>  
>  	/*
>  	 * Errata applicable for OMAP2430ES1.0 and all omap2420
> @@ -158,7 +157,7 @@ static unsigned configure_dma_errata(void)
>  	if (cpu_is_omap34xx() && (omap_type() != OMAP2_DEVICE_TYPE_GP))
>  		SET_DMA_ERRATA(DMA_ROMCODE_BUG);
>  
> -	return errata;
> +	return 0;

It is _not_ "unneeded" and you clearly have not compiled the resulting
code from your patch.

#define SET_DMA_ERRATA(id)              (errata |= (id))

errata is used inside the SET_DMA_ERRATA() macro. Hence, building
mach-omap2/dma.c would have failed.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-24  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24  3:27 [PATCH] ARM: omap2: remove unneeded variable: "errata" 13145886936
2021-06-24  3:27 ` 13145886936
2021-06-24  7:28 ` Russell King - ARM Linux admin [this message]
2021-06-24  7:28   ` Russell King - ARM Linux admin
2021-06-26  0:23 ` kernel test robot
2021-06-26  0:23   ` kernel test robot
2021-06-26  0:23   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210624072838.GA1343@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=13145886936@163.com \
    --cc=gushengxian@yulong.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.