All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, dongas86@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] of: of_reserved_mem: only call memblock_free for normal reserved memory
Date: Thu, 24 Jun 2021 13:05:58 -0600	[thread overview]
Message-ID: <20210624190558.GA1819995@robh.at.kernel.org> (raw)
In-Reply-To: <20210611131153.3731147-1-aisheng.dong@nxp.com>

On Fri, 11 Jun 2021 21:11:52 +0800, Dong Aisheng wrote:
> For nomap case, the memory block will be removed by memblock_remove()
> in early_init_dt_alloc_reserved_memory_arch(). So it's meaningless to
> call memblock_free() on error path.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  drivers/of/of_reserved_mem.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, dongas86@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] of: of_reserved_mem: only call memblock_free for normal reserved memory
Date: Thu, 24 Jun 2021 13:05:58 -0600	[thread overview]
Message-ID: <20210624190558.GA1819995@robh.at.kernel.org> (raw)
In-Reply-To: <20210611131153.3731147-1-aisheng.dong@nxp.com>

On Fri, 11 Jun 2021 21:11:52 +0800, Dong Aisheng wrote:
> For nomap case, the memory block will be removed by memblock_remove()
> in early_init_dt_alloc_reserved_memory_arch(). So it's meaningless to
> call memblock_free() on error path.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  drivers/of/of_reserved_mem.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Applied, thanks!

  parent reply	other threads:[~2021-06-24 19:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 13:11 [PATCH 1/2] of: of_reserved_mem: only call memblock_free for normal reserved memory Dong Aisheng
2021-06-11 13:11 ` Dong Aisheng
2021-06-11 13:11 ` [PATCH 2/2] of: of_reserved_mem: mark nomap memory instead of removing Dong Aisheng
2021-06-11 13:11   ` Dong Aisheng
2021-06-11 17:10   ` Rob Herring
2021-06-11 17:10     ` Rob Herring
2021-06-12 11:20     ` Aisheng Dong
2021-06-12 11:20       ` Aisheng Dong
2021-06-22  9:22     ` Quentin Perret
2021-06-22  9:22       ` Quentin Perret
2021-06-24 19:07   ` Rob Herring
2021-06-24 19:07     ` Rob Herring
2021-06-24 19:05 ` Rob Herring [this message]
2021-06-24 19:05   ` [PATCH 1/2] of: of_reserved_mem: only call memblock_free for normal reserved memory Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210624190558.GA1819995@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dongas86@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.