All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [linux-next:master 4204/13009] drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:63 amdgpu_gem_fault() warn: inconsistent indenting
Date: Fri, 25 Jun 2021 05:44:05 +0800	[thread overview]
Message-ID: <202106250558.AlDeUBca-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   2a8927f0efb6fb34b9d11dab3bd3f018e866d36d
commit: 71df0368e9b66afeb1fdb92a88be1a98cc25f310 [4204/13009] drm/amdgpu: Implement mmap as GEM object function
config: x86_64-randconfig-m001-20210622 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

New smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:63 amdgpu_gem_fault() warn: inconsistent indenting

Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:824 amdgpu_gem_op_ioctl() warn: should 'robj->tbo.page_alignment << 12' be a 64 bit type?

vim +63 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

    44	
    45	static vm_fault_t amdgpu_gem_fault(struct vm_fault *vmf)
    46	{
    47		struct ttm_buffer_object *bo = vmf->vma->vm_private_data;
    48		struct drm_device *ddev = bo->base.dev;
    49		vm_fault_t ret;
    50		int idx;
    51	
    52		ret = ttm_bo_vm_reserve(bo, vmf);
    53		if (ret)
    54			return ret;
    55	
    56		if (drm_dev_enter(ddev, &idx)) {
    57			ret = amdgpu_bo_fault_reserve_notify(bo);
    58			if (ret) {
    59				drm_dev_exit(idx);
    60				goto unlock;
    61			}
    62	
  > 63			 ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
    64							TTM_BO_VM_NUM_PREFAULT, 1);
    65	
    66			 drm_dev_exit(idx);
    67		} else {
    68			ret = ttm_bo_vm_dummy_page(vmf, vmf->vma->vm_page_prot);
    69		}
    70		if (ret == VM_FAULT_RETRY && !(vmf->flags & FAULT_FLAG_RETRY_NOWAIT))
    71			return ret;
    72	
    73	unlock:
    74		dma_resv_unlock(bo->base.resv);
    75		return ret;
    76	}
    77	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 50285 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: kbuild-all@lists.01.org,
	"Linux Memory Management List" <linux-mm@kvack.org>,
	"Christian König" <christian.koenig@amd.com>
Subject: [linux-next:master 4204/13009] drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:63 amdgpu_gem_fault() warn: inconsistent indenting
Date: Fri, 25 Jun 2021 05:44:05 +0800	[thread overview]
Message-ID: <202106250558.AlDeUBca-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   2a8927f0efb6fb34b9d11dab3bd3f018e866d36d
commit: 71df0368e9b66afeb1fdb92a88be1a98cc25f310 [4204/13009] drm/amdgpu: Implement mmap as GEM object function
config: x86_64-randconfig-m001-20210622 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

New smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:63 amdgpu_gem_fault() warn: inconsistent indenting

Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:824 amdgpu_gem_op_ioctl() warn: should 'robj->tbo.page_alignment << 12' be a 64 bit type?

vim +63 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

    44	
    45	static vm_fault_t amdgpu_gem_fault(struct vm_fault *vmf)
    46	{
    47		struct ttm_buffer_object *bo = vmf->vma->vm_private_data;
    48		struct drm_device *ddev = bo->base.dev;
    49		vm_fault_t ret;
    50		int idx;
    51	
    52		ret = ttm_bo_vm_reserve(bo, vmf);
    53		if (ret)
    54			return ret;
    55	
    56		if (drm_dev_enter(ddev, &idx)) {
    57			ret = amdgpu_bo_fault_reserve_notify(bo);
    58			if (ret) {
    59				drm_dev_exit(idx);
    60				goto unlock;
    61			}
    62	
  > 63			 ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
    64							TTM_BO_VM_NUM_PREFAULT, 1);
    65	
    66			 drm_dev_exit(idx);
    67		} else {
    68			ret = ttm_bo_vm_dummy_page(vmf, vmf->vma->vm_page_prot);
    69		}
    70		if (ret == VM_FAULT_RETRY && !(vmf->flags & FAULT_FLAG_RETRY_NOWAIT))
    71			return ret;
    72	
    73	unlock:
    74		dma_resv_unlock(bo->base.resv);
    75		return ret;
    76	}
    77	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50285 bytes --]

             reply	other threads:[~2021-06-24 21:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 21:44 kernel test robot [this message]
2021-06-24 21:44 ` [linux-next:master 4204/13009] drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:63 amdgpu_gem_fault() warn: inconsistent indenting kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202106250558.AlDeUBca-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.