All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Andrew Lunn <andrew@lunn.ch>,
	thomas.petazzoni@bootlin.com, herve.codina@bootlin.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: imx6qdl-sr-som: Increase the PHY reset duration to 10ms
Date: Fri, 25 Jun 2021 13:29:17 +0100	[thread overview]
Message-ID: <20210625122917.GW22278@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210625121353.3698240-1-maxime.chevallier@bootlin.com>

On Fri, Jun 25, 2021 at 02:13:53PM +0200, Maxime Chevallier wrote:
> The AR803x PHY used on this modules seems to require the reset line to
> be asserted for around 10ms in order to avoid rare cases where the PHY
> gets stuck in an incoherent state that prevents it to function
> correctly.
> 
> The previous value of 2ms was found to be problematic on some setups,
> causing intermittent issues where the PHY would be unresponsive
> every once in a while on some sytems, with a low occurrence (it typically
> took around 30 consecutive reboots to encounter the issue).
> 
> Bumping the delay to the 10ms makes the issue dissapear, with more than
> 2500 consecutive reboots performed without the issue showing-up.
> 
> Fixes: 208d7baf8085 ("ARM: imx: initial SolidRun HummingBoard support")
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> Tested-by: Hervé Codina <herve.codina@bootlin.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Andrew Lunn <andrew@lunn.ch>,
	thomas.petazzoni@bootlin.com, herve.codina@bootlin.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: imx6qdl-sr-som: Increase the PHY reset duration to 10ms
Date: Fri, 25 Jun 2021 13:29:17 +0100	[thread overview]
Message-ID: <20210625122917.GW22278@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210625121353.3698240-1-maxime.chevallier@bootlin.com>

On Fri, Jun 25, 2021 at 02:13:53PM +0200, Maxime Chevallier wrote:
> The AR803x PHY used on this modules seems to require the reset line to
> be asserted for around 10ms in order to avoid rare cases where the PHY
> gets stuck in an incoherent state that prevents it to function
> correctly.
> 
> The previous value of 2ms was found to be problematic on some setups,
> causing intermittent issues where the PHY would be unresponsive
> every once in a while on some sytems, with a low occurrence (it typically
> took around 30 consecutive reboots to encounter the issue).
> 
> Bumping the delay to the 10ms makes the issue dissapear, with more than
> 2500 consecutive reboots performed without the issue showing-up.
> 
> Fixes: 208d7baf8085 ("ARM: imx: initial SolidRun HummingBoard support")
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> Tested-by: Hervé Codina <herve.codina@bootlin.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2021-06-25 12:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 12:13 [PATCH v2] ARM: dts: imx6qdl-sr-som: Increase the PHY reset duration to 10ms Maxime Chevallier
2021-06-25 12:13 ` Maxime Chevallier
2021-06-25 12:29 ` Russell King (Oracle) [this message]
2021-06-25 12:29   ` Russell King (Oracle)
2021-07-14  8:26 ` Shawn Guo
2021-07-14  8:26   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210625122917.GW22278@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=herve.codina@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.