From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jinchao Wang <wjc@cdjrlc.com>
Cc: guillaume.tucker@collabora.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: mm: Prefer unsigned int to bare use of unsigned
Date: Sat, 26 Jun 2021 10:21:13 +0100 [thread overview]
Message-ID: <20210626092113.GZ22278@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210626065833.6653-1-wjc@cdjrlc.com>
On Sat, Jun 26, 2021 at 02:58:33PM +0800, Jinchao Wang wrote:
> * By default, we write directly to secure registers. Platforms must
> * override this if they are running non-secure.
> */
> -static void l2c_write_sec(unsigned long val, void __iomem *base, unsigned reg)
> +static void l2c_write_sec(unsigned long val, void __iomem *base, unsigned int reg)
... and then I'll get another patch because this now goes over 80
characters. No thanks.
There is nothing inherently wrong with "unsigned" - it's always been
legal C, and I'd prefer to keep the code as-is under arch/arm in
regard of this.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jinchao Wang <wjc@cdjrlc.com>
Cc: guillaume.tucker@collabora.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: mm: Prefer unsigned int to bare use of unsigned
Date: Sat, 26 Jun 2021 10:21:13 +0100 [thread overview]
Message-ID: <20210626092113.GZ22278@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210626065833.6653-1-wjc@cdjrlc.com>
On Sat, Jun 26, 2021 at 02:58:33PM +0800, Jinchao Wang wrote:
> * By default, we write directly to secure registers. Platforms must
> * override this if they are running non-secure.
> */
> -static void l2c_write_sec(unsigned long val, void __iomem *base, unsigned reg)
> +static void l2c_write_sec(unsigned long val, void __iomem *base, unsigned int reg)
... and then I'll get another patch because this now goes over 80
characters. No thanks.
There is nothing inherently wrong with "unsigned" - it's always been
legal C, and I'd prefer to keep the code as-is under arch/arm in
regard of this.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-06-26 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 6:58 [PATCH] arm: mm: Prefer unsigned int to bare use of unsigned Jinchao Wang
2021-06-26 9:21 ` Russell King (Oracle) [this message]
2021-06-26 9:21 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210626092113.GZ22278@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=guillaume.tucker@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wjc@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.