[Buildroot] [PATCH v2 1/1] package/gesftpserver: Fix per-package build without Python

[Buildroot] [PATCH v2 1/1] package/gesftpserver: Fix per-package build without Python

[Andreas Naumann]

When building per-package in an environment without Python, the gesftpserver
configure script dies when looking for Python support.
The configure script is happy (doesnt check and wont error out) when being
told that Python is not available, so we hack around this by setting the
appropriate env variable.

Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
---
 package/gesftpserver/gesftpserver.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/gesftpserver/gesftpserver.mk b/package/gesftpserver/gesftpserver.mk
index 85511a3c97..a261719610 100644
--- a/package/gesftpserver/gesftpserver.mk
+++ b/package/gesftpserver/gesftpserver.mk
@@ -23,6 +23,8 @@ GESFTPSERVER_DEPENDENCIES += \
 	$(if $(BR2_ENABLE_LOCALE),,libiconv) \
 	$(if $(BR2_PACKAGE_OPENSSH),openssh)
 
+GESFTPSERVER_CONF_ENV += rjk_cv_python24=false
+
 # openssh/dropbear looks here
 define GESFTPSERVER_ADD_SYMLINK
 	ln -sf gesftpserver $(TARGET_DIR)/usr/libexec/sftp-server
-- 
2.32.0

[Buildroot] [PATCH v2 1/1] package/gesftpserver: Fix per-package build without Python

[Thomas Petazzoni]

On Thu, 24 Jun 2021 14:32:37 +0200
Andreas Naumann <anaumann@ultratronik.de> wrote:

> When building per-package in an environment without Python, the gesftpserver
> configure script dies when looking for Python support.
> The configure script is happy (doesnt check and wont error out) when being
> told that Python is not available, so we hack around this by setting the
> appropriate env variable.
> 
> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>

Thanks, but the issue is not at all related to per-package. In an
environment without Python, gesftpserver fails to build, even with
BR2_PER_PACKAGE_DIRECTORIES disabled.

So I've applied after rewriting the commit log, and adding a comment
inside the .mk file.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 1/1] package/gesftpserver: Fix per-package build without Python

[Andreas Naumann]

Hi Thomas,

On 26.06.21 15:05, Thomas Petazzoni wrote:
> On Thu, 24 Jun 2021 14:32:37 +0200
> Andreas Naumann <anaumann@ultratronik.de> wrote:
> 
>> When building per-package in an environment without Python, the gesftpserver
>> configure script dies when looking for Python support.
>> The configure script is happy (doesnt check and wont error out) when being
>> told that Python is not available, so we hack around this by setting the
>> appropriate env variable.
>>
>> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
> 
> Thanks, but the issue is not at all related to per-package. In an
> environment without Python, gesftpserver fails to build, even with
> BR2_PER_PACKAGE_DIRECTORIES disabled.

ahm true. It was just in my defconfig that another package reproducably 
built host-python before gesftpserver. When switching to per-package 
that was no longer the case.

> 
> So I've applied after rewriting the commit log, and adding a comment
> inside the .mk file.

Thanks!
Andreas


> 
> Thanks!
> 
> Thomas
> 

[Buildroot] [PATCH v2 1/1] package/gesftpserver: Fix per-package build without Python

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Thu, 24 Jun 2021 14:32:37 +0200
 > Andreas Naumann <anaumann@ultratronik.de> wrote:

 >> When building per-package in an environment without Python, the gesftpserver
 >> configure script dies when looking for Python support.
 >> The configure script is happy (doesnt check and wont error out) when being
 >> told that Python is not available, so we hack around this by setting the
 >> appropriate env variable.
 >> 
 >> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>

 > Thanks, but the issue is not at all related to per-package. In an
 > environment without Python, gesftpserver fails to build, even with
 > BR2_PER_PACKAGE_DIRECTORIES disabled.

 > So I've applied after rewriting the commit log, and adding a comment
 > inside the .mk file.

Committed to 2021.02.x and 2021.05.x, thanks.

-- 
Bye, Peter Korsgaard