* [PATCH] tty: n_gsm: delete DISC command frame as requester
@ 2021-07-01 3:04 Zhenguo Zhao
2021-07-01 11:00 ` kernel test robot
0 siblings, 1 reply; 3+ messages in thread
From: Zhenguo Zhao @ 2021-07-01 3:04 UTC (permalink / raw)
To: zhenguo6858, gregkh, jirislaby; +Cc: linux-kernel
From: Zhenguo Zhao <Zhenguo.Zhao1@unisoc.com>
as initiator,it need to send DISC conmmand ,as requester,there is
no need to send the DISC control frame,it will cause redundant data.
Signed-off-by: Zhenguo Zhao <Zhenguo.Zhao1@unisoc.com>
---
drivers/tty/n_gsm.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 5fea02c..9447148 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -2050,7 +2050,8 @@ static int gsm_disconnect(struct gsm_mux *gsm)
del_timer_sync(&gsm->t2_timer);
/* Now we are sure T2 has stopped */
- gsm_dlci_begin_close(dlci);
+ if (gsm->initiator)
+ gsm_dlci_begin_close(dlci);
wait_event_interruptible(gsm->event,
dlci->state == DLCI_CLOSED);
@@ -3024,7 +3025,8 @@ static void gsmtty_close(struct tty_struct *tty, struct file *filp)
mutex_unlock(&dlci->mutex);
if (tty_port_close_start(&dlci->port, tty, filp) == 0)
return;
- gsm_dlci_begin_close(dlci);
+ if (gsm->initiator)
+ gsm_dlci_begin_close(dlci);
if (tty_port_initialized(&dlci->port) && C_HUPCL(tty))
tty_port_lower_dtr_rts(&dlci->port);
tty_port_close_end(&dlci->port, tty);
@@ -3038,7 +3040,8 @@ static void gsmtty_hangup(struct tty_struct *tty)
if (dlci->state == DLCI_CLOSED)
return;
tty_port_hangup(&dlci->port);
- gsm_dlci_begin_close(dlci);
+ if (gsm->initiator)
+ gsm_dlci_begin_close(dlci);
}
static int gsmtty_write(struct tty_struct *tty, const unsigned char *buf,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tty: n_gsm: delete DISC command frame as requester
2021-07-01 3:04 [PATCH] tty: n_gsm: delete DISC command frame as requester Zhenguo Zhao
@ 2021-07-01 11:00 ` kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-07-01 11:00 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2913 bytes --]
Hi Zhenguo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on v5.13 next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zhenguo-Zhao/tty-n_gsm-delete-DISC-command-frame-as-requester/20210701-110614
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-randconfig-a015-20210630 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project e7e71e9454ed76c1b3d8140170b5333c28bef1be)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/0ac8d1e74492d1765c356f163a7b793a74155fc6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zhenguo-Zhao/tty-n_gsm-delete-DISC-command-frame-as-requester/20210701-110614
git checkout 0ac8d1e74492d1765c356f163a7b793a74155fc6
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/tty/n_gsm.c:3031:6: error: use of undeclared identifier 'gsm'
if (gsm->initiator)
^
drivers/tty/n_gsm.c:3046:6: error: use of undeclared identifier 'gsm'
if (gsm->initiator)
^
2 errors generated.
vim +/gsm +3031 drivers/tty/n_gsm.c
3017
3018 static void gsmtty_close(struct tty_struct *tty, struct file *filp)
3019 {
3020 struct gsm_dlci *dlci = tty->driver_data;
3021
3022 if (dlci == NULL)
3023 return;
3024 if (dlci->state == DLCI_CLOSED)
3025 return;
3026 mutex_lock(&dlci->mutex);
3027 gsm_destroy_network(dlci);
3028 mutex_unlock(&dlci->mutex);
3029 if (tty_port_close_start(&dlci->port, tty, filp) == 0)
3030 return;
> 3031 if (gsm->initiator)
3032 gsm_dlci_begin_close(dlci);
3033 if (tty_port_initialized(&dlci->port) && C_HUPCL(tty))
3034 tty_port_lower_dtr_rts(&dlci->port);
3035 tty_port_close_end(&dlci->port, tty);
3036 tty_port_tty_set(&dlci->port, NULL);
3037 return;
3038 }
3039
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 45882 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tty: n_gsm: delete DISC command frame as requester
@ 2021-07-01 11:00 ` kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-07-01 11:00 UTC (permalink / raw)
To: Zhenguo Zhao, gregkh, jirislaby
Cc: clang-built-linux, kbuild-all, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2841 bytes --]
Hi Zhenguo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on v5.13 next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zhenguo-Zhao/tty-n_gsm-delete-DISC-command-frame-as-requester/20210701-110614
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-randconfig-a015-20210630 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project e7e71e9454ed76c1b3d8140170b5333c28bef1be)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/0ac8d1e74492d1765c356f163a7b793a74155fc6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zhenguo-Zhao/tty-n_gsm-delete-DISC-command-frame-as-requester/20210701-110614
git checkout 0ac8d1e74492d1765c356f163a7b793a74155fc6
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/tty/n_gsm.c:3031:6: error: use of undeclared identifier 'gsm'
if (gsm->initiator)
^
drivers/tty/n_gsm.c:3046:6: error: use of undeclared identifier 'gsm'
if (gsm->initiator)
^
2 errors generated.
vim +/gsm +3031 drivers/tty/n_gsm.c
3017
3018 static void gsmtty_close(struct tty_struct *tty, struct file *filp)
3019 {
3020 struct gsm_dlci *dlci = tty->driver_data;
3021
3022 if (dlci == NULL)
3023 return;
3024 if (dlci->state == DLCI_CLOSED)
3025 return;
3026 mutex_lock(&dlci->mutex);
3027 gsm_destroy_network(dlci);
3028 mutex_unlock(&dlci->mutex);
3029 if (tty_port_close_start(&dlci->port, tty, filp) == 0)
3030 return;
> 3031 if (gsm->initiator)
3032 gsm_dlci_begin_close(dlci);
3033 if (tty_port_initialized(&dlci->port) && C_HUPCL(tty))
3034 tty_port_lower_dtr_rts(&dlci->port);
3035 tty_port_close_end(&dlci->port, tty);
3036 tty_port_tty_set(&dlci->port, NULL);
3037 return;
3038 }
3039
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 45882 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-01 11:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-01 3:04 [PATCH] tty: n_gsm: delete DISC command frame as requester Zhenguo Zhao
2021-07-01 11:00 ` kernel test robot
2021-07-01 11:00 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.