Re: [PATCH] nohz: nohz idle balancing per node

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 6653 bytes --]

Hi Nicholas,

I love your patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.13]
[cannot apply to tip/sched/core next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicholas-Piggin/nohz-nohz-idle-balancing-per-node/20210701-135507
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c54b245d011855ea91c5beff07f1db74143ce614
config: x86_64-randconfig-c022-20210630 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/1bede18329ddbaed4099e980fdf62092ff881932
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nicholas-Piggin/nohz-nohz-idle-balancing-per-node/20210701-135507
        git checkout 1bede18329ddbaed4099e980fdf62092ff881932
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/sched/fair.c:5437:6: warning: no previous prototype for 'init_cfs_bandwidth' [-Wmissing-prototypes]
    5437 | void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
         |      ^~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:10937:6: warning: no previous prototype for 'task_vruntime_update' [-Wmissing-prototypes]
   10937 | void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi)
         |      ^~~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:11470:6: warning: no previous prototype for 'free_fair_sched_group' [-Wmissing-prototypes]
   11470 | void free_fair_sched_group(struct task_group *tg) { }
         |      ^~~~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:11472:5: warning: no previous prototype for 'alloc_fair_sched_group' [-Wmissing-prototypes]
   11472 | int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
         |     ^~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:11477:6: warning: no previous prototype for 'online_fair_sched_group' [-Wmissing-prototypes]
   11477 | void online_fair_sched_group(struct task_group *tg) { }
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:11479:6: warning: no previous prototype for 'unregister_fair_sched_group' [-Wmissing-prototypes]
   11479 | void unregister_fair_sched_group(struct task_group *tg) { }
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from arch/x86/include/asm/current.h:5,
                    from include/linux/sched.h:12,
                    from kernel/sched/sched.h:5,
                    from kernel/sched/fair.c:23:
   kernel/sched/fair.c: In function 'init_sched_fair_class':
>> kernel/sched/fair.c:11590:30: error: 'housekeeping_overridden' undeclared (first use in this function); did you mean 'housekeeping_affine'?
   11590 |  if (static_branch_unlikely(&housekeeping_overridden)) {
         |                              ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/jump_label.h:508:35: note: in expansion of macro 'unlikely_notrace'
     508 | #define static_branch_unlikely(x) unlikely_notrace(static_key_enabled(&(x)->key))
         |                                   ^~~~~~~~~~~~~~~~
   include/linux/jump_label.h:508:52: note: in expansion of macro 'static_key_enabled'
     508 | #define static_branch_unlikely(x) unlikely_notrace(static_key_enabled(&(x)->key))
         |                                                    ^~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:11590:6: note: in expansion of macro 'static_branch_unlikely'
   11590 |  if (static_branch_unlikely(&housekeeping_overridden)) {
         |      ^~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:11590:30: note: each undeclared identifier is reported only once for each function it appears in
   11590 |  if (static_branch_unlikely(&housekeeping_overridden)) {
         |                              ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/jump_label.h:508:35: note: in expansion of macro 'unlikely_notrace'
     508 | #define static_branch_unlikely(x) unlikely_notrace(static_key_enabled(&(x)->key))
         |                                   ^~~~~~~~~~~~~~~~
   include/linux/jump_label.h:508:52: note: in expansion of macro 'static_key_enabled'
     508 | #define static_branch_unlikely(x) unlikely_notrace(static_key_enabled(&(x)->key))
         |                                                    ^~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:11590:6: note: in expansion of macro 'static_branch_unlikely'
   11590 |  if (static_branch_unlikely(&housekeeping_overridden)) {
         |      ^~~~~~~~~~~~~~~~~~~~~~


vim +11590 kernel/sched/fair.c

 11583	
 11584	__init void init_sched_fair_class(void)
 11585	{
 11586	#ifdef CONFIG_SMP
 11587		open_softirq(SCHED_SOFTIRQ, run_rebalance_domains);
 11588	
 11589	#ifdef CONFIG_NO_HZ_COMMON
 11590		if (static_branch_unlikely(&housekeeping_overridden)) {
 11591			struct nohz *nohz;
 11592	
 11593			nohz_nodes = kcalloc(1, sizeof(struct nohz *), GFP_NOWAIT);
 11594			nohz = kmalloc(sizeof(struct nohz), GFP_NOWAIT);
 11595			nohz->next_balance = jiffies;
 11596			nohz->next_blocked = jiffies;
 11597			zalloc_cpumask_var(&nohz->idle_cpus_mask, GFP_NOWAIT);
 11598			nohz_nodes[0] = nohz;
 11599		} else {
 11600			int n;
 11601	
 11602			nohz_nodes = kcalloc(nr_node_ids, sizeof(struct nohz *), GFP_NOWAIT);
 11603			for_each_node(n) {
 11604				struct nohz *nohz;
 11605	
 11606				nohz = kmalloc_node(sizeof(struct nohz), GFP_NOWAIT, n);
 11607				nohz->next_balance = jiffies;
 11608				nohz->next_blocked = jiffies;
 11609				zalloc_cpumask_var_node(&nohz->idle_cpus_mask, GFP_NOWAIT, n);
 11610				nohz_nodes[n] = nohz;
 11611			}
 11612		}
 11613	#endif
 11614	#endif /* SMP */
 11615	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 47275 bytes --]