All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2] tty: n_gsm: delete DISC command frame as requester
Date: Sat, 03 Jul 2021 19:42:08 +0800	[thread overview]
Message-ID: <202107031926.Nh3e9sUp-lkp@intel.com> (raw)
In-Reply-To: <1625139723-23197-1-git-send-email-zhenguo6858@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2127 bytes --]

Hi Zhenguo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on v5.13 next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zhenguo-Zhao/tty-n_gsm-delete-DISC-command-frame-as-requester/20210701-194354
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-rhel-8.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/d4797539c16d71ca9d1f2b1a6959618c20a62d0d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Zhenguo-Zhao/tty-n_gsm-delete-DISC-command-frame-as-requester/20210701-194354
        git checkout d4797539c16d71ca9d1f2b1a6959618c20a62d0d
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/tty/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/tty/n_gsm.c: In function 'gsmtty_hangup':
>> drivers/tty/n_gsm.c:3047:6: error: 'gsm' undeclared (first use in this function)
    3047 |  if (gsm->initiator)
         |      ^~~
   drivers/tty/n_gsm.c:3047:6: note: each undeclared identifier is reported only once for each function it appears in


vim +/gsm +3047 drivers/tty/n_gsm.c

  3040	
  3041	static void gsmtty_hangup(struct tty_struct *tty)
  3042	{
  3043		struct gsm_dlci *dlci = tty->driver_data;
  3044		if (dlci->state == DLCI_CLOSED)
  3045			return;
  3046		tty_port_hangup(&dlci->port);
> 3047		if (gsm->initiator)
  3048			gsm_dlci_begin_close(dlci);
  3049	}
  3050	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41440 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Zhenguo Zhao <zhenguo6858@gmail.com>,
	gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty: n_gsm: delete DISC command frame as requester
Date: Sat, 3 Jul 2021 19:42:08 +0800	[thread overview]
Message-ID: <202107031926.Nh3e9sUp-lkp@intel.com> (raw)
In-Reply-To: <1625139723-23197-1-git-send-email-zhenguo6858@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]

Hi Zhenguo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on v5.13 next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zhenguo-Zhao/tty-n_gsm-delete-DISC-command-frame-as-requester/20210701-194354
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-rhel-8.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/d4797539c16d71ca9d1f2b1a6959618c20a62d0d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Zhenguo-Zhao/tty-n_gsm-delete-DISC-command-frame-as-requester/20210701-194354
        git checkout d4797539c16d71ca9d1f2b1a6959618c20a62d0d
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/tty/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/tty/n_gsm.c: In function 'gsmtty_hangup':
>> drivers/tty/n_gsm.c:3047:6: error: 'gsm' undeclared (first use in this function)
    3047 |  if (gsm->initiator)
         |      ^~~
   drivers/tty/n_gsm.c:3047:6: note: each undeclared identifier is reported only once for each function it appears in


vim +/gsm +3047 drivers/tty/n_gsm.c

  3040	
  3041	static void gsmtty_hangup(struct tty_struct *tty)
  3042	{
  3043		struct gsm_dlci *dlci = tty->driver_data;
  3044		if (dlci->state == DLCI_CLOSED)
  3045			return;
  3046		tty_port_hangup(&dlci->port);
> 3047		if (gsm->initiator)
  3048			gsm_dlci_begin_close(dlci);
  3049	}
  3050	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41440 bytes --]

  parent reply	other threads:[~2021-07-03 11:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01 11:42 [PATCH v2] tty: n_gsm: delete DISC command frame as requester Zhenguo Zhao
2021-07-01 11:46 ` Greg KH
2021-07-03 11:42 ` kernel test robot [this message]
2021-07-03 11:42   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202107031926.Nh3e9sUp-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.