From: Darrick J. Wong <djwong@kernel.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v3 3/3] iomap: Don't create iomap_page objects in iomap_page_mkwrite_actor
Date: Thu, 8 Jul 2021 21:29:34 -0700 [thread overview]
Message-ID: <20210709042934.GV11588@locust> (raw)
In-Reply-To: <20210707115524.2242151-4-agruenba@redhat.com>
On Wed, Jul 07, 2021 at 01:55:24PM +0200, Andreas Gruenbacher wrote:
> Now that we create those objects in iomap_writepage_map when needed,
> there's no need to pre-create them in iomap_page_mkwrite_actor anymore.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
I'd like to stage this series as a bugfix branch against -rc1 next week,
if there are no other objections?
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/iomap/buffered-io.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 6330dabc451e..9f45050b61dd 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -999,7 +999,6 @@ iomap_page_mkwrite_actor(struct inode *inode, loff_t pos, loff_t length,
> block_commit_write(page, 0, length);
> } else {
> WARN_ON_ONCE(!PageUptodate(page));
> - iomap_page_create(inode, page);
> set_page_dirty(page);
> }
>
> --
> 2.26.3
>
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <djwong@kernel.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
cluster-devel@redhat.com
Subject: Re: [PATCH v3 3/3] iomap: Don't create iomap_page objects in iomap_page_mkwrite_actor
Date: Thu, 8 Jul 2021 21:29:34 -0700 [thread overview]
Message-ID: <20210709042934.GV11588@locust> (raw)
In-Reply-To: <20210707115524.2242151-4-agruenba@redhat.com>
On Wed, Jul 07, 2021 at 01:55:24PM +0200, Andreas Gruenbacher wrote:
> Now that we create those objects in iomap_writepage_map when needed,
> there's no need to pre-create them in iomap_page_mkwrite_actor anymore.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
I'd like to stage this series as a bugfix branch against -rc1 next week,
if there are no other objections?
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/iomap/buffered-io.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 6330dabc451e..9f45050b61dd 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -999,7 +999,6 @@ iomap_page_mkwrite_actor(struct inode *inode, loff_t pos, loff_t length,
> block_commit_write(page, 0, length);
> } else {
> WARN_ON_ONCE(!PageUptodate(page));
> - iomap_page_create(inode, page);
> set_page_dirty(page);
> }
>
> --
> 2.26.3
>
next prev parent reply other threads:[~2021-07-09 4:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 11:55 [Cluster-devel] [PATCH v3 0/3] iomap: small block problems Andreas Gruenbacher
2021-07-07 11:55 ` Andreas Gruenbacher
2021-07-07 11:55 ` [Cluster-devel] [PATCH v3 1/3] iomap: Permit pages without an iop to enter writeback Andreas Gruenbacher
2021-07-07 11:55 ` Andreas Gruenbacher
2021-07-09 4:23 ` [Cluster-devel] " Darrick J. Wong
2021-07-09 4:23 ` Darrick J. Wong
2021-07-07 11:55 ` [Cluster-devel] [PATCH v3 2/3] iomap: Don't create iomap_page objects for inline files Andreas Gruenbacher
2021-07-07 11:55 ` Andreas Gruenbacher
2021-07-07 14:28 ` [Cluster-devel] " Matthew Wilcox
2021-07-07 14:28 ` Matthew Wilcox
2021-07-09 4:27 ` [Cluster-devel] " Darrick J. Wong
2021-07-09 4:27 ` Darrick J. Wong
2021-07-09 6:21 ` [Cluster-devel] " Christoph Hellwig
2021-07-09 6:21 ` Christoph Hellwig
2021-07-09 12:01 ` [Cluster-devel] " Matthew Wilcox
2021-07-09 12:01 ` Matthew Wilcox
2021-07-09 4:28 ` [Cluster-devel] " Darrick J. Wong
2021-07-09 4:28 ` Darrick J. Wong
2021-07-09 6:20 ` [Cluster-devel] " Christoph Hellwig
2021-07-09 6:20 ` Christoph Hellwig
2021-07-07 11:55 ` [Cluster-devel] [PATCH v3 3/3] iomap: Don't create iomap_page objects in iomap_page_mkwrite_actor Andreas Gruenbacher
2021-07-07 11:55 ` Andreas Gruenbacher
2021-07-07 14:03 ` [Cluster-devel] " Matthew Wilcox
2021-07-07 14:03 ` Matthew Wilcox
2021-07-09 4:29 ` Darrick J. Wong [this message]
2021-07-09 4:29 ` Darrick J. Wong
2021-07-09 11:07 ` [Cluster-devel] " Andreas Gruenbacher
2021-07-09 11:07 ` Andreas Gruenbacher
2021-07-09 6:22 ` [Cluster-devel] " Christoph Hellwig
2021-07-09 6:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210709042934.GV11588@locust \
--to=djwong@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.