From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Takashi Iwai <tiwai@suse.de>, Hulk Robot <hulkci@huawei.com>,
alsa-devel@alsa-project.org, Yufen Yu <yuyufen@huawei.com>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.19 09/39] ALSA: ac97: fix PM reference leak in ac97_bus_remove()
Date: Fri, 9 Jul 2021 22:31:34 -0400 [thread overview]
Message-ID: <20210710023204.3171428-9-sashal@kernel.org> (raw)
In-Reply-To: <20210710023204.3171428-1-sashal@kernel.org>
From: Yufen Yu <yuyufen@huawei.com>
[ Upstream commit a38e93302ee25b2ca6f4ee76c6c974cf3637985e ]
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yufen Yu <yuyufen@huawei.com>
Link: https://lore.kernel.org/r/20210524093811.612302-1-yuyufen@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
sound/ac97/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/ac97/bus.c b/sound/ac97/bus.c
index ca50ff444796..d8b227e6d4cf 100644
--- a/sound/ac97/bus.c
+++ b/sound/ac97/bus.c
@@ -523,7 +523,7 @@ static int ac97_bus_remove(struct device *dev)
struct ac97_codec_driver *adrv = to_ac97_driver(dev->driver);
int ret;
- ret = pm_runtime_get_sync(dev);
+ ret = pm_runtime_resume_and_get(dev);
if (ret < 0)
return ret;
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Yufen Yu <yuyufen@huawei.com>, Hulk Robot <hulkci@huawei.com>,
Takashi Iwai <tiwai@suse.de>, Sasha Levin <sashal@kernel.org>,
alsa-devel@alsa-project.org
Subject: [PATCH AUTOSEL 4.19 09/39] ALSA: ac97: fix PM reference leak in ac97_bus_remove()
Date: Fri, 9 Jul 2021 22:31:34 -0400 [thread overview]
Message-ID: <20210710023204.3171428-9-sashal@kernel.org> (raw)
In-Reply-To: <20210710023204.3171428-1-sashal@kernel.org>
From: Yufen Yu <yuyufen@huawei.com>
[ Upstream commit a38e93302ee25b2ca6f4ee76c6c974cf3637985e ]
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yufen Yu <yuyufen@huawei.com>
Link: https://lore.kernel.org/r/20210524093811.612302-1-yuyufen@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
sound/ac97/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/ac97/bus.c b/sound/ac97/bus.c
index ca50ff444796..d8b227e6d4cf 100644
--- a/sound/ac97/bus.c
+++ b/sound/ac97/bus.c
@@ -523,7 +523,7 @@ static int ac97_bus_remove(struct device *dev)
struct ac97_codec_driver *adrv = to_ac97_driver(dev->driver);
int ret;
- ret = pm_runtime_get_sync(dev);
+ ret = pm_runtime_resume_and_get(dev);
if (ret < 0)
return ret;
--
2.30.2
next prev parent reply other threads:[~2021-07-10 2:48 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 2:31 [PATCH AUTOSEL 4.19 01/39] tty: serial: fsl_lpuart: fix the potential risk of division or modulo by zero Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 02/39] misc/libmasm/module: Fix two use after free in ibmasm_init_one Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 03/39] Revert "ALSA: bebob/oxfw: fix Kconfig entry for Mackie d.2 Pro" Sasha Levin
2021-07-10 2:31 ` Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 04/39] w1: ds2438: fixing bug that would always get page0 Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 05/39] scsi: hisi_sas: Propagate errors in interrupt_init_v1_hw() Sasha Levin
2021-07-10 9:20 ` Sergey Shtylyov
2021-07-18 1:20 ` Sasha Levin
2021-07-18 9:13 ` Sergey Shtylyov
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 06/39] scsi: lpfc: Fix "Unexpected timeout" error in direct attach topology Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 07/39] scsi: lpfc: Fix crash when lpfc_sli4_hba_setup() fails to initialize the SGLs Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 08/39] scsi: core: Cap scsi_host cmd_per_lun at can_queue Sasha Levin
2021-07-10 2:31 ` Sasha Levin [this message]
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 09/39] ALSA: ac97: fix PM reference leak in ac97_bus_remove() Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 10/39] tty: serial: 8250: serial_cs: Fix a memory leak in error handling path Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 11/39] scsi: scsi_dh_alua: Check for negative result value Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 12/39] fs/jfs: Fix missing error code in lmLogInit() Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 13/39] scsi: iscsi: Add iscsi_cls_conn refcount helpers Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 14/39] scsi: iscsi: Fix conn use after free during resets Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 15/39] scsi: iscsi: Fix shost->max_id use Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 16/39] scsi: qedi: Fix null ref during abort handling Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 17/39] mfd: da9052/stmpe: Add and modify MODULE_DEVICE_TABLE Sasha Levin
2021-07-10 2:31 ` Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 18/39] s390/sclp_vt220: fix console name to match device Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 19/39] selftests: timers: rtcpie: skip test if default RTC device does not exist Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 20/39] USB: core: Avoid WARNings for 0-length descriptor requests Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 21/39] ALSA: sb: Fix potential double-free of CSP mixer elements Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 22/39] powerpc/ps3: Add dma_mask to ps3_dma_region Sasha Levin
2021-07-10 2:31 ` Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 23/39] gpio: zynq: Check return value of pm_runtime_get_sync Sasha Levin
2021-07-10 2:31 ` Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 24/39] ALSA: ppc: fix error return code in snd_pmac_probe() Sasha Levin
2021-07-10 2:31 ` Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 25/39] selftests/powerpc: Fix "no_handler" EBB selftest Sasha Levin
2021-07-10 2:31 ` Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 26/39] gpio: pca953x: Add support for the On Semi pca9655 Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 27/39] ASoC: soc-core: Fix the error return code in snd_soc_of_parse_audio_routing() Sasha Levin
2021-07-10 2:31 ` Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 28/39] Input: hideep - fix the uninitialized use in hideep_nvm_unlock() Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 29/39] ALSA: bebob: add support for ToneWeal FW66 Sasha Levin
2021-07-10 2:31 ` Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 30/39] usb: gadget: f_hid: fix endianness issue with descriptors Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 31/39] usb: gadget: hid: fix error return code in hid_bind() Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 32/39] powerpc/boot: Fixup device-tree on little endian Sasha Levin
2021-07-10 2:31 ` Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 33/39] backlight: lm3630a: Fix return code of .update_status() callback Sasha Levin
2021-07-10 2:31 ` Sasha Levin
2021-07-10 2:31 ` [PATCH AUTOSEL 4.19 34/39] ALSA: hda: Add IRQ check for platform_get_irq() Sasha Levin
2021-07-10 2:31 ` Sasha Levin
2021-07-10 2:32 ` [PATCH AUTOSEL 4.19 35/39] jfs: fix GPF in diFree Sasha Levin
2021-07-10 2:32 ` [PATCH AUTOSEL 4.19 36/39] staging: rtl8723bs: fix macro value for 2.4Ghz only device Sasha Levin
2021-07-10 2:32 ` [PATCH AUTOSEL 4.19 37/39] intel_th: Wait until port is in reset before programming it Sasha Levin
2021-07-10 2:32 ` [PATCH AUTOSEL 4.19 38/39] i2c: core: Disable client irq on reboot/shutdown Sasha Levin
2021-07-10 2:32 ` [PATCH AUTOSEL 4.19 39/39] lib/decompress_unlz4.c: correctly handle zero-padding around initrds Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210710023204.3171428-9-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.