From: Colin Foster <colin.foster@in-advantage.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
claudiu.manoil@nxp.com, alexandre.belloni@bootlin.com,
UNGLinuxDriver@microchip.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 net-next 3/8] net: dsa: ocelot: felix: NULL check on variable
Date: Sun, 11 Jul 2021 09:47:17 -0700 [thread overview]
Message-ID: <20210711164717.GE2219684@euler> (raw)
In-Reply-To: <20210710200628.uwwyzuuou242anzq@skbuf>
On Sat, Jul 10, 2021 at 11:06:28PM +0300, Vladimir Oltean wrote:
> On Sat, Jul 10, 2021 at 12:25:57PM -0700, Colin Foster wrote:
> > Add NULL check before dereferencing array
> >
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
>
> The patch is correct but is insufficiently documented. In particular,
> people might interpret it as a bug fix and backport it to stable
> kernels.
That makes sense. I'll clarify that it is only something that'll affect
future drivers and not a bug fix.
next prev parent reply other threads:[~2021-07-11 16:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 19:25 [RFC PATCH v2 net-next 0/8] Add support for VSC7511-7514 chips over SPI Colin Foster
2021-07-10 19:25 ` [RFC PATCH v2 net-next 1/8] net: dsa: ocelot: remove unnecessary pci_bar variables Colin Foster
2021-07-10 19:53 ` Vladimir Oltean
2021-07-11 16:36 ` Colin Foster
2021-07-10 19:25 ` [RFC PATCH v2 net-next 2/8] net: dsa: ocelot: felix: move MDIO access to a common location Colin Foster
2021-07-10 19:59 ` Vladimir Oltean
2021-07-10 20:02 ` Alexandre Belloni
2021-07-11 16:41 ` Colin Foster
2021-07-10 21:05 ` kernel test robot
2021-07-10 19:25 ` [RFC PATCH v2 net-next 3/8] net: dsa: ocelot: felix: NULL check on variable Colin Foster
2021-07-10 20:06 ` Vladimir Oltean
2021-07-11 16:47 ` Colin Foster [this message]
2021-07-10 19:25 ` [RFC PATCH v2 net-next 4/8] net: dsa: ocelot: felix: add interface for custom regmaps Colin Foster
2021-07-10 19:25 ` [RFC PATCH v2 net-next 5/8] net: mscc: ocelot: split register definitions to a separate file Colin Foster
2021-07-10 19:26 ` [RFC PATCH v2 net-next 6/8] net: mscc: ocelot: expose ocelot wm functions Colin Foster
2021-07-10 20:36 ` Vladimir Oltean
2021-07-10 19:26 ` [RFC PATCH v2 net-next 7/8] net: dsa: ocelot: felix: add support for VSC75XX control over SPI Colin Foster
2021-07-10 20:52 ` Vladimir Oltean
2021-07-11 17:09 ` Colin Foster
2021-07-11 22:13 ` Alexandre Belloni
2021-07-10 21:51 ` kernel test robot
2021-07-10 19:26 ` [RFC PATCH v2 net-next 8/8] Update documentation for the VSC7512 SPI device Colin Foster
2021-07-10 20:34 ` Vladimir Oltean
2021-07-11 16:58 ` Colin Foster
2021-07-10 19:47 ` [RFC PATCH v2 net-next 0/8] Add support for VSC7511-7514 chips over SPI Vladimir Oltean
2021-07-11 16:32 ` Colin Foster
2021-07-10 20:01 ` Alexandre Belloni
2021-07-11 16:44 ` Colin Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210711164717.GE2219684@euler \
--to=colin.foster@in-advantage.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.