From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ohad@wizery.com,
dongas86@gmail.com, bjorn.andersson@linaro.org, cleger@kalray.eu
Subject: Re: [PATCH 2/2] remoteproc: fix kernel doc for struct rproc_ops
Date: Mon, 12 Jul 2021 11:41:21 -0600 [thread overview]
Message-ID: <20210712174121.GB1779922@p14s> (raw)
In-Reply-To: <20210706142156.952794-2-aisheng.dong@nxp.com>
On Tue, Jul 06, 2021 at 10:21:56PM +0800, Dong Aisheng wrote:
> The load_rsc_table was removed since the
> commit c1d35c1ab424 ("remoteproc: Rename "load_rsc_table" to "parse_fw"")
> but got added back again by mistake in the below commit:
> commit b1a17513a2d6 ("remoteproc: add vendor resources handling").
>
> The patch fixed a small code indent issue which not worth
> a separate patch.
>
> Fixes: b1a17513a2d6 ("remoteproc: add vendor resources handling")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> include/linux/remoteproc.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Bjorn - checkpatch gets confused with the two double quotes in the changelog. I
checked the syntax and everything is conformant to the guidelines.
> diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
> index a5b37bc10865..83c09ac36b13 100644
> --- a/include/linux/remoteproc.h
> +++ b/include/linux/remoteproc.h
> @@ -369,9 +369,8 @@ enum rsc_handling_status {
> * @da_to_va: optional platform hook to perform address translations
> * @parse_fw: parse firmware to extract information (e.g. resource table)
> * @handle_rsc: optional platform hook to handle vendor resources. Should return
> - * RSC_HANDLED if resource was handled, RSC_IGNORED if not handled and a
> - * negative value on error
> - * @load_rsc_table: load resource table from firmware image
> + * RSC_HANDLED if resource was handled, RSC_IGNORED if not handled
> + * and a negative value on error
> * @find_loaded_rsc_table: find the loaded resource table from firmware image
> * @get_loaded_rsc_table: get resource table installed in memory
> * by external entity
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ohad@wizery.com,
dongas86@gmail.com, bjorn.andersson@linaro.org, cleger@kalray.eu
Subject: Re: [PATCH 2/2] remoteproc: fix kernel doc for struct rproc_ops
Date: Mon, 12 Jul 2021 11:41:21 -0600 [thread overview]
Message-ID: <20210712174121.GB1779922@p14s> (raw)
In-Reply-To: <20210706142156.952794-2-aisheng.dong@nxp.com>
On Tue, Jul 06, 2021 at 10:21:56PM +0800, Dong Aisheng wrote:
> The load_rsc_table was removed since the
> commit c1d35c1ab424 ("remoteproc: Rename "load_rsc_table" to "parse_fw"")
> but got added back again by mistake in the below commit:
> commit b1a17513a2d6 ("remoteproc: add vendor resources handling").
>
> The patch fixed a small code indent issue which not worth
> a separate patch.
>
> Fixes: b1a17513a2d6 ("remoteproc: add vendor resources handling")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> include/linux/remoteproc.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Bjorn - checkpatch gets confused with the two double quotes in the changelog. I
checked the syntax and everything is conformant to the guidelines.
> diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
> index a5b37bc10865..83c09ac36b13 100644
> --- a/include/linux/remoteproc.h
> +++ b/include/linux/remoteproc.h
> @@ -369,9 +369,8 @@ enum rsc_handling_status {
> * @da_to_va: optional platform hook to perform address translations
> * @parse_fw: parse firmware to extract information (e.g. resource table)
> * @handle_rsc: optional platform hook to handle vendor resources. Should return
> - * RSC_HANDLED if resource was handled, RSC_IGNORED if not handled and a
> - * negative value on error
> - * @load_rsc_table: load resource table from firmware image
> + * RSC_HANDLED if resource was handled, RSC_IGNORED if not handled
> + * and a negative value on error
> * @find_loaded_rsc_table: find the loaded resource table from firmware image
> * @get_loaded_rsc_table: get resource table installed in memory
> * by external entity
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-12 17:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 14:21 [PATCH 1/2] remoteproc: fix an typo in fw_elf_get_class code comments Dong Aisheng
2021-07-06 14:21 ` Dong Aisheng
2021-07-06 14:21 ` [PATCH 2/2] remoteproc: fix kernel doc for struct rproc_ops Dong Aisheng
2021-07-06 14:21 ` Dong Aisheng
2021-07-12 17:41 ` Mathieu Poirier [this message]
2021-07-12 17:41 ` Mathieu Poirier
2021-07-12 17:29 ` [PATCH 1/2] remoteproc: fix an typo in fw_elf_get_class code comments Mathieu Poirier
2021-07-12 17:29 ` Mathieu Poirier
2021-08-04 19:31 ` patchwork-bot+linux-remoteproc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712174121.GB1779922@p14s \
--to=mathieu.poirier@linaro.org \
--cc=aisheng.dong@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=cleger@kalray.eu \
--cc=dongas86@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.