All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uladzislau Rezki <urezki@gmail.com>
To: lkp@lists.01.org
Subject: Re: [mm/vmalloc] 5c1f4e690e: BUG:sleeping_function_called_from_invalid_context_at_mm/page_alloc.c
Date: Tue, 13 Jul 2021 21:58:35 +0200	[thread overview]
Message-ID: <20210713195835.GA21685@pc638.lan> (raw)
In-Reply-To: <YO3a7erVd2yXdaAK@casper.infradead.org>

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

On Tue, Jul 13, 2021 at 07:26:53PM +0100, Matthew Wilcox wrote:
> On Tue, Jul 13, 2021 at 11:19:29AM -0700, Linus Torvalds wrote:
> > Does anybody see what the problem is there?
> > 
> > There's an odd report _after_ the warning:
> > 
> > [  131.345319] raw_local_irq_restore() called with IRQs enabled
> > [  131.366561] RIP: 0010:warn_bogus_irq_restore+0x1d/0x20
> > [  131.433334]  __alloc_pages_bulk+0xbb8/0xf20
> 
> That's the key -- __alloc_pages_bulk has interrupts disabled and then
> page_owner allocates memory for the stack dump.  Mel has a fix; I think
> we're just waiting for it to hit your tree.
> 
I was thinking about how we came to the step when a sleeping check is fired
somewhere deep in the "page-bulk" allocator. If vmalloc was invoked from
non-sleepin context we would see it earlier, at least in alloc_vmap_area().

I think, the bulk allocator disables interrupts and does some sleeping
things.

Matthew, Could you please point to the fix?

--
Vlad Rezki

WARNING: multiple messages have this Message-ID (diff)
From: Uladzislau Rezki <urezki@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	kernel test robot <oliver.sang@intel.com>,
	Uladzislau Rezki <urezki@gmail.com>, Mel Gorman <mgorman@suse.de>,
	Hillf Danton <hdanton@sina.com>, Michal Hocko <mhocko@suse.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@lists.01.org, kernel test robot <lkp@intel.com>
Subject: Re: [mm/vmalloc] 5c1f4e690e: BUG:sleeping_function_called_from_invalid_context_at_mm/page_alloc.c
Date: Tue, 13 Jul 2021 21:58:35 +0200	[thread overview]
Message-ID: <20210713195835.GA21685@pc638.lan> (raw)
In-Reply-To: <YO3a7erVd2yXdaAK@casper.infradead.org>

On Tue, Jul 13, 2021 at 07:26:53PM +0100, Matthew Wilcox wrote:
> On Tue, Jul 13, 2021 at 11:19:29AM -0700, Linus Torvalds wrote:
> > Does anybody see what the problem is there?
> > 
> > There's an odd report _after_ the warning:
> > 
> > [  131.345319] raw_local_irq_restore() called with IRQs enabled
> > [  131.366561] RIP: 0010:warn_bogus_irq_restore+0x1d/0x20
> > [  131.433334]  __alloc_pages_bulk+0xbb8/0xf20
> 
> That's the key -- __alloc_pages_bulk has interrupts disabled and then
> page_owner allocates memory for the stack dump.  Mel has a fix; I think
> we're just waiting for it to hit your tree.
> 
I was thinking about how we came to the step when a sleeping check is fired
somewhere deep in the "page-bulk" allocator. If vmalloc was invoked from
non-sleepin context we would see it earlier, at least in alloc_vmap_area().

I think, the bulk allocator disables interrupts and does some sleeping
things.

Matthew, Could you please point to the fix?

--
Vlad Rezki

  reply	other threads:[~2021-07-13 19:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 14:24 [mm/vmalloc] 5c1f4e690e: BUG:sleeping_function_called_from_invalid_context_at_mm/page_alloc.c kernel test robot
2021-07-13 14:24 ` kernel test robot
2021-07-13 18:19 ` Linus Torvalds
2021-07-13 18:19   ` Linus Torvalds
2021-07-13 18:26   ` Matthew Wilcox
2021-07-13 18:26     ` Matthew Wilcox
2021-07-13 19:58     ` Uladzislau Rezki [this message]
2021-07-13 19:58       ` Uladzislau Rezki
2021-07-13 21:54   ` Mel Gorman
2021-07-13 21:54     ` Mel Gorman
2021-07-13 19:52 ` Linus Torvalds
2021-07-13 19:52   ` Linus Torvalds
2021-07-14  8:48   ` Chen, Rong A
2021-07-14  8:48     ` [LKP] " Chen, Rong A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210713195835.GA21685@pc638.lan \
    --to=urezki@gmail.com \
    --cc=lkp@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.