All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramalingam C <ramalingam.c@intel.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: igt-dev@lists.freedesktop.org,
	Mohammed Khajapasha <mohammed.khajapasha@intel.com>,
	intel-gfx@lists.freedesktop.org,
	Latvala Petri <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_addfb_basic: pass the actual fd to gem_has_lmem
Date: Wed, 14 Jul 2021 15:24:06 +0530	[thread overview]
Message-ID: <20210714095406.GA27868@intel.com> (raw)
In-Reply-To: <20210707105238.1694091-1-matthew.auld@intel.com>

On 2021-07-07 at 11:52:38 +0100, Matthew Auld wrote:
> Currently we pass the devid as if it were the fd, which doesn't work.
> 
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
LGTM.

Reviewed-by: Ramalingam C <ramalingam.c@intel.com>

> Cc: Mohammed Khajapasha <mohammed.khajapasha@intel.com>
> Cc: Latvala Petri <petri.latvala@intel.com>
> Cc: Michael J. Ruhl <michael.j.ruhl@intel.com>
> ---
>  tests/kms_addfb_basic.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 91fb6ac9..eff1d9b2 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -150,13 +150,11 @@ static void invalid_tests(int fd)
>  	igt_describe("Check if addfb2 with a system memory gem object "
>  		     "fails correctly if device requires local memory framebuffers");
>  	igt_subtest("invalid-smem-bo-on-discrete") {
> -		int devid;
>  		uint32_t handle, stride;
>  		uint64_t size;
>  
>  		igt_require_intel(fd);
> -		devid = intel_get_drm_devid(fd);
> -		igt_require(gem_has_lmem(devid));
> +		igt_require(gem_has_lmem(fd));
>  		igt_calc_fb_size(fd, f.width, f.height,
>  				DRM_FORMAT_XRGB8888, 0, &size, &stride);
>  		handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
> -- 
> 2.26.3
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

WARNING: multiple messages have this Message-ID (diff)
From: Ramalingam C <ramalingam.c@intel.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: igt-dev@lists.freedesktop.org,
	Mohammed Khajapasha <mohammed.khajapasha@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/kms_addfb_basic: pass the actual fd to gem_has_lmem
Date: Wed, 14 Jul 2021 15:24:06 +0530	[thread overview]
Message-ID: <20210714095406.GA27868@intel.com> (raw)
In-Reply-To: <20210707105238.1694091-1-matthew.auld@intel.com>

On 2021-07-07 at 11:52:38 +0100, Matthew Auld wrote:
> Currently we pass the devid as if it were the fd, which doesn't work.
> 
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
LGTM.

Reviewed-by: Ramalingam C <ramalingam.c@intel.com>

> Cc: Mohammed Khajapasha <mohammed.khajapasha@intel.com>
> Cc: Latvala Petri <petri.latvala@intel.com>
> Cc: Michael J. Ruhl <michael.j.ruhl@intel.com>
> ---
>  tests/kms_addfb_basic.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 91fb6ac9..eff1d9b2 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -150,13 +150,11 @@ static void invalid_tests(int fd)
>  	igt_describe("Check if addfb2 with a system memory gem object "
>  		     "fails correctly if device requires local memory framebuffers");
>  	igt_subtest("invalid-smem-bo-on-discrete") {
> -		int devid;
>  		uint32_t handle, stride;
>  		uint64_t size;
>  
>  		igt_require_intel(fd);
> -		devid = intel_get_drm_devid(fd);
> -		igt_require(gem_has_lmem(devid));
> +		igt_require(gem_has_lmem(fd));
>  		igt_calc_fb_size(fd, f.width, f.height,
>  				DRM_FORMAT_XRGB8888, 0, &size, &stride);
>  		handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
> -- 
> 2.26.3
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-07-14  9:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 10:52 [igt-dev] [PATCH i-g-t] tests/kms_addfb_basic: pass the actual fd to gem_has_lmem Matthew Auld
2021-07-07 10:52 ` [Intel-gfx] " Matthew Auld
2021-07-07 11:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-07-07 13:01 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-14  9:54 ` Ramalingam C [this message]
2021-07-14  9:54   ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Ramalingam C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210714095406.GA27868@intel.com \
    --to=ramalingam.c@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=mohammed.khajapasha@intel.com \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.