Re: [PATCH v5 2/2] media: rc: introduce Meson IR TX driver

Re: [PATCH v5 2/2] media: rc: introduce Meson IR TX driver

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1852 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210714212706.24945-3-viktor.prutyanov@phystech.edu>
References: <20210714212706.24945-3-viktor.prutyanov@phystech.edu>
TO: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
TO: sean(a)mess.org
TO: mchehab(a)kernel.org
TO: robh+dt(a)kernel.org
TO: khilman(a)baylibre.com
TO: narmstrong(a)baylibre.com
CC: jbrunet(a)baylibre.com
CC: martin.blumenstingl(a)googlemail.com
CC: linux-media(a)vger.kernel.org
CC: devicetree(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

Hi Viktor,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.14-rc1 next-20210715]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Viktor-Prutyanov/media-rc-add-support-for-Amlogic-Meson-IR-blaster/20210715-052839
base:   git://linuxtv.org/media_tree.git master
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago
config: nds32-randconfig-c004-20210715 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/media/rc/meson-ir-tx.c:323:2-9: line 323 is redundant because platform_get_irq() already prints an error
--
>> drivers/media/rc/meson-ir-tx.c:401:3-8: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36591 bytes --]

[PATCH] media: rc: fix platform_get_irq.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210714212706.24945-3-viktor.prutyanov@phystech.edu>
References: <20210714212706.24945-3-viktor.prutyanov@phystech.edu>
TO: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
TO: sean(a)mess.org
TO: mchehab(a)kernel.org
TO: robh+dt(a)kernel.org
TO: khilman(a)baylibre.com
TO: narmstrong(a)baylibre.com
CC: jbrunet(a)baylibre.com
CC: martin.blumenstingl(a)googlemail.com
CC: linux-media(a)vger.kernel.org
CC: devicetree(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/media/rc/meson-ir-tx.c:323:2-9: line 323 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

CC: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Viktor-Prutyanov/media-rc-add-support-for-Amlogic-Meson-IR-blaster/20210715-052839
base:   git://linuxtv.org/media_tree.git master
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago

Please take the patch only if it's a positive warning. Thanks!

 meson-ir-tx.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/media/rc/meson-ir-tx.c
+++ b/drivers/media/rc/meson-ir-tx.c
@@ -320,7 +320,6 @@ static int __init meson_irtx_probe(struc
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(dev, "no irq resource found\n");
 		return -ENODEV;
 	}
 

[PATCH] media: rc: fix platform_no_drv_owner.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210714212706.24945-3-viktor.prutyanov@phystech.edu>
References: <20210714212706.24945-3-viktor.prutyanov@phystech.edu>
TO: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
TO: sean(a)mess.org
TO: mchehab(a)kernel.org
TO: robh+dt(a)kernel.org
TO: khilman(a)baylibre.com
TO: narmstrong(a)baylibre.com
CC: jbrunet(a)baylibre.com
CC: martin.blumenstingl(a)googlemail.com
CC: linux-media(a)vger.kernel.org
CC: devicetree(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/media/rc/meson-ir-tx.c:401:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Viktor-Prutyanov/media-rc-add-support-for-Amlogic-Meson-IR-blaster/20210715-052839
base:   git://linuxtv.org/media_tree.git master
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago

 meson-ir-tx.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/media/rc/meson-ir-tx.c
+++ b/drivers/media/rc/meson-ir-tx.c
@@ -398,7 +398,6 @@ static struct platform_driver meson_irtx
 	.remove = meson_irtx_remove,
 	.driver = {
 		.name = DRIVER_NAME,
-		.owner  = THIS_MODULE,
 		.of_match_table = meson_irtx_dt_match,
 	},
 };

[ragnatech:media-next 128/278] drivers/media/rc/meson-ir-tx.c:327:2-9: line 327 is redundant because platform_get_irq() already prints an error

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: Sean Young <sean@mess.org>

tree:   git://git.ragnatech.se/linux media-next
head:   d62cd4d277cc711f781a7bdec4109c6148529b25
commit: 49be1c78d575eedf862a05aebfd5ab5c24193f61 [128/278] media: rc: introduce Meson IR TX driver
:::::: branch date: 2 days ago
:::::: commit date: 3 weeks ago
config: sparc64-randconfig-c024-20210822 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/media/rc/meson-ir-tx.c:327:2-9: line 327 is redundant because platform_get_irq() already prints an error
--
>> drivers/media/rc/meson-ir-tx.c:398:3-8: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34356 bytes --]

[PATCH] media: rc: fix platform_no_drv_owner.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: Sean Young <sean@mess.org>
CC: Neil Armstrong <narmstrong@baylibre.com>
CC: Kevin Hilman <khilman@baylibre.com>
CC: Jerome Brunet <jbrunet@baylibre.com>
CC: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-amlogic(a)lists.infradead.org

From: kernel test robot <lkp@intel.com>

drivers/media/rc/meson-ir-tx.c:398:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   git://git.ragnatech.se/linux media-next
head:   d62cd4d277cc711f781a7bdec4109c6148529b25
commit: 49be1c78d575eedf862a05aebfd5ab5c24193f61 [128/278] media: rc: introduce Meson IR TX driver
:::::: branch date: 2 days ago
:::::: commit date: 3 weeks ago

 meson-ir-tx.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/media/rc/meson-ir-tx.c
+++ b/drivers/media/rc/meson-ir-tx.c
@@ -395,7 +395,6 @@ static struct platform_driver meson_irtx
 	.remove = meson_irtx_remove,
 	.driver = {
 		.name = DRIVER_NAME,
-		.owner  = THIS_MODULE,
 		.of_match_table = meson_irtx_dt_match,
 	},
 };