Re: [PATCH nf 2/2] netfilter: flowtable: remove nf_ct_l4proto_find() call

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3980 bytes --]

Hi Pablo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on nf/master]

url:    https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-nft_last-avoid-possible-false-sharing/20210718-102117
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: mips-randconfig-r032-20210718 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 5d5b08761f944d5b9822d582378333cc4b36a0a7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/5f2c0c949c4707c91d270de9993cf889ece6261a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pablo-Neira-Ayuso/netfilter-nft_last-avoid-possible-false-sharing/20210718-102117
        git checkout 5f2c0c949c4707c91d270de9993cf889ece6261a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> net/netfilter/nf_flow_table_core.c:191:13: warning: variable 'timeout' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
           } else if (l4num == IPPROTO_UDP) {
                      ^~~~~~~~~~~~~~~~~~~~
   net/netfilter/nf_flow_table_core.c:197:50: note: uninitialized use occurs here
           if (nf_flow_timeout_delta(ct->timeout) > (__s32)timeout)
                                                           ^~~~~~~
   net/netfilter/nf_flow_table_core.c:191:9: note: remove the 'if' if its condition is always true
           } else if (l4num == IPPROTO_UDP) {
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
   net/netfilter/nf_flow_table_core.c:185:22: note: initialize the variable 'timeout' to silence this warning
           unsigned int timeout;
                               ^
                                = 0
   1 warning generated.


vim +191 net/netfilter/nf_flow_table_core.c

da5984e51063a2 Felix Fietkau     2018-02-26  180  
1e5b2471bcc483 Pablo Neira Ayuso 2019-08-09  181  static void flow_offload_fixup_ct_timeout(struct nf_conn *ct)
da5984e51063a2 Felix Fietkau     2018-02-26  182  {
1d91d2e1a7f767 Oz Shlomo         2021-06-03  183  	struct net *net = nf_ct_net(ct);
1e5b2471bcc483 Pablo Neira Ayuso 2019-08-09  184  	int l4num = nf_ct_protonum(ct);
da5984e51063a2 Felix Fietkau     2018-02-26  185  	unsigned int timeout;
da5984e51063a2 Felix Fietkau     2018-02-26  186  
1d91d2e1a7f767 Oz Shlomo         2021-06-03  187  	if (l4num == IPPROTO_TCP) {
1d91d2e1a7f767 Oz Shlomo         2021-06-03  188  		struct nf_tcp_net *tn = nf_tcp_pernet(net);
1d91d2e1a7f767 Oz Shlomo         2021-06-03  189  
1d91d2e1a7f767 Oz Shlomo         2021-06-03  190  		timeout = tn->offload_pickup;
1d91d2e1a7f767 Oz Shlomo         2021-06-03 @191  	} else if (l4num == IPPROTO_UDP) {
1d91d2e1a7f767 Oz Shlomo         2021-06-03  192  		struct nf_udp_net *tn = nf_udp_pernet(net);
1d91d2e1a7f767 Oz Shlomo         2021-06-03  193  
1d91d2e1a7f767 Oz Shlomo         2021-06-03  194  		timeout = tn->offload_pickup;
1d91d2e1a7f767 Oz Shlomo         2021-06-03  195  	}
da5984e51063a2 Felix Fietkau     2018-02-26  196  
1e5b2471bcc483 Pablo Neira Ayuso 2019-08-09  197  	if (nf_flow_timeout_delta(ct->timeout) > (__s32)timeout)
da5984e51063a2 Felix Fietkau     2018-02-26  198  		ct->timeout = nfct_time_stamp + timeout;
da5984e51063a2 Felix Fietkau     2018-02-26  199  }
da5984e51063a2 Felix Fietkau     2018-02-26  200  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37641 bytes --]