From: Vladimir Oltean <olteanv@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ido Schimmel <idosch@idosch.org>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Marek Behun <kabel@blackhole.sk>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
bridge@lists.linux-foundation.org,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Roopa Prabhu <roopa@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Jiri Pirko <jiri@resnulli.us>, Vadym Kochan <vkochan@marvell.com>,
DENG Qingfang <dqfext@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
Taras Chornyi <tchornyi@marvell.com>,
Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [Bridge] [PATCH v4 net-next 10/15] net: bridge: switchdev object replay helpers for everybody
Date: Mon, 19 Jul 2021 11:19:08 +0300 [thread overview]
Message-ID: <20210719081908.qnxw7gjetwkubxz3@skbuf> (raw)
In-Reply-To: <20210718214434.3938850-11-vladimir.oltean@nxp.com>
On Mon, Jul 19, 2021 at 12:44:29AM +0300, Vladimir Oltean wrote:
> Note that:
> (c) I do not expect a lot of functional change introduced for drivers in
> this patch, because:
> - nbp_vlan_init() is called _after_ netdev_master_upper_dev_link(),
> so br_vlan_replay() should not do anything for the new drivers on
> which we call it. The existing drivers where there was even a
> slight possibility for there to exist a VLAN on a bridge port
> before they join it are already guarded against this: mlxsw and
> prestera deny joining LAG interfaces that are members of a bridge.
> - br_fdb_replay() should now notify of local FDB entries, but I
> patched all drivers except DSA to ignore these new entries in
> commit 2c4eca3ef716 ("net: bridge: switchdev: include local flag
> in FDB notifications"). Driver authors can lift this restriction
> as they wish.
> - br_mdb_replay() should now fix the issue described in commit
> 2c4eca3ef716 ("net: bridge: switchdev: include local flag in FDB
> notifications") for all drivers, I don't see any downside.
I really meant commit 4f2673b3a2b6 ("net: bridge: add helper to replay
port and host-joined mdb entries"), sorry for the copy-pasta mistake.
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <olteanv@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@idosch.org>,
Tobias Waldekranz <tobias@waldekranz.com>,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Stephen Hemminger <stephen@networkplumber.org>,
bridge@lists.linux-foundation.org,
Grygorii Strashko <grygorii.strashko@ti.com>,
Marek Behun <kabel@blackhole.sk>,
DENG Qingfang <dqfext@gmail.com>,
Vadym Kochan <vkochan@marvell.com>,
Taras Chornyi <tchornyi@marvell.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
UNGLinuxDriver@microchip.com,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v4 net-next 10/15] net: bridge: switchdev object replay helpers for everybody
Date: Mon, 19 Jul 2021 11:19:08 +0300 [thread overview]
Message-ID: <20210719081908.qnxw7gjetwkubxz3@skbuf> (raw)
In-Reply-To: <20210718214434.3938850-11-vladimir.oltean@nxp.com>
On Mon, Jul 19, 2021 at 12:44:29AM +0300, Vladimir Oltean wrote:
> Note that:
> (c) I do not expect a lot of functional change introduced for drivers in
> this patch, because:
> - nbp_vlan_init() is called _after_ netdev_master_upper_dev_link(),
> so br_vlan_replay() should not do anything for the new drivers on
> which we call it. The existing drivers where there was even a
> slight possibility for there to exist a VLAN on a bridge port
> before they join it are already guarded against this: mlxsw and
> prestera deny joining LAG interfaces that are members of a bridge.
> - br_fdb_replay() should now notify of local FDB entries, but I
> patched all drivers except DSA to ignore these new entries in
> commit 2c4eca3ef716 ("net: bridge: switchdev: include local flag
> in FDB notifications"). Driver authors can lift this restriction
> as they wish.
> - br_mdb_replay() should now fix the issue described in commit
> 2c4eca3ef716 ("net: bridge: switchdev: include local flag in FDB
> notifications") for all drivers, I don't see any downside.
I really meant commit 4f2673b3a2b6 ("net: bridge: add helper to replay
port and host-joined mdb entries"), sorry for the copy-pasta mistake.
next prev parent reply other threads:[~2021-07-19 8:19 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 21:44 [Bridge] [PATCH v4 net-next 00/15] Allow forwarding for the software bridge data path to be offloaded to capable devices Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 01/15] net: dpaa2-switch: use extack in dpaa2_switch_port_bridge_join Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 9:17 ` [Bridge] " Ioana Ciornei
2021-07-19 9:17 ` Ioana Ciornei
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 02/15] net: dpaa2-switch: refactor prechangeupper sanity checks Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 9:18 ` [Bridge] " Ioana Ciornei
2021-07-19 9:18 ` Ioana Ciornei
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 03/15] mlxsw: spectrum: " Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 04/15] mlxsw: spectrum: refactor leaving an 8021q upper that is a bridge port Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 2:16 ` [Bridge] " Florian Fainelli
2021-07-19 2:16 ` Florian Fainelli
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 05/15] net: marvell: prestera: refactor prechangeupper sanity checks Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 2:20 ` [Bridge] " Florian Fainelli
2021-07-19 2:20 ` Florian Fainelli
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 06/15] net: switchdev: guard drivers against multiple obj replays on same bridge port Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 2:17 ` [Bridge] " Florian Fainelli
2021-07-19 2:17 ` Florian Fainelli
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 07/15] net: bridge: disambiguate offload_fwd_mark Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 2:26 ` [Bridge] " Florian Fainelli
2021-07-19 2:26 ` Florian Fainelli
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 08/15] net: bridge: switchdev: recycle unused hwdoms Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 09/15] net: bridge: switchdev: let drivers inform which bridge ports are offloaded Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 9:23 ` [Bridge] " Ioana Ciornei
2021-07-19 9:23 ` Ioana Ciornei
2021-07-20 7:53 ` [Bridge] " Horatiu Vultur
2021-07-20 7:53 ` Horatiu Vultur
2021-07-20 8:45 ` [Bridge] " Vladimir Oltean
2021-07-20 8:45 ` Vladimir Oltean
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 10/15] net: bridge: switchdev object replay helpers for everybody Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 8:19 ` Vladimir Oltean [this message]
2021-07-19 8:19 ` Vladimir Oltean
2021-07-19 9:26 ` [Bridge] " Ioana Ciornei
2021-07-19 9:26 ` Ioana Ciornei
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 11/15] net: bridge: switchdev: allow the TX data plane forwarding to be offloaded Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 2:43 ` [Bridge] " Florian Fainelli
2021-07-19 2:43 ` Florian Fainelli
2021-07-19 7:22 ` [Bridge] " Vladimir Oltean
2021-07-19 7:22 ` Vladimir Oltean
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 12/15] net: dsa: track the number of switches in a tree Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 2:54 ` [Bridge] " Florian Fainelli
2021-07-19 2:54 ` Florian Fainelli
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 13/15] net: dsa: add support for bridge TX forwarding offload Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 2:51 ` [Bridge] " Florian Fainelli
2021-07-19 2:51 ` Florian Fainelli
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 14/15] net: dsa: mv88e6xxx: map virtual bridges with forwarding offload in the PVT Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 2:52 ` [Bridge] " Florian Fainelli
2021-07-19 2:52 ` Florian Fainelli
2021-07-18 21:44 ` [Bridge] [PATCH v4 net-next 15/15] net: dsa: tag_dsa: offload the bridge forwarding process Vladimir Oltean
2021-07-18 21:44 ` Vladimir Oltean
2021-07-19 2:47 ` [Bridge] " Florian Fainelli
2021-07-19 2:47 ` Florian Fainelli
2021-07-19 7:41 ` [Bridge] " Vladimir Oltean
2021-07-19 7:41 ` Vladimir Oltean
2021-07-20 11:24 ` [Bridge] [PATCH v4 net-next 00/15] Allow forwarding for the software bridge data path to be offloaded to capable devices Ido Schimmel
2021-07-20 11:24 ` Ido Schimmel
2021-07-20 13:20 ` [Bridge] " Vladimir Oltean
2021-07-20 13:20 ` Vladimir Oltean
2021-07-20 13:51 ` [Bridge] " Ido Schimmel
2021-07-20 13:51 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719081908.qnxw7gjetwkubxz3@skbuf \
--to=olteanv@gmail.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=idosch@idosch.org \
--cc=ioana.ciornei@nxp.com \
--cc=jiri@resnulli.us \
--cc=kabel@blackhole.sk \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
--cc=tchornyi@marvell.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
--cc=vkochan@marvell.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.