* [pci:review/vga 1/7] drivers/pci/vgaarb.c:1045:8: warning: %d in format string (no. 6) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
@ 2021-07-21 8:19 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-07-21 8:19 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 8379 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Bjorn Helgaas <helgaas@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git review/vga
head: b6f0a577c4fbcc4f1e7eaf0e9a30bcfd20002b44
commit: 4e5cfb7f1564325ed08a95271ecdca1f6709d106 [1/7] PCI/VGA: Move vgaarb to drivers/pci
:::::: branch date: 10 hours ago
:::::: commit date: 12 hours ago
compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck warnings: (new ones prefixed by >>)
>> drivers/pci/vgaarb.c:1045:8: warning: %d in format string (no. 6) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
len = snprintf(lbuf, 1024,
^
drivers/pci/vgaarb.c:1045:8: warning: %d in format string (no. 7) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
len = snprintf(lbuf, 1024,
^
vim +1045 drivers/pci/vgaarb.c
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1002
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1003 static ssize_t vga_arb_read(struct file *file, char __user *buf,
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1004 size_t count, loff_t *ppos)
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1005 {
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1006 struct vga_arb_private *priv = file->private_data;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1007 struct vga_device *vgadev;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1008 struct pci_dev *pdev;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1009 unsigned long flags;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1010 size_t len;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1011 int rc;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1012 char *lbuf;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1013
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1014 lbuf = kmalloc(1024, GFP_KERNEL);
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1015 if (lbuf == NULL)
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1016 return -ENOMEM;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1017
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1018 /* Shields against vga_arb_device_card_gone (pci_dev going
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1019 * away), and allows access to vga list
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1020 */
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1021 spin_lock_irqsave(&vga_lock, flags);
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1022
25985edcedea6396 drivers/gpu/vga/vgaarb.c Lucas De Marchi 2011-03-30 1023 /* If we are targeting the default, use it */
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1024 pdev = priv->target;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1025 if (pdev == NULL || pdev == PCI_INVALID_CARD) {
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1026 spin_unlock_irqrestore(&vga_lock, flags);
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1027 len = sprintf(lbuf, "invalid");
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1028 goto done;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1029 }
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1030
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1031 /* Find card vgadev structure */
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1032 vgadev = vgadev_find(pdev);
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1033 if (vgadev == NULL) {
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1034 /* Wow, it's not in the list, that shouldn't happen,
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1035 * let's fix us up and return invalid card
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1036 */
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1037 if (pdev == priv->target)
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1038 vga_arb_device_card_gone(pdev);
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1039 spin_unlock_irqrestore(&vga_lock, flags);
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1040 len = sprintf(lbuf, "invalid");
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1041 goto done;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1042 }
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1043
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1044 /* Fill the buffer with infos */
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 @1045 len = snprintf(lbuf, 1024,
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1046 "count:%d,PCI:%s,decodes=%s,owns=%s,locks=%s(%d:%d)\n",
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1047 vga_decode_count, pci_name(pdev),
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1048 vga_iostate_to_str(vgadev->decodes),
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1049 vga_iostate_to_str(vgadev->owns),
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1050 vga_iostate_to_str(vgadev->locks),
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1051 vgadev->io_lock_cnt, vgadev->mem_lock_cnt);
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1052
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1053 spin_unlock_irqrestore(&vga_lock, flags);
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1054 done:
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1055
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1056 /* Copy that to user */
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1057 if (len > count)
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1058 len = count;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1059 rc = copy_to_user(buf, lbuf, len);
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1060 kfree(lbuf);
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1061 if (rc)
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1062 return -EFAULT;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1063 return len;
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1064 }
deb2d2ecd43dfc51 drivers/gpu/vga/vgaarb.c Benjamin Herrenschmidt 2009-08-11 1065
:::::: The code at line 1045 was first introduced by commit
:::::: deb2d2ecd43dfc51efe71eed7128fda514da96c6 PCI/GPU: implement VGA arbitration on Linux
:::::: TO: Benjamin Herrenschmidt <benh@kernel.crashing.org>
:::::: CC: Jesse Barnes <jbarnes@virtuousgeek.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-07-21 8:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-21 8:19 [pci:review/vga 1/7] drivers/pci/vgaarb.c:1045:8: warning: %d in format string (no. 6) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.