All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Christoph Hellwig <hch@lst.de>,
	John Garry <john.garry@huawei.com>,
	Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
	Daniel Wagner <dwagner@suse.de>, Wen Xiong <wenxiong@us.ibm.com>,
	Hannes Reinecke <hare@suse.de>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH V4 1/3] driver core: mark device as irq affinity managed if any irq is managed
Date: Thu, 22 Jul 2021 09:46:15 +0200	[thread overview]
Message-ID: <20210722074615.GA2292@lst.de> (raw)
In-Reply-To: <878s1zpa28.ffs@nanos.tec.linutronix.de>

On Thu, Jul 22, 2021 at 12:38:07AM +0200, Thomas Gleixner wrote:
> That's fine because that's controlled by the driver consistently and it
> (hopefully) makes sure that the admin queue is quiesced before
> everything is torn down after the initial query.

Yes, it is.

> The above can be fixed by adding an 'append' mode to the MSI code.

So IFF we get that append mode I think it would help to simplify
drivers that have unmanaged pre and post vectors, and/or do the above
proving.

So instead of currently requesting a single unmanaged vector, do
basic setup, tear it down, request N managed vectors with an unmanaged
pre-vector we could just keep the unmanaged vector, never tear it down
and just append the post vectors.  In the long run this could remove
the need to do the pre and post vectors entirely.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Christoph Hellwig <hch@lst.de>,
	John Garry <john.garry@huawei.com>,
	Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
	Daniel Wagner <dwagner@suse.de>, Wen Xiong <wenxiong@us.ibm.com>,
	Hannes Reinecke <hare@suse.de>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH V4 1/3] driver core: mark device as irq affinity managed if any irq is managed
Date: Thu, 22 Jul 2021 09:46:15 +0200	[thread overview]
Message-ID: <20210722074615.GA2292@lst.de> (raw)
In-Reply-To: <878s1zpa28.ffs@nanos.tec.linutronix.de>

On Thu, Jul 22, 2021 at 12:38:07AM +0200, Thomas Gleixner wrote:
> That's fine because that's controlled by the driver consistently and it
> (hopefully) makes sure that the admin queue is quiesced before
> everything is torn down after the initial query.

Yes, it is.

> The above can be fixed by adding an 'append' mode to the MSI code.

So IFF we get that append mode I think it would help to simplify
drivers that have unmanaged pre and post vectors, and/or do the above
proving.

So instead of currently requesting a single unmanaged vector, do
basic setup, tear it down, request N managed vectors with an unmanaged
pre-vector we could just keep the unmanaged vector, never tear it down
and just append the post vectors.  In the long run this could remove
the need to do the pre and post vectors entirely.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-07-22  7:46 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15 12:08 [PATCH V4 0/3] blk-mq: fix blk_mq_alloc_request_hctx Ming Lei
2021-07-15 12:08 ` Ming Lei
2021-07-15 12:08 ` [PATCH V4 1/3] driver core: mark device as irq affinity managed if any irq is managed Ming Lei
2021-07-15 12:08   ` Ming Lei
2021-07-15 12:40   ` Greg Kroah-Hartman
2021-07-15 12:40     ` Greg Kroah-Hartman
2021-07-16  2:17     ` Ming Lei
2021-07-16  2:17       ` Ming Lei
2021-07-16 20:01   ` Bjorn Helgaas
2021-07-16 20:01     ` Bjorn Helgaas
2021-07-17  9:30     ` Ming Lei
2021-07-17  9:30       ` Ming Lei
2021-07-21  0:30       ` Bjorn Helgaas
2021-07-21  0:30         ` Bjorn Helgaas
2021-07-19  7:51   ` John Garry
2021-07-19  7:51     ` John Garry
2021-07-19  9:44     ` Christoph Hellwig
2021-07-19  9:44       ` Christoph Hellwig
2021-07-19 10:39       ` John Garry
2021-07-19 10:39         ` John Garry
2021-07-20  2:38         ` Ming Lei
2021-07-20  2:38           ` Ming Lei
2021-07-21  7:20       ` Thomas Gleixner
2021-07-21  7:20         ` Thomas Gleixner
2021-07-21  7:24         ` Christoph Hellwig
2021-07-21  7:24           ` Christoph Hellwig
2021-07-21  9:44           ` John Garry
2021-07-21  9:44             ` John Garry
2021-07-21 20:22             ` Thomas Gleixner
2021-07-21 20:22               ` Thomas Gleixner
2021-07-22  7:48               ` John Garry
2021-07-22  7:48                 ` John Garry
2021-07-21 20:14           ` Thomas Gleixner
2021-07-21 20:14             ` Thomas Gleixner
2021-07-21 20:32             ` Christoph Hellwig
2021-07-21 20:32               ` Christoph Hellwig
2021-07-21 22:38               ` Thomas Gleixner
2021-07-21 22:38                 ` Thomas Gleixner
2021-07-22  7:46                 ` Christoph Hellwig [this message]
2021-07-22  7:46                   ` Christoph Hellwig
2021-07-15 12:08 ` [PATCH V4 2/3] blk-mq: mark if one queue map uses managed irq Ming Lei
2021-07-15 12:08   ` Ming Lei
2021-07-15 12:08 ` [PATCH V4 3/3] blk-mq: don't deactivate hctx if managed irq isn't used Ming Lei
2021-07-15 12:08   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210722074615.GA2292@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=dwagner@suse.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hare@suse.de \
    --cc=john.garry@huawei.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=sagi@grimberg.me \
    --cc=tglx@linutronix.de \
    --cc=wenxiong@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.