From: <yang.yang29@zte.com.cn>
To: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] alpha: remove unneeded variable
Date: Mon, 2 Aug 2021 17:25:30 +0800 (CST) [thread overview]
Message-ID: <202107221858308514719@zte.com.cn> (raw)
From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
This is a warning in coccicheck. Unneeded variable "status".
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
arch/alpha/kernel/err_titan.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/alpha/kernel/err_titan.c b/arch/alpha/kernel/err_titan.c
index 0ffb2feea42a..85d91da86ec4 100644
--- a/arch/alpha/kernel/err_titan.c
+++ b/arch/alpha/kernel/err_titan.c
@@ -589,7 +589,6 @@ titan_register_error_handlers(void)
static int
privateer_process_680_frame(struct el_common *mchk_header, int print)
{
- int status = MCHK_DISPOSITION_UNKNOWN_ERROR;
#ifdef CONFIG_VERBOSE_MCHECK
struct el_PRIVATEER_envdata_mcheck *emchk =
(struct el_PRIVATEER_envdata_mcheck *)
@@ -598,7 +597,7 @@ privateer_process_680_frame(struct el_common *mchk_header, int print)
/* TODO - categorize errors, for now, no error */
if (!print)
- return status;
+ return MCHK_DISPOSITION_UNKNOWN_ERROR;
/* TODO - decode instead of just dumping... */
printk("%s Summary Flags: %016llx\n"
@@ -624,7 +623,7 @@ privateer_process_680_frame(struct el_common *mchk_header, int print)
emchk->code);
#endif /* CONFIG_VERBOSE_MCHECK */
- return status;
+ return MCHK_DISPOSITION_UNKNOWN_ERROR;
}
int
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: <yang.yang29@zte.com.cn>
To: <rth@twiddle.net>, <ink@jurassic.park.msu.ru>, <mattst88@gmail.com>
Cc: <linux-alpha@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] alpha: remove unneeded variable
Date: Mon, 2 Aug 2021 17:25:30 +0800 (CST) [thread overview]
Message-ID: <202107221858308514719@zte.com.cn> (raw)
From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
This is a warning in coccicheck. Unneeded variable "status".
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
arch/alpha/kernel/err_titan.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/alpha/kernel/err_titan.c b/arch/alpha/kernel/err_titan.c
index 0ffb2feea42a..85d91da86ec4 100644
--- a/arch/alpha/kernel/err_titan.c
+++ b/arch/alpha/kernel/err_titan.c
@@ -589,7 +589,6 @@ titan_register_error_handlers(void)
static int
privateer_process_680_frame(struct el_common *mchk_header, int print)
{
- int status = MCHK_DISPOSITION_UNKNOWN_ERROR;
#ifdef CONFIG_VERBOSE_MCHECK
struct el_PRIVATEER_envdata_mcheck *emchk =
(struct el_PRIVATEER_envdata_mcheck *)
@@ -598,7 +597,7 @@ privateer_process_680_frame(struct el_common *mchk_header, int print)
/* TODO - categorize errors, for now, no error */
if (!print)
- return status;
+ return MCHK_DISPOSITION_UNKNOWN_ERROR;
/* TODO - decode instead of just dumping... */
printk("%s Summary Flags: %016llx\n"
@@ -624,7 +623,7 @@ privateer_process_680_frame(struct el_common *mchk_header, int print)
emchk->code);
#endif /* CONFIG_VERBOSE_MCHECK */
- return status;
+ return MCHK_DISPOSITION_UNKNOWN_ERROR;
}
int
--
2.25.1
next reply other threads:[~2021-08-02 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 9:25 yang.yang29 [this message]
2021-08-02 9:25 ` [PATCH] alpha: remove unneeded variable yang.yang29
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107221858308514719@zte.com.cn \
--to=yang.yang29@zte.com.cn \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.