From: Christoph Hellwig <hch@lst.de>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: stable@vger.kernel.org, iommu@lists.linux-foundation.org,
Ricardo Ribalda <ribalda@chromium.org>,
kernel@collabora.com, Will Deacon <will@kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] iommu/dma: Fix leak in non-contiguous API
Date: Fri, 23 Jul 2021 07:09:02 +0200 [thread overview]
Message-ID: <20210723050902.GA31187@lst.de> (raw)
In-Reply-To: <20210723010552.50969-1-ezequiel@collabora.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
> As a side note, it appears the struct dma_sgt_handle type is exposed
> to users of the DMA-API by linux/dma-map-ops.h, but is has no users
> or functions returning the type explicitly.
>
> This may indicate it's a good idea to move the struct dma_sgt_handle type
> to drivers/iommu/dma-iommu.c. The decision is left to maintainers :-)
linux/dma-map-ops.h is a helper header for the dma_ops implementations,
not for users of the DMA API. sgt_handle, which references
dma_sgt_handle is used in kernel/dma/mapping.c
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: iommu@lists.linux-foundation.org, linux-media@vger.kernel.org,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Christoph Hellwig <hch@lst.de>, Tomasz Figa <tfiga@chromium.org>,
Ricardo Ribalda <ribalda@chromium.org>,
kernel@collabora.com, stable@vger.kernel.org
Subject: Re: [PATCH] iommu/dma: Fix leak in non-contiguous API
Date: Fri, 23 Jul 2021 07:09:02 +0200 [thread overview]
Message-ID: <20210723050902.GA31187@lst.de> (raw)
In-Reply-To: <20210723010552.50969-1-ezequiel@collabora.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
> As a side note, it appears the struct dma_sgt_handle type is exposed
> to users of the DMA-API by linux/dma-map-ops.h, but is has no users
> or functions returning the type explicitly.
>
> This may indicate it's a good idea to move the struct dma_sgt_handle type
> to drivers/iommu/dma-iommu.c. The decision is left to maintainers :-)
linux/dma-map-ops.h is a helper header for the dma_ops implementations,
not for users of the DMA API. sgt_handle, which references
dma_sgt_handle is used in kernel/dma/mapping.c
next prev parent reply other threads:[~2021-07-23 5:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 1:05 [PATCH] iommu/dma: Fix leak in non-contiguous API Ezequiel Garcia
2021-07-23 1:05 ` Ezequiel Garcia
2021-07-23 5:09 ` Christoph Hellwig [this message]
2021-07-23 5:09 ` Christoph Hellwig
2021-07-26 12:27 ` Joerg Roedel
2021-07-26 12:27 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723050902.GA31187@lst.de \
--to=hch@lst.de \
--cc=ezequiel@collabora.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel@collabora.com \
--cc=linux-media@vger.kernel.org \
--cc=ribalda@chromium.org \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.