All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Will Deacon <will@kernel.org>,
	Kirti Wankhede <kwankhede@nvidia.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Alex Williamson <alex.williamson@redhat.com>,
	Robin Murphy <robin.murphy@arm.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Christoph Hellwig <hch@lst.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/6] vfio: remove the unused mdev iommu hook
Date: Fri, 23 Jul 2021 07:41:06 +0200	[thread overview]
Message-ID: <20210723054106.GA31771@lst.de> (raw)
In-Reply-To: <BN9PR11MB5433440EED4E291C0DCD44BA8CE59@BN9PR11MB5433.namprd11.prod.outlook.com>

On Fri, Jul 23, 2021 at 05:36:17AM +0000, Tian, Kevin wrote:
> > > And a new set of IOMMU-API:
> > >
> > >     - iommu_{un}bind_pgtable(domain, dev, addr);
> > >     - iommu_{un}bind_pgtable_pasid(domain, dev, addr, pasid);
> > >     - iommu_cache_invalidate(domain, dev, invalid_info);
> > 
> > What caches is this supposed to "invalidate"?
> 
> pasid cache, iotlb or dev_iotlb entries that are related to the bound 
> pgtable. the actual affected cache type and granularity (device-wide,
> pasid-wide, selected addr-range) are specified by the caller.

Maybe call it pgtable_invalidate or similar?  To avoid confusing it
with the CPUs dcache.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Christoph Hellwig <hch@lst.de>, Joerg Roedel <joro@8bytes.org>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Alex Williamson <alex.williamson@redhat.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Will Deacon <will@kernel.org>,
	Kirti Wankhede <kwankhede@nvidia.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	 "iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH 3/6] vfio: remove the unused mdev iommu hook
Date: Fri, 23 Jul 2021 07:41:06 +0200	[thread overview]
Message-ID: <20210723054106.GA31771@lst.de> (raw)
In-Reply-To: <BN9PR11MB5433440EED4E291C0DCD44BA8CE59@BN9PR11MB5433.namprd11.prod.outlook.com>

On Fri, Jul 23, 2021 at 05:36:17AM +0000, Tian, Kevin wrote:
> > > And a new set of IOMMU-API:
> > >
> > >     - iommu_{un}bind_pgtable(domain, dev, addr);
> > >     - iommu_{un}bind_pgtable_pasid(domain, dev, addr, pasid);
> > >     - iommu_cache_invalidate(domain, dev, invalid_info);
> > 
> > What caches is this supposed to "invalidate"?
> 
> pasid cache, iotlb or dev_iotlb entries that are related to the bound 
> pgtable. the actual affected cache type and granularity (device-wide,
> pasid-wide, selected addr-range) are specified by the caller.

Maybe call it pgtable_invalidate or similar?  To avoid confusing it
with the CPUs dcache.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Christoph Hellwig <hch@lst.de>, Joerg Roedel <joro@8bytes.org>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Alex Williamson <alex.williamson@redhat.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Will Deacon <will@kernel.org>,
	Kirti Wankhede <kwankhede@nvidia.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH 3/6] vfio: remove the unused mdev iommu hook
Date: Fri, 23 Jul 2021 07:41:06 +0200	[thread overview]
Message-ID: <20210723054106.GA31771@lst.de> (raw)
In-Reply-To: <BN9PR11MB5433440EED4E291C0DCD44BA8CE59@BN9PR11MB5433.namprd11.prod.outlook.com>

On Fri, Jul 23, 2021 at 05:36:17AM +0000, Tian, Kevin wrote:
> > > And a new set of IOMMU-API:
> > >
> > >     - iommu_{un}bind_pgtable(domain, dev, addr);
> > >     - iommu_{un}bind_pgtable_pasid(domain, dev, addr, pasid);
> > >     - iommu_cache_invalidate(domain, dev, invalid_info);
> > 
> > What caches is this supposed to "invalidate"?
> 
> pasid cache, iotlb or dev_iotlb entries that are related to the bound 
> pgtable. the actual affected cache type and granularity (device-wide,
> pasid-wide, selected addr-range) are specified by the caller.

Maybe call it pgtable_invalidate or similar?  To avoid confusing it
with the CPUs dcache.

  reply	other threads:[~2021-07-23  5:41 UTC|newest]

Thread overview: 118+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10  6:53 more iommu dead code removal Christoph Hellwig
2021-05-10  6:53 ` Christoph Hellwig
2021-05-10  6:53 ` Christoph Hellwig
2021-05-10  6:54 ` [PATCH 1/6] iommu: remove the unused dev_has_feat method Christoph Hellwig
2021-05-10  6:54   ` Christoph Hellwig
2021-05-10  6:54   ` Christoph Hellwig
2021-05-10  6:54 ` [PATCH 2/6] iommu: remove the unused iommu_aux_get_pasid interface Christoph Hellwig
2021-05-10  6:54   ` Christoph Hellwig
2021-05-10  6:54   ` Christoph Hellwig
2021-05-10  6:54 ` [PATCH 3/6] vfio: remove the unused mdev iommu hook Christoph Hellwig
2021-05-10  6:54   ` Christoph Hellwig
2021-05-10  6:54   ` Christoph Hellwig
2021-05-10 15:54   ` Jason Gunthorpe
2021-05-10 15:54     ` Jason Gunthorpe
2021-05-10 15:54     ` Jason Gunthorpe
2021-05-13  3:28     ` Tian, Kevin
2021-05-13  3:28       ` Tian, Kevin
2021-05-13  3:28       ` Tian, Kevin
2021-05-13 12:00       ` Jason Gunthorpe
2021-05-13 12:00         ` Jason Gunthorpe
2021-05-13 12:00         ` Jason Gunthorpe
2021-05-14  6:27         ` Tian, Kevin
2021-05-14  6:27           ` Tian, Kevin
2021-05-14  6:27           ` Tian, Kevin
2021-05-14  6:54         ` Tian, Kevin
2021-05-14  6:54           ` Tian, Kevin
2021-05-14  6:54           ` Tian, Kevin
2021-05-14 12:19           ` Jason Gunthorpe
2021-05-14 12:19             ` Jason Gunthorpe
2021-05-14 12:19             ` Jason Gunthorpe
2021-05-14 12:58             ` Tian, Kevin
2021-05-14 12:58               ` Tian, Kevin
2021-05-14 12:58               ` Tian, Kevin
2021-05-14 13:31               ` Jason Gunthorpe
2021-05-14 13:31                 ` Jason Gunthorpe
2021-05-14 13:31                 ` Jason Gunthorpe
2021-05-17 12:22                 ` Joerg Roedel
2021-05-17 12:22                   ` Joerg Roedel
2021-05-17 12:22                   ` Joerg Roedel
2021-05-17 12:30                   ` Jason Gunthorpe
2021-05-17 12:30                     ` Jason Gunthorpe
2021-05-17 12:30                     ` Jason Gunthorpe
2021-05-17 12:53                     ` Joerg Roedel
2021-05-17 12:53                       ` Joerg Roedel
2021-05-17 12:53                       ` Joerg Roedel
2021-05-17 13:35                       ` Jason Gunthorpe
2021-05-17 13:35                         ` Jason Gunthorpe
2021-05-17 13:35                         ` Jason Gunthorpe
2021-05-17 15:35                         ` Joerg Roedel
2021-05-17 15:35                           ` Joerg Roedel
2021-05-17 15:35                           ` Joerg Roedel
2021-05-19 15:23                           ` Robin Murphy
2021-05-19 15:23                             ` Robin Murphy
2021-05-19 15:23                             ` Robin Murphy
2021-05-19 18:06                             ` Jason Gunthorpe
2021-05-19 18:06                               ` Jason Gunthorpe
2021-05-19 18:06                               ` Jason Gunthorpe
2021-05-19 23:12                               ` Tian, Kevin
2021-05-19 23:12                                 ` Tian, Kevin
2021-05-19 23:12                                 ` Tian, Kevin
2021-05-19 23:24                                 ` Jason Gunthorpe
2021-05-19 23:24                                   ` Jason Gunthorpe
2021-05-19 23:24                                   ` Jason Gunthorpe
2021-05-20 14:13                                   ` Robin Murphy
2021-05-20 14:13                                     ` Robin Murphy
2021-05-20 14:13                                     ` Robin Murphy
2021-05-20 14:34                                     ` Jason Gunthorpe
2021-05-20 14:34                                       ` Jason Gunthorpe
2021-05-20 14:34                                       ` Jason Gunthorpe
2021-05-24 18:18                                       ` Robin Murphy
2021-05-24 18:18                                         ` Robin Murphy
2021-05-24 18:18                                         ` Robin Murphy
2021-05-25  0:00                                         ` Jason Gunthorpe
2021-05-25  0:00                                           ` Jason Gunthorpe
2021-05-25  0:00                                           ` Jason Gunthorpe
2021-06-30  9:08                           ` Tian, Kevin
2021-06-30  9:08                             ` Tian, Kevin
2021-06-30  9:08                             ` Tian, Kevin
2021-07-22 13:34                             ` Christoph Hellwig
2021-07-22 13:34                               ` Christoph Hellwig
2021-07-22 13:34                               ` Christoph Hellwig
2021-07-23  5:36                               ` Tian, Kevin
2021-07-23  5:36                                 ` Tian, Kevin
2021-07-23  5:36                                 ` Tian, Kevin
2021-07-23  5:41                                 ` Christoph Hellwig [this message]
2021-07-23  5:41                                   ` Christoph Hellwig
2021-07-23  5:41                                   ` Christoph Hellwig
2021-07-23  5:44                                   ` Tian, Kevin
2021-07-23  5:44                                     ` Tian, Kevin
2021-07-23  5:44                                     ` Tian, Kevin
2021-07-22  6:02                           ` Tian, Kevin
2021-07-22  6:02                             ` Tian, Kevin
2021-07-22  6:02                             ` Tian, Kevin
2021-05-14 13:17         ` Tian, Kevin
2021-05-14 13:17           ` Tian, Kevin
2021-05-14 13:17           ` Tian, Kevin
2021-05-14 13:39           ` Jason Gunthorpe
2021-05-14 13:39             ` Jason Gunthorpe
2021-05-14 13:39             ` Jason Gunthorpe
2021-05-14 14:08             ` Liu Yi L
2021-05-14 14:28             ` Tian, Kevin
2021-05-14 14:28               ` Tian, Kevin
2021-05-14 14:28               ` Tian, Kevin
2021-05-14 14:44               ` Jason Gunthorpe
2021-05-14 14:44                 ` Jason Gunthorpe
2021-05-14 14:44                 ` Jason Gunthorpe
2021-05-10  6:54 ` [PATCH 4/6] iommu: remove iommu_aux_{attach,detach}_device Christoph Hellwig
2021-05-10  6:54   ` Christoph Hellwig
2021-05-10  6:54   ` Christoph Hellwig
2021-05-10  6:54 ` [PATCH 5/6] iommu: remove IOMMU_DEV_FEAT_AUX Christoph Hellwig
2021-05-10  6:54   ` Christoph Hellwig
2021-05-10  6:54   ` Christoph Hellwig
2021-05-10  6:54 ` [PATCH 6/6] iommu: remove iommu_dev_feature_enabled Christoph Hellwig
2021-05-10  6:54   ` Christoph Hellwig
2021-05-10  6:54   ` Christoph Hellwig
2021-05-10 11:54 ` more iommu dead code removal Jason Gunthorpe
2021-05-10 11:54   ` Jason Gunthorpe
2021-05-10 11:54   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723054106.GA31771@lst.de \
    --to=hch@lst.de \
    --cc=alex.williamson@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jgg@ziepe.ca \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwankhede@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.