All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Mathew McBride <matt@traverse.com.au>
Cc: Li Yang <leoyang.li@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: ls1088a: add missing PMU node
Date: Fri, 23 Jul 2021 16:36:41 +0800	[thread overview]
Message-ID: <20210723083640.GJ30773@dragon> (raw)
In-Reply-To: <20210722042450.11862-3-matt@traverse.com.au>

On Thu, Jul 22, 2021 at 04:24:47AM +0000, Mathew McBride wrote:
> The Performance Manager Unit was not described in the DTS
> which meant performance event monitoring was not possible.
> 
> This was exposed by a change to the PMU handling in KVM
> in 5.11-rc3 which now prevents a PMU being exposed to a
> guest when the host does not provide one:
> "KVM: arm64: Don't access PMCR_EL0 when no PMU is available"
> 
> Signed-off-by: Mathew McBride <matt@traverse.com.au>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 79ceadc9dc4a..752c7f41e6b1 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -189,6 +189,11 @@ timer {
>  			     <1 10 IRQ_TYPE_LEVEL_LOW>;/* Hypervisor PPI */
>  	};
>  
> +	pmu {
> +		compatible = "arm,armv8-pmuv3";
> +		interrupts = <1 7 0x8>; /* PMU PPI, Level low type */

Use define GIC_PPI and IRQ_TYPE_LEVEL_LOW, so that you can drop the
comment.

Shawn

> +	};
> +
>  	psci {
>  		compatible = "arm,psci-0.2";
>  		method = "smc";
> -- 
> 2.30.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Mathew McBride <matt@traverse.com.au>
Cc: Li Yang <leoyang.li@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: ls1088a: add missing PMU node
Date: Fri, 23 Jul 2021 16:36:41 +0800	[thread overview]
Message-ID: <20210723083640.GJ30773@dragon> (raw)
In-Reply-To: <20210722042450.11862-3-matt@traverse.com.au>

On Thu, Jul 22, 2021 at 04:24:47AM +0000, Mathew McBride wrote:
> The Performance Manager Unit was not described in the DTS
> which meant performance event monitoring was not possible.
> 
> This was exposed by a change to the PMU handling in KVM
> in 5.11-rc3 which now prevents a PMU being exposed to a
> guest when the host does not provide one:
> "KVM: arm64: Don't access PMCR_EL0 when no PMU is available"
> 
> Signed-off-by: Mathew McBride <matt@traverse.com.au>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 79ceadc9dc4a..752c7f41e6b1 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -189,6 +189,11 @@ timer {
>  			     <1 10 IRQ_TYPE_LEVEL_LOW>;/* Hypervisor PPI */
>  	};
>  
> +	pmu {
> +		compatible = "arm,armv8-pmuv3";
> +		interrupts = <1 7 0x8>; /* PMU PPI, Level low type */

Use define GIC_PPI and IRQ_TYPE_LEVEL_LOW, so that you can drop the
comment.

Shawn

> +	};
> +
>  	psci {
>  		compatible = "arm,psci-0.2";
>  		method = "smc";
> -- 
> 2.30.1
> 

  reply	other threads:[~2021-07-23  8:38 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  4:24 [PATCH 0/5] Add Traverse Technologies Ten64 board DTS Mathew McBride
2021-07-22  4:24 ` Mathew McBride
2021-07-22  4:24 ` [PATCH 1/5] arm64: dts: ls1088a: add internal PCS for DPMAC1 node Mathew McBride
2021-07-22  4:24   ` Mathew McBride
2021-07-22  7:48   ` Ioana Ciornei
2021-07-22  7:48     ` Ioana Ciornei
2021-07-22  4:24 ` [PATCH 2/5] arm64: dts: ls1088a: add missing PMU node Mathew McBride
2021-07-22  4:24   ` Mathew McBride
2021-07-23  8:36   ` Shawn Guo [this message]
2021-07-23  8:36     ` Shawn Guo
2021-07-22  4:24 ` [PATCH 3/5] dt-bindings: vendor-prefixes: add Traverse Technologies Mathew McBride
2021-07-22  4:24   ` Mathew McBride
2021-07-22  4:24 ` [PATCH 4/5] dt-bindings: arm: fsl: Add Traverse Ten64 (LS1088A) board Mathew McBride
2021-07-22  4:24   ` Mathew McBride
2021-07-22  4:24 ` [PATCH 5/5] arm64: dts: add device tree for Traverse Ten64 (LS1088A) Mathew McBride
2021-07-22  4:24   ` Mathew McBride
2021-07-22  8:44   ` Ioana Ciornei
2021-07-22  8:44     ` Ioana Ciornei
2021-07-23  9:46   ` Shawn Guo
2021-07-23  9:46     ` Shawn Guo
2021-07-26  7:12 ` [PATCH v2 0/5] Add Traverse Technologies Ten64 board DTS Mathew McBride
2021-07-26  7:12   ` Mathew McBride
2021-07-26  7:12   ` [PATCH v2 1/5] arm64: dts: ls1088a: add internal PCS for DPMAC1 node Mathew McBride
2021-07-26  7:12     ` Mathew McBride
2021-07-26  7:12   ` [PATCH v2 2/5] arm64: dts: ls1088a: add missing PMU node Mathew McBride
2021-07-26  7:12     ` Mathew McBride
2021-07-26  7:12   ` [PATCH v2 3/5] dt-bindings: vendor-prefixes: add Traverse Technologies Mathew McBride
2021-07-26  7:12     ` Mathew McBride
2021-07-29 22:41     ` Rob Herring
2021-07-29 22:41       ` Rob Herring
2021-07-26  7:12   ` [PATCH v2 4/5] dt-bindings: arm: fsl: Add Traverse Ten64 (LS1088A) board Mathew McBride
2021-07-26  7:12     ` Mathew McBride
2021-07-29 22:45     ` Rob Herring
2021-07-29 22:45       ` Rob Herring
2021-07-26  7:12   ` [PATCH v2 5/5] arm64: dts: add device tree for Traverse Ten64 (LS1088A) Mathew McBride
2021-07-26  7:12     ` Mathew McBride
2021-07-29 22:45     ` Rob Herring
2021-07-29 22:45       ` Rob Herring
2021-08-10  5:38 ` [PATCH v3 0/5] Add Traverse Technologies Ten64 board DTS Mathew McBride
2021-08-10  5:38   ` Mathew McBride
2021-08-10  5:38   ` [PATCH v3 1/5] arm64: dts: ls1088a: add internal PCS for DPMAC1 node Mathew McBride
2021-08-10  5:38     ` Mathew McBride
2021-08-10  5:38   ` [PATCH v3 2/5] arm64: dts: ls1088a: add missing PMU node Mathew McBride
2021-08-10  5:38     ` Mathew McBride
2021-08-10  5:38   ` [PATCH v3 3/5] dt-bindings: vendor-prefixes: add Traverse Technologies Mathew McBride
2021-08-10  5:38     ` Mathew McBride
2021-08-10  5:38   ` [PATCH v3 4/5] dt-bindings: arm: fsl: Add Traverse Ten64 (LS1088A) board Mathew McBride
2021-08-10  5:38     ` Mathew McBride
2021-08-10  5:38   ` [PATCH v3 5/5] arm64: dts: add device tree for Traverse Ten64 (LS1088A) Mathew McBride
2021-08-10  5:38     ` Mathew McBride

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723083640.GJ30773@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ioana.ciornei@nxp.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=matt@traverse.com.au \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.