All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Wiklander <jens.wiklander@linaro.org>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH v3 2/5] optee: simplify optee_release()
Date: Thu, 29 Jul 2021 08:43:59 +0200	[thread overview]
Message-ID: <20210729064359.GA3316601@jade> (raw)
In-Reply-To: < <CAFA6WYOJ6At7p21UuWNp8k4=Qwcb_2VFuV78Z9hksyW76p-fKA@mail.gmail.com>>

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

On Wed, Jul 28, 2021 at 02:15:47PM +0530, Sumit Garg wrote:
> On Thu, 22 Jul 2021 at 17:48, Jens Wiklander <jens.wiklander@linaro.org> wrote:
> >
> > Simplifies optee_release() with a new helper function,
> > optee_close_session_helper() which has been factored out from
> > optee_close_session().
> >
> 
> Simplification looks good to me.
> 
> > A separate optee_release_supp() is added for the supplicant device.
> >
> 
> On similar terms, can we have separate optee_open_supp() for better
> understanding?

I'm not so keen on that. It wouldn't be much of a simplification since
we'd end up adding quite a few functions. optee_smc_open_supp(),
optee_ffa_open_supp(), optee_open_common(), and finally
optee_open_supp().

Thanks,
Jens

WARNING: multiple messages have this Message-ID (diff)
From: Jens Wiklander <jens.wiklander@linaro.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	OP-TEE TrustedFirmware <op-tee@lists.trustedfirmware.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Marc Bonnici <marc.bonnici@arm.com>,
	Jerome Forissier <jerome@forissier.org>,
	Sughosh Ganu <sughosh.ganu@linaro.org>
Subject: Re: [PATCH v3 2/5] optee: simplify optee_release()
Date: Thu, 29 Jul 2021 08:43:59 +0200	[thread overview]
Message-ID: <20210729064359.GA3316601@jade> (raw)
In-Reply-To: <CAFA6WYOJ6At7p21UuWNp8k4=Qwcb_2VFuV78Z9hksyW76p-fKA@mail.gmail.com>

On Wed, Jul 28, 2021 at 02:15:47PM +0530, Sumit Garg wrote:
> On Thu, 22 Jul 2021 at 17:48, Jens Wiklander <jens.wiklander@linaro.org> wrote:
> >
> > Simplifies optee_release() with a new helper function,
> > optee_close_session_helper() which has been factored out from
> > optee_close_session().
> >
> 
> Simplification looks good to me.
> 
> > A separate optee_release_supp() is added for the supplicant device.
> >
> 
> On similar terms, can we have separate optee_open_supp() for better
> understanding?

I'm not so keen on that. It wouldn't be much of a simplification since
we'd end up adding quite a few functions. optee_smc_open_supp(),
optee_ffa_open_supp(), optee_open_common(), and finally
optee_open_supp().

Thanks,
Jens

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Jens Wiklander <jens.wiklander@linaro.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	OP-TEE TrustedFirmware <op-tee@lists.trustedfirmware.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Marc Bonnici <marc.bonnici@arm.com>,
	Jerome Forissier <jerome@forissier.org>,
	Sughosh Ganu <sughosh.ganu@linaro.org>
Subject: Re: [PATCH v3 2/5] optee: simplify optee_release()
Date: Thu, 29 Jul 2021 08:43:59 +0200	[thread overview]
Message-ID: <20210729064359.GA3316601@jade> (raw)
In-Reply-To: <CAFA6WYOJ6At7p21UuWNp8k4=Qwcb_2VFuV78Z9hksyW76p-fKA@mail.gmail.com>

On Wed, Jul 28, 2021 at 02:15:47PM +0530, Sumit Garg wrote:
> On Thu, 22 Jul 2021 at 17:48, Jens Wiklander <jens.wiklander@linaro.org> wrote:
> >
> > Simplifies optee_release() with a new helper function,
> > optee_close_session_helper() which has been factored out from
> > optee_close_session().
> >
> 
> Simplification looks good to me.
> 
> > A separate optee_release_supp() is added for the supplicant device.
> >
> 
> On similar terms, can we have separate optee_open_supp() for better
> understanding?

I'm not so keen on that. It wouldn't be much of a simplification since
we'd end up adding quite a few functions. optee_smc_open_supp(),
optee_ffa_open_supp(), optee_open_common(), and finally
optee_open_supp().

Thanks,
Jens

       reply	other threads:[~2021-07-29  6:43 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] < <CAFA6WYOJ6At7p21UuWNp8k4=Qwcb_2VFuV78Z9hksyW76p-fKA@mail.gmail.com>
2021-07-29  6:43 ` Jens Wiklander [this message]
2021-07-29  6:43   ` [PATCH v3 2/5] optee: simplify optee_release() Jens Wiklander
2021-07-29  6:43   ` Jens Wiklander
2021-07-29  7:10   ` Sumit Garg
2021-07-29  7:10     ` Sumit Garg
2021-07-29  7:10     ` Sumit Garg
     [not found] < <CAFA6WYPmHF-SLGV50phb2qY92+L2qo3zcAsBjGGFCSwyPP_g4A@mail.gmail.com>
2021-07-29  7:10 ` [PATCH v3 4/5] optee: isolate smc abi Jens Wiklander
2021-07-29  7:10   ` Jens Wiklander
2021-07-29  7:10   ` Jens Wiklander
     [not found] < <CAFA6WYMbOO6N2OSieeWitvti0bvOndLDWyc=yPrrC7cm4GLpPQ@mail.gmail.com>
2021-07-29  6:56 ` [PATCH v3 3/5] optee: refactor driver with internal callbacks Jens Wiklander
2021-07-29  6:56   ` Jens Wiklander
2021-07-29  6:56   ` Jens Wiklander
2021-07-29  7:15   ` Sumit Garg
2021-07-29  7:15     ` Sumit Garg
2021-07-29  7:15     ` Sumit Garg
     [not found] < <CAHUa44EsbWX9QBQ5Y=E_pZa2qKnU5FibzjoGjgO98kq35psaLg@mail.gmail.com>
2021-07-28 10:22 ` [PATCH v3 0/5] Add FF-A support in OP-TEE driver Sumit Garg
2021-07-28 10:22   ` Sumit Garg
2021-07-28 10:22   ` Sumit Garg
     [not found] < <CAFA6WYPZHuEoaxo=05qfbNQ_gamPuMA4+=2giC88DK=RkMLgOg@mail.gmail.com>
2021-07-28  6:40 ` Jens Wiklander
2021-07-28  6:40   ` Jens Wiklander
2021-07-28  6:40   ` Jens Wiklander
     [not found] < <CAHUa44Guj5bu_tYsyLDzMJ==mtL+SaKT_vEG8Nz2VGcPuOx25g@mail.gmail.com>
2021-07-27  6:13 ` Sumit Garg
2021-07-27  6:13   ` Sumit Garg
2021-07-27  6:13   ` Sumit Garg
     [not found] < <CAFA6WYPJChHggVyeQKe9vi8fHpN-Ddq6Bf7DHe2ZpG9BUmvFMw@mail.gmail.com>
2021-07-26 15:25 ` Jens Wiklander
2021-07-26 15:25   ` Jens Wiklander
2021-07-26 15:25   ` Jens Wiklander
     [not found] < <CAFA6WYMgWizZoJmk7U0g8zP7Jf_SHLXi3ydMCg2iH5HEQmF=zw@mail.gmail.com>
2021-07-26 10:54 ` Sudeep Holla
2021-07-26 10:54   ` Sudeep Holla
2021-07-26 10:54   ` Sudeep Holla
2021-07-26 11:41   ` Sumit Garg
2021-07-26 11:41     ` Sumit Garg
2021-07-26 11:41     ` Sumit Garg
2021-07-22 12:17 Jens Wiklander
2021-07-22 12:17 ` Jens Wiklander
2021-07-22 12:17 ` Jens Wiklander
2021-07-22 12:17 ` [PATCH v3 1/5] tee: add sec_world_id to struct tee_shm Jens Wiklander
2021-07-22 12:17   ` Jens Wiklander
2021-07-22 12:17   ` Jens Wiklander
2021-07-28  8:41   ` Sumit Garg
2021-07-28  8:41     ` Sumit Garg
2021-07-28  8:41     ` Sumit Garg
2021-07-22 12:17 ` [PATCH v3 2/5] optee: simplify optee_release() Jens Wiklander
2021-07-22 12:17   ` Jens Wiklander
2021-07-22 12:17   ` Jens Wiklander
2021-07-28  8:45   ` Sumit Garg
2021-07-28  8:45     ` Sumit Garg
2021-07-28  8:45     ` Sumit Garg
2021-07-22 12:17 ` [PATCH v3 3/5] optee: refactor driver with internal callbacks Jens Wiklander
2021-07-22 12:17   ` Jens Wiklander
2021-07-22 12:17   ` Jens Wiklander
2021-07-28  9:59   ` Sumit Garg
2021-07-28  9:59     ` Sumit Garg
2021-07-28  9:59     ` Sumit Garg
2021-07-22 12:17 ` [PATCH v3 4/5] optee: isolate smc abi Jens Wiklander
2021-07-22 12:17   ` Jens Wiklander
2021-07-22 12:17   ` Jens Wiklander
2021-07-28 10:10   ` Sumit Garg
2021-07-28 10:10     ` Sumit Garg
2021-07-22 12:17 ` [PATCH v3 5/5] optee: add FF-A support Jens Wiklander
2021-07-22 12:17   ` Jens Wiklander
2021-07-22 12:17   ` Jens Wiklander
2021-07-26 10:29 ` [PATCH v3 0/5] Add FF-A support in OP-TEE driver Sumit Garg
2021-07-26 10:29   ` Sumit Garg
2021-07-26 10:29   ` Sumit Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210729064359.GA3316601@jade \
    --to=jens.wiklander@linaro.org \
    --cc=op-tee@lists.trustedfirmware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.