All of lore.kernel.org
 help / color / mirror / Atom feed
From: DENG Qingfang <dqfext@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Sean Wang <sean.wang@mediatek.com>,
	Landen Chao <Landen.Chao@mediatek.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	netdev <netdev@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC net-next 2/2] net: dsa: mt7530: trap packets from standalone ports to the CPU
Date: Sat, 31 Jul 2021 01:51:39 +0800	[thread overview]
Message-ID: <20210730175139.518992-1-dqfext@gmail.com> (raw)
In-Reply-To: <20210730173511.ulsv7wfogk5cpx5j@skbuf>

On Fri, Jul 30, 2021 at 08:35:11PM +0300, Vladimir Oltean wrote:
> On Sat, Jul 31, 2021 at 01:21:14AM +0800, DENG Qingfang wrote:
> > I just found a cleaner solution: Leaving standalone ports in port matrix
> > mode. As all bridges use independent VLAN learning, standalone ports'
> > FDB lookup with FID 0 won't hit.
> 
> So standalone ports are completely VLAN-unaware and always use a FID of
> 0, ports under a VLAN-unaware bridge are in fallback mode (look up the
> VLAN table but don't drop on miss), use a FID of 1-7, and ports under a
> VLAN-aware bridge are in the security mode and use the CVID instead of
> the FID for VLAN classification?

No. Both VLAN-unaware and VLAN-aware bridges use independent VLAN learning
i.e. use CVID for FDB lookup.

> 
> Make sure to test a mix of standalone, VLAN-unaware bridge and
> VLAN-aware bridge with the same MAC address in all 3 domains. If that
> works well this should be really good.

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: DENG Qingfang <dqfext@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Sean Wang <sean.wang@mediatek.com>,
	Landen Chao <Landen.Chao@mediatek.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	netdev <netdev@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC net-next 2/2] net: dsa: mt7530: trap packets from standalone ports to the CPU
Date: Sat, 31 Jul 2021 01:51:39 +0800	[thread overview]
Message-ID: <20210730175139.518992-1-dqfext@gmail.com> (raw)
In-Reply-To: <20210730173511.ulsv7wfogk5cpx5j@skbuf>

On Fri, Jul 30, 2021 at 08:35:11PM +0300, Vladimir Oltean wrote:
> On Sat, Jul 31, 2021 at 01:21:14AM +0800, DENG Qingfang wrote:
> > I just found a cleaner solution: Leaving standalone ports in port matrix
> > mode. As all bridges use independent VLAN learning, standalone ports'
> > FDB lookup with FID 0 won't hit.
> 
> So standalone ports are completely VLAN-unaware and always use a FID of
> 0, ports under a VLAN-unaware bridge are in fallback mode (look up the
> VLAN table but don't drop on miss), use a FID of 1-7, and ports under a
> VLAN-aware bridge are in the security mode and use the CVID instead of
> the FID for VLAN classification?

No. Both VLAN-unaware and VLAN-aware bridges use independent VLAN learning
i.e. use CVID for FDB lookup.

> 
> Make sure to test a mix of standalone, VLAN-unaware bridge and
> VLAN-aware bridge with the same MAC address in all 3 domains. If that
> works well this should be really good.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: DENG Qingfang <dqfext@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Sean Wang <sean.wang@mediatek.com>,
	Landen Chao <Landen.Chao@mediatek.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	netdev <netdev@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC net-next 2/2] net: dsa: mt7530: trap packets from standalone ports to the CPU
Date: Sat, 31 Jul 2021 01:51:39 +0800	[thread overview]
Message-ID: <20210730175139.518992-1-dqfext@gmail.com> (raw)
In-Reply-To: <20210730173511.ulsv7wfogk5cpx5j@skbuf>

On Fri, Jul 30, 2021 at 08:35:11PM +0300, Vladimir Oltean wrote:
> On Sat, Jul 31, 2021 at 01:21:14AM +0800, DENG Qingfang wrote:
> > I just found a cleaner solution: Leaving standalone ports in port matrix
> > mode. As all bridges use independent VLAN learning, standalone ports'
> > FDB lookup with FID 0 won't hit.
> 
> So standalone ports are completely VLAN-unaware and always use a FID of
> 0, ports under a VLAN-unaware bridge are in fallback mode (look up the
> VLAN table but don't drop on miss), use a FID of 1-7, and ports under a
> VLAN-aware bridge are in the security mode and use the CVID instead of
> the FID for VLAN classification?

No. Both VLAN-unaware and VLAN-aware bridges use independent VLAN learning
i.e. use CVID for FDB lookup.

> 
> Make sure to test a mix of standalone, VLAN-unaware bridge and
> VLAN-aware bridge with the same MAC address in all 3 domains. If that
> works well this should be really good.

  reply	other threads:[~2021-07-30 17:52 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 17:53 [RFC net-next 0/2] mt7530 software fallback bridging fix DENG Qingfang
2021-07-28 17:53 ` DENG Qingfang
2021-07-28 17:53 ` DENG Qingfang
2021-07-28 17:53 ` [RFC net-next 1/2] net: dsa: tag_mtk: skip address learning on transmit to standalone ports DENG Qingfang
2021-07-28 17:53   ` DENG Qingfang
2021-07-28 17:53   ` DENG Qingfang
2021-07-28 18:37   ` Vladimir Oltean
2021-07-28 18:37     ` Vladimir Oltean
2021-07-28 18:37     ` Vladimir Oltean
2021-07-30 16:24     ` Vladimir Oltean
2021-07-30 16:24       ` Vladimir Oltean
2021-07-30 16:24       ` Vladimir Oltean
2021-07-30 17:32       ` DENG Qingfang
2021-07-30 17:32         ` DENG Qingfang
2021-07-30 17:32         ` DENG Qingfang
2021-07-30 17:39         ` Vladimir Oltean
2021-07-30 17:39           ` Vladimir Oltean
2021-07-30 17:39           ` Vladimir Oltean
2021-07-30 17:41           ` Vladimir Oltean
2021-07-30 17:41             ` Vladimir Oltean
2021-07-30 17:41             ` Vladimir Oltean
2021-07-30 17:58             ` DENG Qingfang
2021-07-30 17:58               ` DENG Qingfang
2021-07-30 17:58               ` DENG Qingfang
2021-07-30 19:00       ` DENG Qingfang
2021-07-30 19:00         ` DENG Qingfang
2021-07-30 19:00         ` DENG Qingfang
2021-07-30 19:07         ` Vladimir Oltean
2021-07-30 19:07           ` Vladimir Oltean
2021-07-30 19:07           ` Vladimir Oltean
2021-07-30 19:25           ` DENG Qingfang
2021-07-30 19:25             ` DENG Qingfang
2021-07-30 19:25             ` DENG Qingfang
2021-07-30 19:30             ` Vladimir Oltean
2021-07-30 19:30               ` Vladimir Oltean
2021-07-30 19:30               ` Vladimir Oltean
2021-07-28 17:53 ` [RFC net-next 2/2] net: dsa: mt7530: trap packets from standalone ports to the CPU DENG Qingfang
2021-07-28 17:53   ` DENG Qingfang
2021-07-28 17:53   ` DENG Qingfang
2021-07-28 18:47   ` Vladimir Oltean
2021-07-28 18:47     ` Vladimir Oltean
2021-07-28 18:47     ` Vladimir Oltean
2021-07-29 15:28   ` Vladimir Oltean
2021-07-29 15:28     ` Vladimir Oltean
2021-07-29 15:28     ` Vladimir Oltean
2021-07-29 16:11     ` DENG Qingfang
2021-07-29 16:11       ` DENG Qingfang
2021-07-29 16:11       ` DENG Qingfang
2021-07-29 16:50       ` Vladimir Oltean
2021-07-29 16:50         ` Vladimir Oltean
2021-07-29 16:50         ` Vladimir Oltean
2021-07-30 15:45         ` DENG Qingfang
2021-07-30 15:45           ` DENG Qingfang
2021-07-30 15:45           ` DENG Qingfang
2021-07-30 15:58           ` DENG Qingfang
2021-07-30 15:58             ` DENG Qingfang
2021-07-30 15:58             ` DENG Qingfang
2021-07-30 16:18           ` Vladimir Oltean
2021-07-30 16:18             ` Vladimir Oltean
2021-07-30 16:18             ` Vladimir Oltean
2021-07-30 17:21             ` DENG Qingfang
2021-07-30 17:21               ` DENG Qingfang
2021-07-30 17:21               ` DENG Qingfang
2021-07-30 17:35               ` Vladimir Oltean
2021-07-30 17:35                 ` Vladimir Oltean
2021-07-30 17:35                 ` Vladimir Oltean
2021-07-30 17:51                 ` DENG Qingfang [this message]
2021-07-30 17:51                   ` DENG Qingfang
2021-07-30 17:51                   ` DENG Qingfang
2021-07-28 18:08 ` [RFC net-next 0/2] mt7530 software fallback bridging fix Vladimir Oltean
2021-07-28 18:08   ` Vladimir Oltean
2021-07-28 18:08   ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210730175139.518992-1-dqfext@gmail.com \
    --to=dqfext@gmail.com \
    --cc=Landen.Chao@mediatek.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=sean.wang@mediatek.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.