From: kernel test robot <lkp@intel.com>
To: Gabriel Krisman Bertazi <krisman@collabora.com>,
jack@suse.com, amir73il@gmail.com
Cc: kbuild-all@lists.01.org, djwong@kernel.org, tytso@mit.edu,
david@fromorbit.com, dhowells@redhat.com, khazhy@google.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [PATCH v4 15/16] samples: Add fs error monitoring example
Date: Sat, 31 Jul 2021 15:12:06 +0800 [thread overview]
Message-ID: <202107311526.Yekj42no-lkp@intel.com> (raw)
In-Reply-To: <20210720155944.1447086-16-krisman@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 2760 bytes --]
Hi Gabriel,
I love your patch! Yet something to improve:
[auto build test ERROR on ext3/fsnotify]
[also build test ERROR on ext4/dev ext3/for_next linus/master v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210721-001444
base: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/d65dd026fced2d19e194ceca1c490f32f1610a5d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210721-001444
git checkout d65dd026fced2d19e194ceca1c490f32f1610a5d
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash samples/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
samples/fanotify/fs-monitor.c: In function 'print_fh':
>> samples/fanotify/fs-monitor.c:43:25: error: 'FILEID_INO32_GEN' undeclared (first use in this function)
43 | if (fh->handle_type == FILEID_INO32_GEN)
| ^~~~~~~~~~~~~~~~
samples/fanotify/fs-monitor.c:43:25: note: each undeclared identifier is reported only once for each function it appears in
>> samples/fanotify/fs-monitor.c:45:30: error: 'FILEID_INVALID' undeclared (first use in this function)
45 | else if (fh->handle_type == FILEID_INVALID && !h[0] && !h[1])
| ^~~~~~~~~~~~~~
vim +/FILEID_INO32_GEN +43 samples/fanotify/fs-monitor.c
31
32 static void print_fh(struct file_handle *fh)
33 {
34 int i;
35 uint32_t *h = (uint32_t *) fh->f_handle;
36
37 printf("\tfh: ");
38 for (i = 0; i < fh->handle_bytes; i++)
39 printf("%hhx", fh->f_handle[i]);
40 printf("\n");
41
42 printf("\tdecoded fh: ");
> 43 if (fh->handle_type == FILEID_INO32_GEN)
44 printf("inode=%u gen=%u\n", h[0], h[1]);
> 45 else if (fh->handle_type == FILEID_INVALID && !h[0] && !h[1])
46 printf("Type %d (Superblock error)\n", fh->handle_type);
47 else
48 printf("Type %d (Unknown)\n", fh->handle_type);
49
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65170 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 15/16] samples: Add fs error monitoring example
Date: Sat, 31 Jul 2021 15:12:06 +0800 [thread overview]
Message-ID: <202107311526.Yekj42no-lkp@intel.com> (raw)
In-Reply-To: <20210720155944.1447086-16-krisman@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 2825 bytes --]
Hi Gabriel,
I love your patch! Yet something to improve:
[auto build test ERROR on ext3/fsnotify]
[also build test ERROR on ext4/dev ext3/for_next linus/master v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210721-001444
base: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/d65dd026fced2d19e194ceca1c490f32f1610a5d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210721-001444
git checkout d65dd026fced2d19e194ceca1c490f32f1610a5d
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash samples/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
samples/fanotify/fs-monitor.c: In function 'print_fh':
>> samples/fanotify/fs-monitor.c:43:25: error: 'FILEID_INO32_GEN' undeclared (first use in this function)
43 | if (fh->handle_type == FILEID_INO32_GEN)
| ^~~~~~~~~~~~~~~~
samples/fanotify/fs-monitor.c:43:25: note: each undeclared identifier is reported only once for each function it appears in
>> samples/fanotify/fs-monitor.c:45:30: error: 'FILEID_INVALID' undeclared (first use in this function)
45 | else if (fh->handle_type == FILEID_INVALID && !h[0] && !h[1])
| ^~~~~~~~~~~~~~
vim +/FILEID_INO32_GEN +43 samples/fanotify/fs-monitor.c
31
32 static void print_fh(struct file_handle *fh)
33 {
34 int i;
35 uint32_t *h = (uint32_t *) fh->f_handle;
36
37 printf("\tfh: ");
38 for (i = 0; i < fh->handle_bytes; i++)
39 printf("%hhx", fh->f_handle[i]);
40 printf("\n");
41
42 printf("\tdecoded fh: ");
> 43 if (fh->handle_type == FILEID_INO32_GEN)
44 printf("inode=%u gen=%u\n", h[0], h[1]);
> 45 else if (fh->handle_type == FILEID_INVALID && !h[0] && !h[1])
46 printf("Type %d (Superblock error)\n", fh->handle_type);
47 else
48 printf("Type %d (Unknown)\n", fh->handle_type);
49
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65170 bytes --]
next prev parent reply other threads:[~2021-07-31 7:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 15:59 [PATCH v4 00/16] File system wide monitoring Gabriel Krisman Bertazi
2021-07-20 15:59 ` [PATCH v4 01/16] fsnotify: Don't insert unmergeable events in hashtable Gabriel Krisman Bertazi
2021-07-20 15:59 ` [PATCH v4 02/16] fanotify: Fold event size calculation to its own function Gabriel Krisman Bertazi
2021-07-20 15:59 ` [PATCH v4 03/16] fanotify: Split fsid check from other fid mode checks Gabriel Krisman Bertazi
2021-07-20 15:59 ` [PATCH v4 04/16] fsnotify: Reserve mark bits for backends Gabriel Krisman Bertazi
2021-07-20 15:59 ` [PATCH v4 05/16] fanotify: Split superblock marks out to a new cache Gabriel Krisman Bertazi
2021-07-20 15:59 ` [PATCH v4 06/16] inotify: Don't force FS_IN_IGNORED Gabriel Krisman Bertazi
2021-07-20 15:59 ` [PATCH v4 07/16] fsnotify: Add helper to detect overflow_event Gabriel Krisman Bertazi
2021-07-20 15:59 ` [PATCH v4 08/16] fsnotify: pass arguments of fsnotify() in struct fsnotify_event_info Gabriel Krisman Bertazi
2021-07-31 6:38 ` [fsnotify] 4c40d6efc8: unixbench.score -3.3% regression kernel test robot
2021-07-31 6:38 ` kernel test robot
2021-07-31 9:27 ` Amir Goldstein
2021-07-31 9:27 ` Amir Goldstein
2021-07-31 16:27 ` Amir Goldstein
2021-07-31 16:27 ` Amir Goldstein
2021-08-03 14:22 ` Oliver Sang
2021-08-03 14:22 ` Oliver Sang
2021-08-03 16:19 ` Amir Goldstein
2021-08-03 16:19 ` Amir Goldstein
2021-07-31 19:51 ` Gabriel Krisman Bertazi
2021-07-31 19:51 ` Gabriel Krisman Bertazi
2021-08-01 6:32 ` Amir Goldstein
2021-08-01 6:32 ` Amir Goldstein
2021-08-02 10:45 ` Jan Kara
2021-08-02 10:45 ` Jan Kara
2021-07-20 15:59 ` [PATCH v4 09/16] fsnotify: Add wrapper around fsnotify_add_event Gabriel Krisman Bertazi
2021-07-20 16:56 ` Amir Goldstein
2021-07-20 15:59 ` [PATCH v4 10/16] fsnotify: Support passing argument to insert callback on add_event Gabriel Krisman Bertazi
2021-07-20 15:59 ` [PATCH v4 11/16] fsnotify: Support FS_ERROR event type Gabriel Krisman Bertazi
2021-07-20 15:59 ` [PATCH v4 12/16] fsnotify: Introduce helpers to send error_events Gabriel Krisman Bertazi
2021-07-20 15:59 ` [PATCH v4 13/16] fanotify: Introduce FAN_FS_ERROR event Gabriel Krisman Bertazi
2021-07-21 8:03 ` Amir Goldstein
2021-07-21 9:39 ` Amir Goldstein
2021-07-20 15:59 ` [PATCH v4 14/16] ext4: Send notifications on error Gabriel Krisman Bertazi
2021-07-20 15:59 ` [PATCH v4 15/16] samples: Add fs error monitoring example Gabriel Krisman Bertazi
2021-07-20 17:04 ` Amir Goldstein
2021-07-31 7:12 ` kernel test robot [this message]
2021-07-31 7:12 ` kernel test robot
2021-07-20 15:59 ` [PATCH v4 16/16] docs: Document the FAN_FS_ERROR event Gabriel Krisman Bertazi
2021-07-20 17:07 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107311526.Yekj42no-lkp@intel.com \
--to=lkp@intel.com \
--cc=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=jack@suse.com \
--cc=kbuild-all@lists.01.org \
--cc=khazhy@google.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.