* python3: remove no longer needed bbappend
@ 2021-07-26 18:58 Ruslan Babayev (fib)
2021-07-26 18:58 ` [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend Ruslan Babayev (fib)
2021-07-27 2:19 ` python3: remove no longer needed bbappend Bruce Ashfield
0 siblings, 2 replies; 8+ messages in thread
From: Ruslan Babayev (fib) @ 2021-07-26 18:58 UTC (permalink / raw)
To: meta-virtualization; +Cc: Bruce Ashfield
Bruce, I am resending the v3 which completely removes the bbappend
when virtualization is found in DISTRO_FEATURES. As you mentioned the
bbappend originates all the way from python2 days and is no longer
required. More importantly, it causes the breakage of python3-native
recipe.
Thanks,
Ruslan
^ permalink raw reply [flat|nested] 8+ messages in thread
* [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
2021-07-26 18:58 python3: remove no longer needed bbappend Ruslan Babayev (fib)
@ 2021-07-26 18:58 ` Ruslan Babayev (fib)
2021-07-29 14:57 ` Bruce Ashfield
2021-07-27 2:19 ` python3: remove no longer needed bbappend Bruce Ashfield
1 sibling, 1 reply; 8+ messages in thread
From: Ruslan Babayev (fib) @ 2021-07-26 18:58 UTC (permalink / raw)
To: meta-virtualization; +Cc: Bruce Ashfield, Ruslan Babayev
It has been carried over from python2 and is no longer required. More
importantly it breaks the python3-native build due to
${STAGING_DIR_TARGET} being "" for native recipes.
Signed-off-by: Ruslan Babayev <fib@cisco.com>
---
recipes-devtools/python/python3_3.%.bbappend | 1 -
recipes-devtools/python/python3_virtualization.inc | 8 --------
2 files changed, 9 deletions(-)
delete mode 100644 recipes-devtools/python/python3_3.%.bbappend
delete mode 100644 recipes-devtools/python/python3_virtualization.inc
diff --git a/recipes-devtools/python/python3_3.%.bbappend b/recipes-devtools/python/python3_3.%.bbappend
deleted file mode 100644
index 617cacc..0000000
--- a/recipes-devtools/python/python3_3.%.bbappend
+++ /dev/null
@@ -1 +0,0 @@
-require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization', '${BPN}_virtualization.inc', '', d)}
diff --git a/recipes-devtools/python/python3_virtualization.inc b/recipes-devtools/python/python3_virtualization.inc
deleted file mode 100644
index 55301c7..0000000
--- a/recipes-devtools/python/python3_virtualization.inc
+++ /dev/null
@@ -1,8 +0,0 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-DEPENDS += " ncurses"
-
-do_compile_prepend() {
- export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
-}
-
--
2.26.2.Cisco
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
2021-07-26 18:58 ` [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend Ruslan Babayev (fib)
@ 2021-07-29 14:57 ` Bruce Ashfield
2021-07-31 21:20 ` Ruslan Babayev (fib)
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Ashfield @ 2021-07-29 14:57 UTC (permalink / raw)
To: Ruslan Babayev; +Cc: meta-virtualization
merged.
Bruce
In message: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
on 26/07/2021 Ruslan Babayev wrote:
> It has been carried over from python2 and is no longer required. More
> importantly it breaks the python3-native build due to
> ${STAGING_DIR_TARGET} being "" for native recipes.
>
> Signed-off-by: Ruslan Babayev <fib@cisco.com>
> ---
> recipes-devtools/python/python3_3.%.bbappend | 1 -
> recipes-devtools/python/python3_virtualization.inc | 8 --------
> 2 files changed, 9 deletions(-)
> delete mode 100644 recipes-devtools/python/python3_3.%.bbappend
> delete mode 100644 recipes-devtools/python/python3_virtualization.inc
>
> diff --git a/recipes-devtools/python/python3_3.%.bbappend b/recipes-devtools/python/python3_3.%.bbappend
> deleted file mode 100644
> index 617cacc..0000000
> --- a/recipes-devtools/python/python3_3.%.bbappend
> +++ /dev/null
> @@ -1 +0,0 @@
> -require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization', '${BPN}_virtualization.inc', '', d)}
> diff --git a/recipes-devtools/python/python3_virtualization.inc b/recipes-devtools/python/python3_virtualization.inc
> deleted file mode 100644
> index 55301c7..0000000
> --- a/recipes-devtools/python/python3_virtualization.inc
> +++ /dev/null
> @@ -1,8 +0,0 @@
> -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> -
> -DEPENDS += " ncurses"
> -
> -do_compile_prepend() {
> - export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
> -}
> -
> --
> 2.26.2.Cisco
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
2021-07-29 14:57 ` Bruce Ashfield
@ 2021-07-31 21:20 ` Ruslan Babayev (fib)
2021-08-02 3:45 ` Bruce Ashfield
0 siblings, 1 reply; 8+ messages in thread
From: Ruslan Babayev (fib) @ 2021-07-31 21:20 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: meta-virtualization@lists.yoctoproject.org
Can this be cherry-picked into dunfell please?
-----Original Message-----
From: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org> On Behalf Of Bruce Ashfield
Sent: Thursday, July 29, 2021 7:57 AM
To: Ruslan Babayev (fib) <fib@cisco.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
merged.
Bruce
In message: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend on 26/07/2021 Ruslan Babayev wrote:
> It has been carried over from python2 and is no longer required. More
> importantly it breaks the python3-native build due to
> ${STAGING_DIR_TARGET} being "" for native recipes.
>
> Signed-off-by: Ruslan Babayev <fib@cisco.com>
> ---
> recipes-devtools/python/python3_3.%.bbappend | 1 -
> recipes-devtools/python/python3_virtualization.inc | 8 --------
> 2 files changed, 9 deletions(-)
> delete mode 100644 recipes-devtools/python/python3_3.%.bbappend
> delete mode 100644 recipes-devtools/python/python3_virtualization.inc
>
> diff --git a/recipes-devtools/python/python3_3.%.bbappend
> b/recipes-devtools/python/python3_3.%.bbappend
> deleted file mode 100644
> index 617cacc..0000000
> --- a/recipes-devtools/python/python3_3.%.bbappend
> +++ /dev/null
> @@ -1 +0,0 @@
> -require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization',
> '${BPN}_virtualization.inc', '', d)} diff --git
> a/recipes-devtools/python/python3_virtualization.inc
> b/recipes-devtools/python/python3_virtualization.inc
> deleted file mode 100644
> index 55301c7..0000000
> --- a/recipes-devtools/python/python3_virtualization.inc
> +++ /dev/null
> @@ -1,8 +0,0 @@
> -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> -
> -DEPENDS += " ncurses"
> -
> -do_compile_prepend() {
> - export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
> -}
> -
> --
> 2.26.2.Cisco
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
2021-07-31 21:20 ` Ruslan Babayev (fib)
@ 2021-08-02 3:45 ` Bruce Ashfield
2021-09-07 5:28 ` Changqing Li
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Ashfield @ 2021-08-02 3:45 UTC (permalink / raw)
To: Ruslan Babayev (fib); +Cc: meta-virtualization@lists.yoctoproject.org
In message: RE: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
on 31/07/2021 Ruslan Babayev (fib) wrote:
> Can this be cherry-picked into dunfell please?
No problem.
It is now on dunfell as well.
Bruce
>
> -----Original Message-----
> From: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org> On Behalf Of Bruce Ashfield
> Sent: Thursday, July 29, 2021 7:57 AM
> To: Ruslan Babayev (fib) <fib@cisco.com>
> Cc: meta-virtualization@lists.yoctoproject.org
> Subject: Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
>
> merged.
>
> Bruce
>
> In message: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend on 26/07/2021 Ruslan Babayev wrote:
>
> > It has been carried over from python2 and is no longer required. More
> > importantly it breaks the python3-native build due to
> > ${STAGING_DIR_TARGET} being "" for native recipes.
> >
> > Signed-off-by: Ruslan Babayev <fib@cisco.com>
> > ---
> > recipes-devtools/python/python3_3.%.bbappend | 1 -
> > recipes-devtools/python/python3_virtualization.inc | 8 --------
> > 2 files changed, 9 deletions(-)
> > delete mode 100644 recipes-devtools/python/python3_3.%.bbappend
> > delete mode 100644 recipes-devtools/python/python3_virtualization.inc
> >
> > diff --git a/recipes-devtools/python/python3_3.%.bbappend
> > b/recipes-devtools/python/python3_3.%.bbappend
> > deleted file mode 100644
> > index 617cacc..0000000
> > --- a/recipes-devtools/python/python3_3.%.bbappend
> > +++ /dev/null
> > @@ -1 +0,0 @@
> > -require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization',
> > '${BPN}_virtualization.inc', '', d)} diff --git
> > a/recipes-devtools/python/python3_virtualization.inc
> > b/recipes-devtools/python/python3_virtualization.inc
> > deleted file mode 100644
> > index 55301c7..0000000
> > --- a/recipes-devtools/python/python3_virtualization.inc
> > +++ /dev/null
> > @@ -1,8 +0,0 @@
> > -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > -
> > -DEPENDS += " ncurses"
> > -
> > -do_compile_prepend() {
> > - export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
> > -}
> > -
> > --
> > 2.26.2.Cisco
> >
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
2021-08-02 3:45 ` Bruce Ashfield
@ 2021-09-07 5:28 ` Changqing Li
2021-09-08 18:09 ` Bruce Ashfield
0 siblings, 1 reply; 8+ messages in thread
From: Changqing Li @ 2021-09-07 5:28 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: meta-virtualization@lists.yoctoproject.org
[-- Attachment #1: Type: text/plain, Size: 2571 bytes --]
On 8/2/21 11:45 AM, Bruce Ashfield wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> In message: RE: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
> on 31/07/2021 Ruslan Babayev (fib) wrote:
>
>> Can this be cherry-picked into dunfell please?
> No problem.
>
> It is now on dunfell as well.
>
> Bruce
Hi, Bruce
Can this be cherry-picked into hardnott please? python3-native build
also failed on hardnott.
Thanks
//Changqing
>> -----Original Message-----
>> From: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org> On Behalf Of Bruce Ashfield
>> Sent: Thursday, July 29, 2021 7:57 AM
>> To: Ruslan Babayev (fib) <fib@cisco.com>
>> Cc: meta-virtualization@lists.yoctoproject.org
>> Subject: Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
>>
>> merged.
>>
>> Bruce
>>
>> In message: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend on 26/07/2021 Ruslan Babayev wrote:
>>
>>> It has been carried over from python2 and is no longer required. More
>>> importantly it breaks the python3-native build due to
>>> ${STAGING_DIR_TARGET} being "" for native recipes.
>>>
>>> Signed-off-by: Ruslan Babayev <fib@cisco.com>
>>> ---
>>> recipes-devtools/python/python3_3.%.bbappend | 1 -
>>> recipes-devtools/python/python3_virtualization.inc | 8 --------
>>> 2 files changed, 9 deletions(-)
>>> delete mode 100644 recipes-devtools/python/python3_3.%.bbappend
>>> delete mode 100644 recipes-devtools/python/python3_virtualization.inc
>>>
>>> diff --git a/recipes-devtools/python/python3_3.%.bbappend
>>> b/recipes-devtools/python/python3_3.%.bbappend
>>> deleted file mode 100644
>>> index 617cacc..0000000
>>> --- a/recipes-devtools/python/python3_3.%.bbappend
>>> +++ /dev/null
>>> @@ -1 +0,0 @@
>>> -require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization',
>>> '${BPN}_virtualization.inc', '', d)} diff --git
>>> a/recipes-devtools/python/python3_virtualization.inc
>>> b/recipes-devtools/python/python3_virtualization.inc
>>> deleted file mode 100644
>>> index 55301c7..0000000
>>> --- a/recipes-devtools/python/python3_virtualization.inc
>>> +++ /dev/null
>>> @@ -1,8 +0,0 @@
>>> -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>>> -
>>> -DEPENDS += " ncurses"
>>> -
>>> -do_compile_prepend() {
>>> - export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
>>> -}
>>> -
>>> --
>>> 2.26.2.Cisco
>>>
>>>
>>>
>>>
[-- Attachment #2: Type: text/html, Size: 3888 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
2021-09-07 5:28 ` Changqing Li
@ 2021-09-08 18:09 ` Bruce Ashfield
0 siblings, 0 replies; 8+ messages in thread
From: Bruce Ashfield @ 2021-09-08 18:09 UTC (permalink / raw)
To: Changqing Li; +Cc: meta-virtualization@lists.yoctoproject.org
On Tue, Sep 7, 2021 at 1:28 AM Changqing Li <changqing.li@windriver.com> wrote:
>
>
> On 8/2/21 11:45 AM, Bruce Ashfield wrote:
>
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> In message: RE: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
> on 31/07/2021 Ruslan Babayev (fib) wrote:
>
> Can this be cherry-picked into dunfell please?
>
> No problem.
>
> It is now on dunfell as well.
>
> Bruce
>
> Hi, Bruce
>
> Can this be cherry-picked into hardnott please? python3-native build also failed on hardnott.
>
Cherry-picked and pushed.
Bruce
> Thanks
>
> //Changqing
>
> -----Original Message-----
> From: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org> On Behalf Of Bruce Ashfield
> Sent: Thursday, July 29, 2021 7:57 AM
> To: Ruslan Babayev (fib) <fib@cisco.com>
> Cc: meta-virtualization@lists.yoctoproject.org
> Subject: Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend
>
> merged.
>
> Bruce
>
> In message: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend on 26/07/2021 Ruslan Babayev wrote:
>
> It has been carried over from python2 and is no longer required. More
> importantly it breaks the python3-native build due to
> ${STAGING_DIR_TARGET} being "" for native recipes.
>
> Signed-off-by: Ruslan Babayev <fib@cisco.com>
> ---
> recipes-devtools/python/python3_3.%.bbappend | 1 -
> recipes-devtools/python/python3_virtualization.inc | 8 --------
> 2 files changed, 9 deletions(-)
> delete mode 100644 recipes-devtools/python/python3_3.%.bbappend
> delete mode 100644 recipes-devtools/python/python3_virtualization.inc
>
> diff --git a/recipes-devtools/python/python3_3.%.bbappend
> b/recipes-devtools/python/python3_3.%.bbappend
> deleted file mode 100644
> index 617cacc..0000000
> --- a/recipes-devtools/python/python3_3.%.bbappend
> +++ /dev/null
> @@ -1 +0,0 @@
> -require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization',
> '${BPN}_virtualization.inc', '', d)} diff --git
> a/recipes-devtools/python/python3_virtualization.inc
> b/recipes-devtools/python/python3_virtualization.inc
> deleted file mode 100644
> index 55301c7..0000000
> --- a/recipes-devtools/python/python3_virtualization.inc
> +++ /dev/null
> @@ -1,8 +0,0 @@
> -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> -
> -DEPENDS += " ncurses"
> -
> -do_compile_prepend() {
> - export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
> -}
> -
> --
> 2.26.2.Cisco
>
>
>
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: python3: remove no longer needed bbappend
2021-07-26 18:58 python3: remove no longer needed bbappend Ruslan Babayev (fib)
2021-07-26 18:58 ` [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend Ruslan Babayev (fib)
@ 2021-07-27 2:19 ` Bruce Ashfield
1 sibling, 0 replies; 8+ messages in thread
From: Bruce Ashfield @ 2021-07-27 2:19 UTC (permalink / raw)
To: Ruslan Babayev; +Cc: meta-virtualization
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
On Mon, Jul 26, 2021 at 2:58 PM Ruslan Babayev <fib@cisco.com> wrote:
>
> Bruce, I am resending the v3 which completely removes the bbappend
> when virtualization is found in DISTRO_FEATURES. As you mentioned the
> bbappend originates all the way from python2 days and is no longer
> required. More importantly, it causes the breakage of python3-native
> recipe.
>
Yup, that's the right thing to do. I've queued it for my local testing now.
Bruce
>
> Thanks,
> Ruslan
>
>
>
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
[-- Attachment #2: Type: text/html, Size: 1468 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-09-08 18:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-26 18:58 python3: remove no longer needed bbappend Ruslan Babayev (fib)
2021-07-26 18:58 ` [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend Ruslan Babayev (fib)
2021-07-29 14:57 ` Bruce Ashfield
2021-07-31 21:20 ` Ruslan Babayev (fib)
2021-08-02 3:45 ` Bruce Ashfield
2021-09-07 5:28 ` Changqing Li
2021-09-08 18:09 ` Bruce Ashfield
2021-07-27 2:19 ` python3: remove no longer needed bbappend Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.