All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kernel-team@android.com, kvm@vger.kernel.org,
	Will Deacon <will@kernel.org>,
	stable@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] KVM: arm64: Unregister HYP sections from kmemleak in protected mode
Date: Mon, 2 Aug 2021 17:52:14 +0100	[thread overview]
Message-ID: <20210802165214.GK18685@arm.com> (raw)
In-Reply-To: <20210802123830.2195174-3-maz@kernel.org>

On Mon, Aug 02, 2021 at 01:38:30PM +0100, Marc Zyngier wrote:
> Booting a KVM host in protected mode with kmemleak quickly results
> in a pretty bad crash, as kmemleak doesn't know that the HYP sections
> have been taken away. This is specially true for the BSS section,
> which is part of the kernel BSS section and registered at boot time
> by kmemleak itself.
> 
> Unregister the HYP part of the BSS before making that section
> HYP-private. The rest of the HYP-specific data is obtained via
> the page allocator or lives in other sections, none of which is
> subjected to kmemleak.
> 
> Fixes: 90134ac9cabb ("KVM: arm64: Protect the .hyp sections from the host")
> Reviewed-by: Quentin Perret <qperret@google.com>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: stable@vger.kernel.org # 5.13

Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org,
	James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Quentin Perret <qperret@google.com>,
	Will Deacon <will@kernel.org>,
	kernel-team@android.com, stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] KVM: arm64: Unregister HYP sections from kmemleak in protected mode
Date: Mon, 2 Aug 2021 17:52:14 +0100	[thread overview]
Message-ID: <20210802165214.GK18685@arm.com> (raw)
In-Reply-To: <20210802123830.2195174-3-maz@kernel.org>

On Mon, Aug 02, 2021 at 01:38:30PM +0100, Marc Zyngier wrote:
> Booting a KVM host in protected mode with kmemleak quickly results
> in a pretty bad crash, as kmemleak doesn't know that the HYP sections
> have been taken away. This is specially true for the BSS section,
> which is part of the kernel BSS section and registered at boot time
> by kmemleak itself.
> 
> Unregister the HYP part of the BSS before making that section
> HYP-private. The rest of the HYP-specific data is obtained via
> the page allocator or lives in other sections, none of which is
> subjected to kmemleak.
> 
> Fixes: 90134ac9cabb ("KVM: arm64: Protect the .hyp sections from the host")
> Reviewed-by: Quentin Perret <qperret@google.com>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: stable@vger.kernel.org # 5.13

Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org,
	James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Quentin Perret <qperret@google.com>,
	Will Deacon <will@kernel.org>,
	kernel-team@android.com, stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] KVM: arm64: Unregister HYP sections from kmemleak in protected mode
Date: Mon, 2 Aug 2021 17:52:14 +0100	[thread overview]
Message-ID: <20210802165214.GK18685@arm.com> (raw)
In-Reply-To: <20210802123830.2195174-3-maz@kernel.org>

On Mon, Aug 02, 2021 at 01:38:30PM +0100, Marc Zyngier wrote:
> Booting a KVM host in protected mode with kmemleak quickly results
> in a pretty bad crash, as kmemleak doesn't know that the HYP sections
> have been taken away. This is specially true for the BSS section,
> which is part of the kernel BSS section and registered at boot time
> by kmemleak itself.
> 
> Unregister the HYP part of the BSS before making that section
> HYP-private. The rest of the HYP-specific data is obtained via
> the page allocator or lives in other sections, none of which is
> subjected to kmemleak.
> 
> Fixes: 90134ac9cabb ("KVM: arm64: Protect the .hyp sections from the host")
> Reviewed-by: Quentin Perret <qperret@google.com>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: stable@vger.kernel.org # 5.13

Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>

  reply	other threads:[~2021-08-02 16:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 12:38 [PATCH v2 0/2] KVM: arm64: Prevent kmemleak from accessing HYP data Marc Zyngier
2021-08-02 12:38 ` Marc Zyngier
2021-08-02 12:38 ` Marc Zyngier
2021-08-02 12:38 ` [PATCH v2 1/2] arm64: Move .hyp.rodata outside of the _sdata.._edata range Marc Zyngier
2021-08-02 12:38   ` Marc Zyngier
2021-08-02 12:38   ` Marc Zyngier
2021-08-02 13:11   ` Quentin Perret
2021-08-02 13:11     ` Quentin Perret
2021-08-02 13:11     ` Quentin Perret
2021-08-02 13:20     ` Marc Zyngier
2021-08-02 13:20       ` Marc Zyngier
2021-08-02 13:20       ` Marc Zyngier
2021-08-02 13:47       ` Quentin Perret
2021-08-02 13:47         ` Quentin Perret
2021-08-02 13:47         ` Quentin Perret
2021-08-02 16:52   ` Catalin Marinas
2021-08-02 16:52     ` Catalin Marinas
2021-08-02 16:52     ` Catalin Marinas
2021-08-02 12:38 ` [PATCH v2 2/2] KVM: arm64: Unregister HYP sections from kmemleak in protected mode Marc Zyngier
2021-08-02 12:38   ` Marc Zyngier
2021-08-02 12:38   ` Marc Zyngier
2021-08-02 16:52   ` Catalin Marinas [this message]
2021-08-02 16:52     ` Catalin Marinas
2021-08-02 16:52     ` Catalin Marinas
2021-08-04 12:26 ` [PATCH v2 0/2] KVM: arm64: Prevent kmemleak from accessing HYP data Marc Zyngier
2021-08-04 12:26   ` Marc Zyngier
2021-08-04 12:26   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802165214.GK18685@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=kernel-team@android.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.