All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Mason Zhang <mason.zhang@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	leilk.liu@mediatek.com, wsd_upstream@mediatek.com
Subject: Re: [PATCH 2/3] spi: modify set_cs_timing parameter
Date: Mon, 2 Aug 2021 21:16:14 +0100	[thread overview]
Message-ID: <20210802201614.GA39900@sirena.org.uk> (raw)
In-Reply-To: <20210719091642.24633-1-mason.zhang@mediatek.com>


[-- Attachment #1.1: Type: text/plain, Size: 612 bytes --]

On Mon, Jul 19, 2021 at 05:16:43PM +0800, Mason Zhang wrote:
> From: Mason Zhang <Mason.Zhang@mediatek.com>
> 
> No need pass in spi_delay to set_cs_timing callback.

This breaks the build:

/mnt/kernel/drivers/spi/spi-tegra114.c: In function 'tegra_spi_probe':
/mnt/kernel/drivers/spi/spi-tegra114.c:1328:24: error: assignment to 'int (*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi_device *, struct spi_delay *, struct spi_delay *, struct spi_delay *)' [-Werror=incompatible-pointer-types]
  master->set_cs_timing = tegra_spi_set_hw_cs_timing;
                        ^

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Mason Zhang <mason.zhang@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	leilk.liu@mediatek.com, wsd_upstream@mediatek.com
Subject: Re: [PATCH 2/3] spi: modify set_cs_timing parameter
Date: Mon, 2 Aug 2021 21:16:14 +0100	[thread overview]
Message-ID: <20210802201614.GA39900@sirena.org.uk> (raw)
In-Reply-To: <20210719091642.24633-1-mason.zhang@mediatek.com>

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

On Mon, Jul 19, 2021 at 05:16:43PM +0800, Mason Zhang wrote:
> From: Mason Zhang <Mason.Zhang@mediatek.com>
> 
> No need pass in spi_delay to set_cs_timing callback.

This breaks the build:

/mnt/kernel/drivers/spi/spi-tegra114.c: In function 'tegra_spi_probe':
/mnt/kernel/drivers/spi/spi-tegra114.c:1328:24: error: assignment to 'int (*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi_device *, struct spi_delay *, struct spi_delay *, struct spi_delay *)' [-Werror=incompatible-pointer-types]
  master->set_cs_timing = tegra_spi_set_hw_cs_timing;
                        ^

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Mason Zhang <mason.zhang@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	leilk.liu@mediatek.com, wsd_upstream@mediatek.com
Subject: Re: [PATCH 2/3] spi: modify set_cs_timing parameter
Date: Mon, 2 Aug 2021 21:16:14 +0100	[thread overview]
Message-ID: <20210802201614.GA39900@sirena.org.uk> (raw)
In-Reply-To: <20210719091642.24633-1-mason.zhang@mediatek.com>


[-- Attachment #1.1: Type: text/plain, Size: 612 bytes --]

On Mon, Jul 19, 2021 at 05:16:43PM +0800, Mason Zhang wrote:
> From: Mason Zhang <Mason.Zhang@mediatek.com>
> 
> No need pass in spi_delay to set_cs_timing callback.

This breaks the build:

/mnt/kernel/drivers/spi/spi-tegra114.c: In function 'tegra_spi_probe':
/mnt/kernel/drivers/spi/spi-tegra114.c:1328:24: error: assignment to 'int (*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi_device *, struct spi_delay *, struct spi_delay *, struct spi_delay *)' [-Werror=incompatible-pointer-types]
  master->set_cs_timing = tegra_spi_set_hw_cs_timing;
                        ^

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-02 20:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19  9:16 [PATCH 2/3] spi: modify set_cs_timing parameter Mason Zhang
2021-07-19  9:16 ` Mason Zhang
2021-07-19  9:16 ` Mason Zhang
2021-08-02 20:16 ` Mark Brown [this message]
2021-08-02 20:16   ` Mark Brown
2021-08-02 20:16   ` Mark Brown
2021-08-03  3:14   ` Mason Zhang
2021-08-03  3:14     ` Mason Zhang
2021-08-03  3:14     ` Mason Zhang
2021-08-03 10:52     ` Mason Zhang
2021-08-03 10:52       ` Mason Zhang
2021-08-03 10:52       ` Mason Zhang
2021-08-06  0:47 ` Mark Brown
2021-08-06  0:47   ` Mark Brown
2021-08-06  0:47   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802201614.GA39900@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=leilk.liu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mason.zhang@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.