All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] leds: change led_brightness definition from enum to typedef
@ 2021-07-15 21:18 Amy Parker
  2021-07-15 21:18 ` [PATCH 1/2] swap led_brightness " Amy Parker
  2021-07-15 21:18 ` [PATCH 2/2] drivers/leds/TODO: update TODO to reflect changes Amy Parker
  0 siblings, 2 replies; 25+ messages in thread
From: Amy Parker @ 2021-07-15 21:18 UTC (permalink / raw)
  To: pavel; +Cc: Amy Parker, linux-leds, linux-kernel

This patch series solves the TODO listed in drivers/leds, and changes
the implementation of led_brightness from an enum to a combined typedef
of a u8 and set of macro definitions as suggested in the TODO.

Signed-off-by: Amy Parker <apark0006@student.cerritos.edu>

Amy Parker (2):
  swap led_brightness from enum to typedef
  drivers/leds/TODO: update TODO to reflect changes

 Documentation/leds/leds-class-flash.rst       |  2 +-
 arch/arm/mach-davinci/board-dm365-evm.c       |  4 +--
 arch/arm/mach-footbridge/ebsa285.c            |  4 +--
 arch/arm/mach-footbridge/netwinder-hw.c       |  4 +--
 arch/arm/mach-pxa/idp.c                       |  4 +--
 arch/arm/mach-pxa/lubbock.c                   |  4 +--
 arch/arm/mach-pxa/mainstone.c                 |  4 +--
 arch/arm/plat-omap/debug-leds.c               |  4 +--
 arch/mips/alchemy/devboards/db1000.c          |  4 +--
 arch/mips/alchemy/devboards/db1200.c          |  4 +--
 arch/mips/alchemy/devboards/db1300.c          |  4 +--
 arch/mips/txx9/rbtx4939/setup.c               |  2 +-
 arch/x86/platform/ts5500/ts5500.c             |  4 +--
 drivers/gpu/drm/nouveau/nouveau_led.c         |  4 +--
 drivers/hid/hid-asus.c                        |  4 +--
 drivers/hid/hid-bigbenff.c                    |  4 +--
 drivers/hid/hid-corsair.c                     |  6 ++--
 drivers/hid/hid-elan.c                        |  2 +-
 drivers/hid/hid-google-hammer.c               |  2 +-
 drivers/hid/hid-gt683r.c                      |  4 +--
 drivers/hid/hid-led.c                         | 20 ++++++------
 drivers/hid/hid-lenovo.c                      |  4 +--
 drivers/hid/hid-lg-g15.c                      | 24 +++++++-------
 drivers/hid/hid-lg4ff.c                       |  4 +--
 drivers/hid/hid-picolcd_leds.c                |  4 +--
 drivers/hid/hid-sony.c                        |  4 +--
 drivers/hid/hid-steelseries.c                 |  8 ++---
 drivers/hid/hid-u2fzero.c                     |  2 +-
 drivers/hid/hid-wiimote-modules.c             |  4 +--
 drivers/hid/wacom.h                           |  2 +-
 drivers/hid/wacom_sys.c                       |  8 ++---
 drivers/hwmon/applesmc.c                      |  2 +-
 drivers/hwmon/pmbus/ibm-cffps.c               |  2 +-
 drivers/input/input-leds.c                    |  4 +--
 drivers/input/joystick/xpad.c                 |  2 +-
 drivers/input/keyboard/applespi.c             |  2 +-
 drivers/input/keyboard/cap11xx.c              |  2 +-
 drivers/input/keyboard/lm8323.c               |  2 +-
 drivers/input/keyboard/qt2160.c               |  4 +--
 drivers/input/keyboard/tm2-touchkey.c         |  2 +-
 drivers/input/misc/apanel.c                   |  2 +-
 drivers/input/misc/ims-pcu.c                  |  4 +--
 drivers/input/misc/wistron_btns.c             |  4 +--
 drivers/input/touchscreen/stmfts.c            |  4 +--
 drivers/leds/TODO                             |  4 ---
 drivers/leds/blink/leds-lgm-sso.c             |  6 ++--
 drivers/leds/flash/leds-rt4505.c              |  4 +--
 drivers/leds/flash/leds-rt8515.c              |  2 +-
 drivers/leds/led-class-multicolor.c           |  2 +-
 drivers/leds/led-triggers.c                   |  2 +-
 drivers/leds/leds-88pm860x.c                  |  2 +-
 drivers/leds/leds-aat1290.c                   |  8 ++---
 drivers/leds/leds-acer-a500.c                 |  2 +-
 drivers/leds/leds-adp5520.c                   |  2 +-
 drivers/leds/leds-an30259a.c                  |  2 +-
 drivers/leds/leds-apu.c                       |  4 +--
 drivers/leds/leds-ariel.c                     |  4 +--
 drivers/leds/leds-as3645a.c                   |  4 +--
 drivers/leds/leds-asic3.c                     |  2 +-
 drivers/leds/leds-aw2013.c                    |  2 +-
 drivers/leds/leds-bcm6328.c                   |  2 +-
 drivers/leds/leds-bcm6358.c                   |  2 +-
 drivers/leds/leds-bd2802.c                    |  2 +-
 drivers/leds/leds-blinkm.c                    |  8 ++---
 drivers/leds/leds-clevo-mail.c                |  2 +-
 drivers/leds/leds-cobalt-qube.c               |  2 +-
 drivers/leds/leds-cobalt-raq.c                |  4 +--
 drivers/leds/leds-cpcap.c                     |  2 +-
 drivers/leds/leds-cr0014114.c                 |  2 +-
 drivers/leds/leds-da903x.c                    |  2 +-
 drivers/leds/leds-da9052.c                    |  4 +--
 drivers/leds/leds-dac124s085.c                |  2 +-
 drivers/leds/leds-el15203000.c                |  2 +-
 drivers/leds/leds-fsg.c                       | 12 +++----
 drivers/leds/leds-gpio.c                      |  4 +--
 drivers/leds/leds-hp6xx.c                     |  4 +--
 drivers/leds/leds-ip30.c                      |  2 +-
 drivers/leds/leds-ipaq-micro.c                |  2 +-
 drivers/leds/leds-is31fl319x.c                |  2 +-
 drivers/leds/leds-is31fl32xx.c                |  2 +-
 drivers/leds/leds-ktd2692.c                   |  6 ++--
 drivers/leds/leds-lm3530.c                    |  4 +--
 drivers/leds/leds-lm3532.c                    |  2 +-
 drivers/leds/leds-lm3533.c                    |  4 +--
 drivers/leds/leds-lm355x.c                    |  6 ++--
 drivers/leds/leds-lm3601x.c                   |  2 +-
 drivers/leds/leds-lm36274.c                   |  2 +-
 drivers/leds/leds-lm3642.c                    |  6 ++--
 drivers/leds/leds-lm3692x.c                   |  4 +--
 drivers/leds/leds-lm3697.c                    |  2 +-
 drivers/leds/leds-locomo.c                    |  6 ++--
 drivers/leds/leds-lp3944.c                    |  4 +--
 drivers/leds/leds-lp3952.c                    |  2 +-
 drivers/leds/leds-lp50xx.c                    |  2 +-
 drivers/leds/leds-lp55xx-common.c             |  4 +--
 drivers/leds/leds-lp8788.c                    |  2 +-
 drivers/leds/leds-lp8860.c                    |  2 +-
 drivers/leds/leds-lt3593.c                    |  2 +-
 drivers/leds/leds-max77650.c                  |  2 +-
 drivers/leds/leds-max77693.c                  |  2 +-
 drivers/leds/leds-max8997.c                   |  4 +--
 drivers/leds/leds-mc13783.c                   |  2 +-
 drivers/leds/leds-menf21bmc.c                 |  2 +-
 drivers/leds/leds-mlxcpld.c                   |  4 +--
 drivers/leds/leds-mlxreg.c                    |  8 ++---
 drivers/leds/leds-mt6323.c                    | 10 +++---
 drivers/leds/leds-net48xx.c                   |  2 +-
 drivers/leds/leds-netxbig.c                   |  2 +-
 drivers/leds/leds-nic78bx.c                   |  4 +--
 drivers/leds/leds-ns2.c                       |  4 +--
 drivers/leds/leds-ot200.c                     |  2 +-
 drivers/leds/leds-pca9532.c                   |  4 +--
 drivers/leds/leds-pca955x.c                   |  2 +-
 drivers/leds/leds-pca963x.c                   |  4 +--
 drivers/leds/leds-pm8058.c                    |  6 ++--
 drivers/leds/leds-powernv.c                   |  8 ++---
 drivers/leds/leds-pwm.c                       |  2 +-
 drivers/leds/leds-rb532.c                     |  4 +--
 drivers/leds/leds-regulator.c                 |  4 +--
 drivers/leds/leds-s3c24xx.c                   |  2 +-
 drivers/leds/leds-sc27xx-bltc.c               |  4 +--
 drivers/leds/leds-sgm3140.c                   |  2 +-
 drivers/leds/leds-spi-byte.c                  |  2 +-
 drivers/leds/leds-ss4200.c                    |  2 +-
 drivers/leds/leds-sunfire.c                   | 18 +++++------
 drivers/leds/leds-syscon.c                    |  2 +-
 drivers/leds/leds-tca6507.c                   |  2 +-
 drivers/leds/leds-tlc591xx.c                  |  2 +-
 drivers/leds/leds-tps6105x.c                  |  2 +-
 drivers/leds/leds-turris-omnia.c              |  2 +-
 drivers/leds/leds-wm831x-status.c             |  4 +--
 drivers/leds/leds-wm8350.c                    |  2 +-
 drivers/leds/leds-wrap.c                      |  6 ++--
 drivers/leds/trigger/ledtrig-audio.c          |  6 ++--
 drivers/leds/trigger/ledtrig-camera.c         |  4 +--
 drivers/leds/uleds.c                          |  2 +-
 drivers/macintosh/via-pmu-led.c               |  2 +-
 drivers/media/radio/radio-shark.c             |  6 ++--
 drivers/media/radio/radio-shark2.c            |  4 +--
 drivers/media/rc/redrat3.c                    |  2 +-
 drivers/media/rc/ttusbir.c                    |  4 +--
 drivers/media/rc/winbond-cir.c                |  4 +--
 .../media/v4l2-core/v4l2-flash-led-class.c    |  6 ++--
 drivers/mmc/host/rtsx_usb_sdmmc.c             |  2 +-
 drivers/mmc/host/sdhci.c                      |  2 +-
 drivers/net/arcnet/com20020-pci.c             |  4 +--
 drivers/net/dsa/hirschmann/hellcreek_ptp.c    | 12 +++----
 drivers/net/wireless/ath/ath5k/led.c          |  2 +-
 drivers/net/wireless/ath/ath9k/gpio.c         |  2 +-
 drivers/net/wireless/ath/ath9k/htc.h          |  2 +-
 drivers/net/wireless/ath/ath9k/htc_drv_gpio.c |  2 +-
 drivers/net/wireless/ath/carl9170/led.c       |  2 +-
 drivers/net/wireless/broadcom/b43/leds.c      |  2 +-
 .../net/wireless/broadcom/b43legacy/leds.c    |  2 +-
 .../broadcom/brcm80211/brcmsmac/led.c         |  2 +-
 drivers/net/wireless/intel/iwlegacy/common.c  |  2 +-
 drivers/net/wireless/intel/iwlwifi/dvm/led.c  |  2 +-
 drivers/net/wireless/intel/iwlwifi/mvm/led.c  |  2 +-
 drivers/net/wireless/intersil/p54/led.c       |  2 +-
 .../net/wireless/mediatek/mt76/mt7603/init.c  |  2 +-
 .../wireless/mediatek/mt76/mt7615/pci_init.c  |  2 +-
 .../net/wireless/mediatek/mt76/mt76x02_util.c |  2 +-
 .../net/wireless/ralink/rt2x00/rt2400pci.c    |  2 +-
 .../net/wireless/ralink/rt2x00/rt2500pci.c    |  2 +-
 .../net/wireless/ralink/rt2x00/rt2500usb.c    |  2 +-
 .../net/wireless/ralink/rt2x00/rt2800lib.c    |  2 +-
 drivers/net/wireless/ralink/rt2x00/rt61pci.c  |  2 +-
 drivers/net/wireless/ralink/rt2x00/rt73usb.c  |  2 +-
 .../wireless/realtek/rtl818x/rtl8187/leds.c   |  2 +-
 .../platform/chrome/cros_kbd_led_backlight.c  |  4 +--
 .../platform/chrome/wilco_ec/keyboard_leds.c  |  4 +--
 drivers/platform/x86/acer-wmi.c               |  2 +-
 drivers/platform/x86/asus-laptop.c            |  8 ++---
 drivers/platform/x86/asus-wireless.c          |  4 +--
 drivers/platform/x86/asus-wmi.c               | 18 +++++------
 drivers/platform/x86/dell/alienware-wmi.c     |  4 +--
 drivers/platform/x86/dell/dell-laptop.c       | 16 +++++-----
 drivers/platform/x86/dell/dell-wmi-led.c      |  2 +-
 drivers/platform/x86/dell/dell-wmi-privacy.c  |  2 +-
 drivers/platform/x86/eeepc-laptop.c           |  4 +--
 drivers/platform/x86/fujitsu-laptop.c         | 22 ++++++-------
 drivers/platform/x86/hp_accel.c               |  8 ++---
 drivers/platform/x86/huawei-wmi.c             |  2 +-
 drivers/platform/x86/ideapad-laptop.c         |  4 +--
 drivers/platform/x86/lg-laptop.c              |  8 ++---
 drivers/platform/x86/samsung-laptop.c         |  4 +--
 drivers/platform/x86/system76_acpi.c          | 16 +++++-----
 drivers/platform/x86/thinkpad_acpi.c          | 20 ++++++------
 drivers/platform/x86/topstar-laptop.c         |  4 +--
 drivers/platform/x86/toshiba_acpi.c           | 12 +++----
 drivers/staging/greybus/light.c               |  4 +--
 drivers/staging/nvec/nvec_paz00.c             |  2 +-
 drivers/video/backlight/adp8860_bl.c          |  4 +--
 drivers/video/backlight/adp8870_bl.c          |  4 +--
 drivers/video/backlight/lm3639_bl.c           |  4 +--
 include/linux/led-class-multicolor.h          |  4 +--
 include/linux/leds-regulator.h                |  2 +-
 include/linux/leds.h                          | 31 +++++++++----------
 include/linux/mfd/wm8350/pmic.h               |  2 +-
 include/media/v4l2-flash-led-class.h          |  6 ++--
 net/rfkill/core.c                             |  2 +-
 sound/pci/hda/hda_generic.c                   |  6 ++--
 sound/pci/hda/hda_generic.h                   |  4 +--
 sound/pci/hda/patch_conexant.c                |  6 ++--
 sound/pci/hda/patch_realtek.c                 | 12 +++----
 sound/pci/hda/patch_sigmatel.c                |  4 +--
 sound/usb/line6/toneport.c                    |  2 +-
 207 files changed, 436 insertions(+), 441 deletions(-)

-- 
2.31.1


^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [PATCH 1/2] swap led_brightness from enum to typedef
  2021-07-15 21:18 ` [PATCH 1/2] swap led_brightness " Amy Parker
  2021-07-16  0:41     ` kernel test robot
@ 2021-07-19  8:05 ` Dan Carpenter
  2021-07-19  7:16   ` Geert Uytterhoeven
  2021-07-19 12:08   ` Pavel Machek
  3 siblings, 0 replies; 25+ messages in thread
From: kernel test robot @ 2021-07-16  2:48 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 4793 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <9b5902665dcc4c0fca7546987303e348d8657f59.1626383424.git.apark0006@student.cerritos.edu>
References: <9b5902665dcc4c0fca7546987303e348d8657f59.1626383424.git.apark0006@student.cerritos.edu>
TO: Amy Parker <apark0006@student.cerritos.edu>
TO: pavel(a)ucw.cz
CC: Amy Parker <apark0006@student.cerritos.edu>
CC: linux-leds(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

Hi Amy,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.14-rc1 next-20210715]
[cannot apply to pavel-linux-leds/for-next wireless-drivers-next/master wireless-drivers/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Amy-Parker/leds-change-led_brightness-definition-from-enum-to-typedef/20210716-052140
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd9c7df94c1b23feacd54112f33ad95d93f64533
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
config: i386-randconfig-m021-20210715 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/hid/hid-corsair.c:157 k90_backlight_get() warn: signedness bug returning '(-12)'

vim +157 drivers/hid/hid-corsair.c

6f78193ee9ea55 Clément Vuchener 2015-09-30  144  
b14a971f104520 Amy Parker       2021-07-15  145  static led_brightness k90_backlight_get(struct led_classdev *led_cdev)
6f78193ee9ea55 Clément Vuchener 2015-09-30  146  {
6f78193ee9ea55 Clément Vuchener 2015-09-30  147  	int ret;
6f78193ee9ea55 Clément Vuchener 2015-09-30  148  	struct k90_led *led = container_of(led_cdev, struct k90_led, cdev);
6f78193ee9ea55 Clément Vuchener 2015-09-30  149  	struct device *dev = led->cdev.dev->parent;
6f78193ee9ea55 Clément Vuchener 2015-09-30  150  	struct usb_interface *usbif = to_usb_interface(dev->parent);
6f78193ee9ea55 Clément Vuchener 2015-09-30  151  	struct usb_device *usbdev = interface_to_usbdev(usbif);
6f78193ee9ea55 Clément Vuchener 2015-09-30  152  	int brightness;
6d104af38b570d Johan Hovold     2017-01-12  153  	char *data;
6d104af38b570d Johan Hovold     2017-01-12  154  
6d104af38b570d Johan Hovold     2017-01-12  155  	data = kmalloc(8, GFP_KERNEL);
6d104af38b570d Johan Hovold     2017-01-12  156  	if (!data)
6d104af38b570d Johan Hovold     2017-01-12 @157  		return -ENOMEM;
6f78193ee9ea55 Clément Vuchener 2015-09-30  158  
6f78193ee9ea55 Clément Vuchener 2015-09-30  159  	ret = usb_control_msg(usbdev, usb_rcvctrlpipe(usbdev, 0),
6f78193ee9ea55 Clément Vuchener 2015-09-30  160  			      K90_REQUEST_STATUS,
6f78193ee9ea55 Clément Vuchener 2015-09-30  161  			      USB_DIR_IN | USB_TYPE_VENDOR |
6f78193ee9ea55 Clément Vuchener 2015-09-30  162  			      USB_RECIP_DEVICE, 0, 0, data, 8,
6f78193ee9ea55 Clément Vuchener 2015-09-30  163  			      USB_CTRL_SET_TIMEOUT);
7a546af50eb78a Johan Hovold     2017-01-12  164  	if (ret < 5) {
6f78193ee9ea55 Clément Vuchener 2015-09-30  165  		dev_warn(dev, "Failed to get K90 initial state (error %d).\n",
6f78193ee9ea55 Clément Vuchener 2015-09-30  166  			 ret);
6d104af38b570d Johan Hovold     2017-01-12  167  		ret = -EIO;
6d104af38b570d Johan Hovold     2017-01-12  168  		goto out;
6f78193ee9ea55 Clément Vuchener 2015-09-30  169  	}
6f78193ee9ea55 Clément Vuchener 2015-09-30  170  	brightness = data[4];
6f78193ee9ea55 Clément Vuchener 2015-09-30  171  	if (brightness < 0 || brightness > 3) {
6f78193ee9ea55 Clément Vuchener 2015-09-30  172  		dev_warn(dev,
6f78193ee9ea55 Clément Vuchener 2015-09-30  173  			 "Read invalid backlight brightness: %02hhx.\n",
6f78193ee9ea55 Clément Vuchener 2015-09-30  174  			 data[4]);
6d104af38b570d Johan Hovold     2017-01-12  175  		ret = -EIO;
6d104af38b570d Johan Hovold     2017-01-12  176  		goto out;
6f78193ee9ea55 Clément Vuchener 2015-09-30  177  	}
6d104af38b570d Johan Hovold     2017-01-12  178  	ret = brightness;
6d104af38b570d Johan Hovold     2017-01-12  179  out:
6d104af38b570d Johan Hovold     2017-01-12  180  	kfree(data);
6d104af38b570d Johan Hovold     2017-01-12  181  
6d104af38b570d Johan Hovold     2017-01-12  182  	return ret;
6f78193ee9ea55 Clément Vuchener 2015-09-30  183  }
6f78193ee9ea55 Clément Vuchener 2015-09-30  184  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36189 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [PATCH 1/2] swap led_brightness from enum to typedef
  2021-07-15 21:18 ` [PATCH 1/2] swap led_brightness " Amy Parker
  2021-07-16  0:41     ` kernel test robot
@ 2021-07-19  8:21 ` Dan Carpenter
  2021-07-19  7:16   ` Geert Uytterhoeven
  2021-07-19 12:08   ` Pavel Machek
  3 siblings, 0 replies; 25+ messages in thread
From: kernel test robot @ 2021-07-18 12:49 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 3075 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <9b5902665dcc4c0fca7546987303e348d8657f59.1626383424.git.apark0006@student.cerritos.edu>
References: <9b5902665dcc4c0fca7546987303e348d8657f59.1626383424.git.apark0006@student.cerritos.edu>
TO: Amy Parker <apark0006@student.cerritos.edu>
TO: pavel(a)ucw.cz
CC: Amy Parker <apark0006@student.cerritos.edu>
CC: linux-leds(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

Hi Amy,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.14-rc1 next-20210716]
[cannot apply to pavel-linux-leds/for-next wireless-drivers-next/master wireless-drivers/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Amy-Parker/leds-change-led_brightness-definition-from-enum-to-typedef/20210716-052140
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd9c7df94c1b23feacd54112f33ad95d93f64533
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: x86_64-randconfig-m001-20210718 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/platform/chrome/cros_kbd_led_backlight.c:53 keyboard_led_get_brightness() warn: signedness bug returning '(-5)'
drivers/platform/x86/samsung-laptop.c:1124 kbd_led_set() warn: impossible condition '(value < 0) => (0-255 < 0)'

vim +53 drivers/platform/chrome/cros_kbd_led_backlight.c

492ef7829d2d09 Simon Que  2016-03-08  41  
b14a971f104520 Amy Parker 2021-07-15  42  static led_brightness
492ef7829d2d09 Simon Que  2016-03-08  43  keyboard_led_get_brightness(struct led_classdev *cdev)
492ef7829d2d09 Simon Que  2016-03-08  44  {
492ef7829d2d09 Simon Que  2016-03-08  45  	unsigned long long brightness;
492ef7829d2d09 Simon Que  2016-03-08  46  	acpi_status status;
492ef7829d2d09 Simon Que  2016-03-08  47  
492ef7829d2d09 Simon Que  2016-03-08  48  	status = acpi_evaluate_integer(NULL, ACPI_KEYBOARD_BACKLIGHT_READ,
492ef7829d2d09 Simon Que  2016-03-08  49  				       NULL, &brightness);
492ef7829d2d09 Simon Que  2016-03-08  50  	if (ACPI_FAILURE(status)) {
492ef7829d2d09 Simon Que  2016-03-08  51  		dev_err(cdev->dev, "Error getting keyboard LED value: %d\n",
492ef7829d2d09 Simon Que  2016-03-08  52  			status);
492ef7829d2d09 Simon Que  2016-03-08 @53  		return -EIO;
492ef7829d2d09 Simon Que  2016-03-08  54  	}
492ef7829d2d09 Simon Que  2016-03-08  55  
492ef7829d2d09 Simon Que  2016-03-08  56  	return brightness;
492ef7829d2d09 Simon Que  2016-03-08  57  }
492ef7829d2d09 Simon Que  2016-03-08  58  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40152 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2021-08-03 21:38 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-15 21:18 [PATCH 0/2] leds: change led_brightness definition from enum to typedef Amy Parker
2021-07-15 21:18 ` [PATCH 1/2] swap led_brightness " Amy Parker
2021-07-16  0:41   ` kernel test robot
2021-07-16  0:41     ` kernel test robot
2021-07-16  2:14   ` kernel test robot
2021-07-16  2:14     ` kernel test robot
2021-07-16  3:11     ` Amy Parker
2021-07-16  3:11       ` Amy Parker
2021-07-16 21:07       ` Amy Parker
2021-07-16 21:07         ` Amy Parker
2021-07-16 21:43         ` Randy Dunlap
2021-07-16 21:43           ` Randy Dunlap
2021-07-19 12:05           ` Pavel Machek
2021-07-19 12:05             ` Pavel Machek
2021-07-19  7:16   ` Geert Uytterhoeven
2021-07-19  8:40     ` Geert Uytterhoeven
2021-08-03 21:38       ` Pavel Machek
2021-07-19 12:08   ` Pavel Machek
2021-07-15 21:18 ` [PATCH 2/2] drivers/leds/TODO: update TODO to reflect changes Amy Parker
  -- strict thread matches above, loose matches on Subject: below --
2021-07-16  2:48 [PATCH 1/2] swap led_brightness from enum to typedef kernel test robot
2021-07-19  8:05 ` Dan Carpenter
2021-07-19  8:05 ` Dan Carpenter
2021-07-18 12:49 kernel test robot
2021-07-19  8:21 ` Dan Carpenter
2021-07-19  8:21 ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.