[tnguy-next-queue:dev-queue 658/780] net/ethtool/netlink.c:67 ethnl_ops_complete() error: we previously assumed 'dev' could be null (see line 64)

[tnguy-next-queue:dev-queue 658/780] net/ethtool/netlink.c:67 ethnl_ops_complete() error: we previously assumed 'dev' could be null (see line 64)

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1949 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Intel Wired LAN <intel-wired-lan@lists.osuosl.org>
CC: linux-kernel(a)vger.kernel.org
TO: Heiner Kallweit <hkallweit1@gmail.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue
head:   6452b881d66ef372a44fedea9d6190d0a48003ee
commit: d43c65b05b848e0b2db1a6c78b02c189da3a95b5 [658/780] ethtool: runtime-resume netdev parent in ethnl_ops_begin
:::::: branch date: 3 hours ago
:::::: commit date: 12 hours ago
config: openrisc-randconfig-m031-20210803 (attached as .config)
compiler: or1k-linux-gcc (GCC) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
net/ethtool/netlink.c:67 ethnl_ops_complete() error: we previously assumed 'dev' could be null (see line 64)

Old smatch warnings:
net/ethtool/netlink.c:532 ethnl_default_start() warn: potential spectre issue 'ethnl_default_requests' [r]
net/ethtool/netlink.c:533 ethnl_default_start() warn: possible spectre second half.  'ops'

vim +/dev +67 net/ethtool/netlink.c

c5ab51df03e2d7 Heiner Kallweit 2021-08-01  61  
c5ab51df03e2d7 Heiner Kallweit 2021-08-01  62  void ethnl_ops_complete(struct net_device *dev)
c5ab51df03e2d7 Heiner Kallweit 2021-08-01  63  {
c5ab51df03e2d7 Heiner Kallweit 2021-08-01 @64  	if (dev && dev->ethtool_ops->complete)
c5ab51df03e2d7 Heiner Kallweit 2021-08-01  65  		dev->ethtool_ops->complete(dev);
d43c65b05b848e Heiner Kallweit 2021-08-01  66  
d43c65b05b848e Heiner Kallweit 2021-08-01 @67  	if (dev->dev.parent)
d43c65b05b848e Heiner Kallweit 2021-08-01  68  		pm_runtime_put(dev->dev.parent);
c5ab51df03e2d7 Heiner Kallweit 2021-08-01  69  }
c5ab51df03e2d7 Heiner Kallweit 2021-08-01  70  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35150 bytes --]