Re: [PATCH] parisc: Make struct parisc_driver::remove() return void

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2448 bytes --]

Hi "Uwe,

I love your patch! Yet something to improve:

[auto build test ERROR on hp-parisc/for-next]
[also build test ERROR on char-misc/char-misc-testing mkp-scsi/for-next scsi/for-next v5.14-rc4 next-20210805]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/parisc-Make-struct-parisc_driver-remove-return-void/20210806-174220
base:   https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git for-next
config: x86_64-buildonly-randconfig-r004-20210805 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/1e227b75878229ccbb4c9146a4184099e2cdbd08
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Uwe-Kleine-K-nig/parisc-Make-struct-parisc_driver-remove-return-void/20210806-174220
        git checkout 1e227b75878229ccbb4c9146a4184099e2cdbd08
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/char/ipmi/ipmi_si_intf.c:2231:6: error: conflicting types for 'ipmi_si_remove_by_dev'
    2231 | void ipmi_si_remove_by_dev(struct device *dev)
         |      ^~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/char/ipmi/ipmi_si_intf.c:42:
   drivers/char/ipmi/ipmi_si.h:76:5: note: previous declaration of 'ipmi_si_remove_by_dev' was here
      76 | int ipmi_si_remove_by_dev(struct device *dev);
         |     ^~~~~~~~~~~~~~~~~~~~~


vim +/ipmi_si_remove_by_dev +2231 drivers/char/ipmi/ipmi_si_intf.c

  2230	
> 2231	void ipmi_si_remove_by_dev(struct device *dev)
  2232	{
  2233		struct smi_info *e;
  2234	
  2235		mutex_lock(&smi_infos_lock);
  2236		list_for_each_entry(e, &smi_infos, link) {
  2237			if (e->io.dev == dev) {
  2238				cleanup_one_si(e);
  2239				break;
  2240			}
  2241		}
  2242		mutex_unlock(&smi_infos_lock);
  2243	}
  2244	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37512 bytes --]