From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: kernel@pengutronix.de, alsa-devel@alsa-project.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Corey Minyard <minyard@acm.org>,
linux-scsi@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Helge Deller <deller@gmx.de>, Takashi Iwai <tiwai@suse.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
netdev@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-serial@vger.kernel.org, linux-input@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>,
openipmi-developer@lists.sourceforge.net,
Jiri Slaby <jirislaby@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] parisc: Make struct parisc_driver::remove() return void
Date: Fri, 6 Aug 2021 11:46:13 -0700 [thread overview]
Message-ID: <YQ2DdZG2tQuzM22U@google.com> (raw)
In-Reply-To: <20210806093938.1950990-1-u.kleine-koenig@pengutronix.de>
On Fri, Aug 06, 2021 at 11:39:38AM +0200, Uwe Kleine-König wrote:
> The caller of this function (parisc_driver_remove() in
> arch/parisc/kernel/drivers.c) ignores the return value, so better don't
> return any value at all to not wake wrong expectations in driver authors.
>
> The only function that could return a non-zero value before was
> ipmi_parisc_remove() which returns the return value of
> ipmi_si_remove_by_dev(). Make this function return void, too, as for all
> other callers the value is ignored, too.
>
> Also fold in a small checkpatch fix for:
>
> WARNING: Unnecessary space before function pointer arguments
> + void (*remove) (struct parisc_device *dev);
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
...
> drivers/input/keyboard/hilkbd.c | 4 +---
> drivers/input/serio/gscps2.c | 3 +--
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>, Corey Minyard <minyard@acm.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-parisc@vger.kernel.org,
openipmi-developer@lists.sourceforge.net,
linux-input@vger.kernel.org, netdev@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org,
alsa-devel@alsa-project.org, kernel@pengutronix.de
Subject: Re: [PATCH] parisc: Make struct parisc_driver::remove() return void
Date: Fri, 6 Aug 2021 11:46:13 -0700 [thread overview]
Message-ID: <YQ2DdZG2tQuzM22U@google.com> (raw)
In-Reply-To: <20210806093938.1950990-1-u.kleine-koenig@pengutronix.de>
On Fri, Aug 06, 2021 at 11:39:38AM +0200, Uwe Kleine-König wrote:
> The caller of this function (parisc_driver_remove() in
> arch/parisc/kernel/drivers.c) ignores the return value, so better don't
> return any value at all to not wake wrong expectations in driver authors.
>
> The only function that could return a non-zero value before was
> ipmi_parisc_remove() which returns the return value of
> ipmi_si_remove_by_dev(). Make this function return void, too, as for all
> other callers the value is ignored, too.
>
> Also fold in a small checkpatch fix for:
>
> WARNING: Unnecessary space before function pointer arguments
> + void (*remove) (struct parisc_device *dev);
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
...
> drivers/input/keyboard/hilkbd.c | 4 +---
> drivers/input/serio/gscps2.c | 3 +--
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-08-06 18:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 9:39 [PATCH] parisc: Make struct parisc_driver::remove() return void Uwe Kleine-König
2021-08-06 9:39 ` Uwe Kleine-König
2021-08-06 15:20 ` kernel test robot
2021-08-06 17:49 ` Corey Minyard
2021-08-06 17:49 ` Corey Minyard
2021-08-07 9:11 ` Uwe Kleine-König
2021-08-07 9:11 ` Uwe Kleine-König
2021-08-06 18:46 ` Dmitry Torokhov [this message]
2021-08-06 18:46 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQ2DdZG2tQuzM22U@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alsa-devel@alsa-project.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=minyard@acm.org \
--cc=netdev@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=sudipm.mukherjee@gmail.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.