* [PATCH v1 0/2] AUXADC: Mediatek auxadc driver @ 2021-08-12 5:48 Hui Liu 2021-08-12 5:48 ` [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case Hui Liu 2021-08-12 5:48 ` [PATCH v1 2/2] iio: mtk-auxadc: update case IIO_CHAN_INFO_PROCESSED Hui Liu 0 siblings, 2 replies; 14+ messages in thread From: Hui Liu @ 2021-08-12 5:48 UTC (permalink / raw) To: robh+dt, jic23, lars, pmeerw Cc: srv_heupstream, hui.liu, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek This series includes two patchs: 1.add support for case IIO_CHAN_INFO_RAW. 2.update case IIO_CHAN_INFO_PROCESSED: convert raw data to voltage. Changes in patch v1: 1)fix typo covert to convert in patch 2/2 description. Hui Liu (2): iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case iio: mtk-auxadc: update case IIO_CHAN_INFO_PROCESSED drivers/iio/adc/mt6577_auxadc.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) -- 2.18.0 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case 2021-08-12 5:48 [PATCH v1 0/2] AUXADC: Mediatek auxadc driver Hui Liu @ 2021-08-12 5:48 ` Hui Liu 2021-08-12 18:07 ` Jonathan Cameron 2021-08-12 5:48 ` [PATCH v1 2/2] iio: mtk-auxadc: update case IIO_CHAN_INFO_PROCESSED Hui Liu 1 sibling, 1 reply; 14+ messages in thread From: Hui Liu @ 2021-08-12 5:48 UTC (permalink / raw) To: robh+dt, jic23, lars, pmeerw Cc: srv_heupstream, hui.liu, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek Add support IIO_CHAN_INFO_RAW case. Signed-off-by: Hui Liu <hui.liu@mediatek.com> --- drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c index 79c1dd68b909..e995d43287b2 100644 --- a/drivers/iio/adc/mt6577_auxadc.c +++ b/drivers/iio/adc/mt6577_auxadc.c @@ -60,7 +60,8 @@ static const struct mtk_auxadc_compatible mt6765_compat = { .type = IIO_VOLTAGE, \ .indexed = 1, \ .channel = (idx), \ - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), \ + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ + BIT(IIO_CHAN_INFO_PROCESSED), \ } static const struct iio_chan_spec mt6577_auxadc_iio_channels[] = { @@ -181,6 +182,19 @@ static int mt6577_auxadc_read_raw(struct iio_dev *indio_dev, struct mt6577_auxadc_device *adc_dev = iio_priv(indio_dev); switch (info) { + case IIO_CHAN_INFO_RAW: + *val = mt6577_auxadc_read(indio_dev, chan); + if (*val < 0) { + dev_notice(indio_dev->dev.parent, + "failed to sample data on channel[%d]\n", + chan->channel); + return *val; + } + if (adc_dev->dev_comp->sample_data_cali) + *val = mt_auxadc_get_cali_data(*val, true); + + return IIO_VAL_INT; + case IIO_CHAN_INFO_PROCESSED: *val = mt6577_auxadc_read(indio_dev, chan); if (*val < 0) { -- 2.18.0 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case 2021-08-12 5:48 ` [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case Hui Liu 2021-08-12 18:07 ` Jonathan Cameron @ 2021-08-12 18:07 ` Jonathan Cameron 0 siblings, 0 replies; 14+ messages in thread From: Jonathan Cameron @ 2021-08-12 18:07 UTC (permalink / raw) To: Hui Liu Cc: robh+dt, jic23, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek On Thu, 12 Aug 2021 13:48:43 +0800 Hui Liu <hui.liu@mediatek.com> wrote: > Add support IIO_CHAN_INFO_RAW case. Why? We almost never support both RAW and PROCESSED as userspace should be fine to use either. There are a few reasons we've let drivers do this but I would like know why it matters to you and it definitely needs to be in the patch description. > > Signed-off-by: Hui Liu <hui.liu@mediatek.com> > --- > drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c > index 79c1dd68b909..e995d43287b2 100644 > --- a/drivers/iio/adc/mt6577_auxadc.c > +++ b/drivers/iio/adc/mt6577_auxadc.c > @@ -60,7 +60,8 @@ static const struct mtk_auxadc_compatible mt6765_compat = { > .type = IIO_VOLTAGE, \ > .indexed = 1, \ > .channel = (idx), \ > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), \ > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ > + BIT(IIO_CHAN_INFO_PROCESSED), \ > } > > static const struct iio_chan_spec mt6577_auxadc_iio_channels[] = { > @@ -181,6 +182,19 @@ static int mt6577_auxadc_read_raw(struct iio_dev *indio_dev, > struct mt6577_auxadc_device *adc_dev = iio_priv(indio_dev); > > switch (info) { > + case IIO_CHAN_INFO_RAW: > + *val = mt6577_auxadc_read(indio_dev, chan); > + if (*val < 0) { > + dev_notice(indio_dev->dev.parent, > + "failed to sample data on channel[%d]\n", > + chan->channel); > + return *val; > + } > + if (adc_dev->dev_comp->sample_data_cali) > + *val = mt_auxadc_get_cali_data(*val, true); > + > + return IIO_VAL_INT; > + > case IIO_CHAN_INFO_PROCESSED: > *val = mt6577_auxadc_read(indio_dev, chan); > if (*val < 0) { ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case @ 2021-08-12 18:07 ` Jonathan Cameron 0 siblings, 0 replies; 14+ messages in thread From: Jonathan Cameron @ 2021-08-12 18:07 UTC (permalink / raw) To: Hui Liu Cc: robh+dt, jic23, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek On Thu, 12 Aug 2021 13:48:43 +0800 Hui Liu <hui.liu@mediatek.com> wrote: > Add support IIO_CHAN_INFO_RAW case. Why? We almost never support both RAW and PROCESSED as userspace should be fine to use either. There are a few reasons we've let drivers do this but I would like know why it matters to you and it definitely needs to be in the patch description. > > Signed-off-by: Hui Liu <hui.liu@mediatek.com> > --- > drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c > index 79c1dd68b909..e995d43287b2 100644 > --- a/drivers/iio/adc/mt6577_auxadc.c > +++ b/drivers/iio/adc/mt6577_auxadc.c > @@ -60,7 +60,8 @@ static const struct mtk_auxadc_compatible mt6765_compat = { > .type = IIO_VOLTAGE, \ > .indexed = 1, \ > .channel = (idx), \ > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), \ > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ > + BIT(IIO_CHAN_INFO_PROCESSED), \ > } > > static const struct iio_chan_spec mt6577_auxadc_iio_channels[] = { > @@ -181,6 +182,19 @@ static int mt6577_auxadc_read_raw(struct iio_dev *indio_dev, > struct mt6577_auxadc_device *adc_dev = iio_priv(indio_dev); > > switch (info) { > + case IIO_CHAN_INFO_RAW: > + *val = mt6577_auxadc_read(indio_dev, chan); > + if (*val < 0) { > + dev_notice(indio_dev->dev.parent, > + "failed to sample data on channel[%d]\n", > + chan->channel); > + return *val; > + } > + if (adc_dev->dev_comp->sample_data_cali) > + *val = mt_auxadc_get_cali_data(*val, true); > + > + return IIO_VAL_INT; > + > case IIO_CHAN_INFO_PROCESSED: > *val = mt6577_auxadc_read(indio_dev, chan); > if (*val < 0) { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case @ 2021-08-12 18:07 ` Jonathan Cameron 0 siblings, 0 replies; 14+ messages in thread From: Jonathan Cameron @ 2021-08-12 18:07 UTC (permalink / raw) To: Hui Liu Cc: robh+dt, jic23, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek On Thu, 12 Aug 2021 13:48:43 +0800 Hui Liu <hui.liu@mediatek.com> wrote: > Add support IIO_CHAN_INFO_RAW case. Why? We almost never support both RAW and PROCESSED as userspace should be fine to use either. There are a few reasons we've let drivers do this but I would like know why it matters to you and it definitely needs to be in the patch description. > > Signed-off-by: Hui Liu <hui.liu@mediatek.com> > --- > drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c > index 79c1dd68b909..e995d43287b2 100644 > --- a/drivers/iio/adc/mt6577_auxadc.c > +++ b/drivers/iio/adc/mt6577_auxadc.c > @@ -60,7 +60,8 @@ static const struct mtk_auxadc_compatible mt6765_compat = { > .type = IIO_VOLTAGE, \ > .indexed = 1, \ > .channel = (idx), \ > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), \ > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ > + BIT(IIO_CHAN_INFO_PROCESSED), \ > } > > static const struct iio_chan_spec mt6577_auxadc_iio_channels[] = { > @@ -181,6 +182,19 @@ static int mt6577_auxadc_read_raw(struct iio_dev *indio_dev, > struct mt6577_auxadc_device *adc_dev = iio_priv(indio_dev); > > switch (info) { > + case IIO_CHAN_INFO_RAW: > + *val = mt6577_auxadc_read(indio_dev, chan); > + if (*val < 0) { > + dev_notice(indio_dev->dev.parent, > + "failed to sample data on channel[%d]\n", > + chan->channel); > + return *val; > + } > + if (adc_dev->dev_comp->sample_data_cali) > + *val = mt_auxadc_get_cali_data(*val, true); > + > + return IIO_VAL_INT; > + > case IIO_CHAN_INFO_PROCESSED: > *val = mt6577_auxadc_read(indio_dev, chan); > if (*val < 0) { _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <042625639032bffe73b60a5c6274511e58e34ef4.camel@mediatek.com>]
* Re: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case [not found] ` <042625639032bffe73b60a5c6274511e58e34ef4.camel@mediatek.com> 2021-08-14 16:10 ` Jonathan Cameron @ 2021-08-14 16:10 ` Jonathan Cameron 0 siblings, 0 replies; 14+ messages in thread From: Jonathan Cameron @ 2021-08-14 16:10 UTC (permalink / raw) To: hui.liu Cc: Jonathan Cameron, robh+dt, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek On Fri, 13 Aug 2021 11:46:24 +0800 hui.liu <hui.liu@mediatek.com> wrote: > On Thu, 2021-08-12 at 19:07 +0100, Jonathan Cameron wrote: > > On Thu, 12 Aug 2021 13:48:43 +0800 > > Hui Liu <hui.liu@mediatek.com> wrote: > > > > > Add support IIO_CHAN_INFO_RAW case. > > > > Why? > > > > We almost never support both RAW and PROCESSED as userspace should be > > fine to use either. There are a few reasons we've let drivers do > > this but I would like know why it matters to you and it definitely > > needs to be in the patch description. > > > Hi Jonathan, > > 1. To support ADC consumers' different types of requirement: some > consumers want to call iio_read_channel_raw to get raw data, the others > use iio_read_channel_processed to get voltage. Give an example of the consumer using the raw channel readback (without acess to any scaling information?) > 2. In our origin driver, if consumer call iio_read_channel_processed, > read back value is raw data. > > Could we use SCALE instead of PROCESSED in patch for next version, or > what's your suggestion? That would unfortunately be a userspace ABI change. We can add interfaces but taking them away is normally a problem :( Your reasons here are fine, subject to information on what consumer cares about having _RAW, please resend the patch with this information added to the description. Thanks, Jonathan > > Thanks. > > > > > > > Signed-off-by: Hui Liu <hui.liu@mediatek.com> > > > --- > > > drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++- > > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/iio/adc/mt6577_auxadc.c > > > b/drivers/iio/adc/mt6577_auxadc.c > > > index 79c1dd68b909..e995d43287b2 100644 > > > --- a/drivers/iio/adc/mt6577_auxadc.c > > > +++ b/drivers/iio/adc/mt6577_auxadc.c > > > @@ -60,7 +60,8 @@ static const struct mtk_auxadc_compatible > > > mt6765_compat = { > > > .type = IIO_VOLTAGE, > > > \ > > > .indexed = 1, > > > \ > > > .channel = (idx), \ > > > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), \ > > > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > > > \ > > > + BIT(IIO_CHAN_INFO_PROCESSED), \ > > > } > > > > > > static const struct iio_chan_spec mt6577_auxadc_iio_channels[] = { > > > @@ -181,6 +182,19 @@ static int mt6577_auxadc_read_raw(struct > > > iio_dev *indio_dev, > > > struct mt6577_auxadc_device *adc_dev = iio_priv(indio_dev); > > > > > > switch (info) { > > > + case IIO_CHAN_INFO_RAW: > > > + *val = mt6577_auxadc_read(indio_dev, chan); > > > + if (*val < 0) { > > > + dev_notice(indio_dev->dev.parent, > > > + "failed to sample data on > > > channel[%d]\n", > > > + chan->channel); > > > + return *val; > > > + } > > > + if (adc_dev->dev_comp->sample_data_cali) > > > + *val = mt_auxadc_get_cali_data(*val, true); > > > + > > > + return IIO_VAL_INT; > > > + > > > case IIO_CHAN_INFO_PROCESSED: > > > *val = mt6577_auxadc_read(indio_dev, chan); > > > if (*val < 0) { > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case @ 2021-08-14 16:10 ` Jonathan Cameron 0 siblings, 0 replies; 14+ messages in thread From: Jonathan Cameron @ 2021-08-14 16:10 UTC (permalink / raw) To: hui.liu Cc: Jonathan Cameron, robh+dt, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek On Fri, 13 Aug 2021 11:46:24 +0800 hui.liu <hui.liu@mediatek.com> wrote: > On Thu, 2021-08-12 at 19:07 +0100, Jonathan Cameron wrote: > > On Thu, 12 Aug 2021 13:48:43 +0800 > > Hui Liu <hui.liu@mediatek.com> wrote: > > > > > Add support IIO_CHAN_INFO_RAW case. > > > > Why? > > > > We almost never support both RAW and PROCESSED as userspace should be > > fine to use either. There are a few reasons we've let drivers do > > this but I would like know why it matters to you and it definitely > > needs to be in the patch description. > > > Hi Jonathan, > > 1. To support ADC consumers' different types of requirement: some > consumers want to call iio_read_channel_raw to get raw data, the others > use iio_read_channel_processed to get voltage. Give an example of the consumer using the raw channel readback (without acess to any scaling information?) > 2. In our origin driver, if consumer call iio_read_channel_processed, > read back value is raw data. > > Could we use SCALE instead of PROCESSED in patch for next version, or > what's your suggestion? That would unfortunately be a userspace ABI change. We can add interfaces but taking them away is normally a problem :( Your reasons here are fine, subject to information on what consumer cares about having _RAW, please resend the patch with this information added to the description. Thanks, Jonathan > > Thanks. > > > > > > > Signed-off-by: Hui Liu <hui.liu@mediatek.com> > > > --- > > > drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++- > > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/iio/adc/mt6577_auxadc.c > > > b/drivers/iio/adc/mt6577_auxadc.c > > > index 79c1dd68b909..e995d43287b2 100644 > > > --- a/drivers/iio/adc/mt6577_auxadc.c > > > +++ b/drivers/iio/adc/mt6577_auxadc.c > > > @@ -60,7 +60,8 @@ static const struct mtk_auxadc_compatible > > > mt6765_compat = { > > > .type = IIO_VOLTAGE, > > > \ > > > .indexed = 1, > > > \ > > > .channel = (idx), \ > > > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), \ > > > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > > > \ > > > + BIT(IIO_CHAN_INFO_PROCESSED), \ > > > } > > > > > > static const struct iio_chan_spec mt6577_auxadc_iio_channels[] = { > > > @@ -181,6 +182,19 @@ static int mt6577_auxadc_read_raw(struct > > > iio_dev *indio_dev, > > > struct mt6577_auxadc_device *adc_dev = iio_priv(indio_dev); > > > > > > switch (info) { > > > + case IIO_CHAN_INFO_RAW: > > > + *val = mt6577_auxadc_read(indio_dev, chan); > > > + if (*val < 0) { > > > + dev_notice(indio_dev->dev.parent, > > > + "failed to sample data on > > > channel[%d]\n", > > > + chan->channel); > > > + return *val; > > > + } > > > + if (adc_dev->dev_comp->sample_data_cali) > > > + *val = mt_auxadc_get_cali_data(*val, true); > > > + > > > + return IIO_VAL_INT; > > > + > > > case IIO_CHAN_INFO_PROCESSED: > > > *val = mt6577_auxadc_read(indio_dev, chan); > > > if (*val < 0) { > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case @ 2021-08-14 16:10 ` Jonathan Cameron 0 siblings, 0 replies; 14+ messages in thread From: Jonathan Cameron @ 2021-08-14 16:10 UTC (permalink / raw) To: hui.liu Cc: Jonathan Cameron, robh+dt, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek On Fri, 13 Aug 2021 11:46:24 +0800 hui.liu <hui.liu@mediatek.com> wrote: > On Thu, 2021-08-12 at 19:07 +0100, Jonathan Cameron wrote: > > On Thu, 12 Aug 2021 13:48:43 +0800 > > Hui Liu <hui.liu@mediatek.com> wrote: > > > > > Add support IIO_CHAN_INFO_RAW case. > > > > Why? > > > > We almost never support both RAW and PROCESSED as userspace should be > > fine to use either. There are a few reasons we've let drivers do > > this but I would like know why it matters to you and it definitely > > needs to be in the patch description. > > > Hi Jonathan, > > 1. To support ADC consumers' different types of requirement: some > consumers want to call iio_read_channel_raw to get raw data, the others > use iio_read_channel_processed to get voltage. Give an example of the consumer using the raw channel readback (without acess to any scaling information?) > 2. In our origin driver, if consumer call iio_read_channel_processed, > read back value is raw data. > > Could we use SCALE instead of PROCESSED in patch for next version, or > what's your suggestion? That would unfortunately be a userspace ABI change. We can add interfaces but taking them away is normally a problem :( Your reasons here are fine, subject to information on what consumer cares about having _RAW, please resend the patch with this information added to the description. Thanks, Jonathan > > Thanks. > > > > > > > Signed-off-by: Hui Liu <hui.liu@mediatek.com> > > > --- > > > drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++- > > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/iio/adc/mt6577_auxadc.c > > > b/drivers/iio/adc/mt6577_auxadc.c > > > index 79c1dd68b909..e995d43287b2 100644 > > > --- a/drivers/iio/adc/mt6577_auxadc.c > > > +++ b/drivers/iio/adc/mt6577_auxadc.c > > > @@ -60,7 +60,8 @@ static const struct mtk_auxadc_compatible > > > mt6765_compat = { > > > .type = IIO_VOLTAGE, > > > \ > > > .indexed = 1, > > > \ > > > .channel = (idx), \ > > > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), \ > > > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > > > \ > > > + BIT(IIO_CHAN_INFO_PROCESSED), \ > > > } > > > > > > static const struct iio_chan_spec mt6577_auxadc_iio_channels[] = { > > > @@ -181,6 +182,19 @@ static int mt6577_auxadc_read_raw(struct > > > iio_dev *indio_dev, > > > struct mt6577_auxadc_device *adc_dev = iio_priv(indio_dev); > > > > > > switch (info) { > > > + case IIO_CHAN_INFO_RAW: > > > + *val = mt6577_auxadc_read(indio_dev, chan); > > > + if (*val < 0) { > > > + dev_notice(indio_dev->dev.parent, > > > + "failed to sample data on > > > channel[%d]\n", > > > + chan->channel); > > > + return *val; > > > + } > > > + if (adc_dev->dev_comp->sample_data_cali) > > > + *val = mt_auxadc_get_cali_data(*val, true); > > > + > > > + return IIO_VAL_INT; > > > + > > > case IIO_CHAN_INFO_PROCESSED: > > > *val = mt6577_auxadc_read(indio_dev, chan); > > > if (*val < 0) { > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <470d4a7fbbcbcaa35aa9dcbaab6a2b77f98dc528.camel@mediatek.com>]
* Re: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case [not found] ` <470d4a7fbbcbcaa35aa9dcbaab6a2b77f98dc528.camel@mediatek.com> 2021-08-17 15:54 ` Jonathan Cameron @ 2021-08-17 15:54 ` Jonathan Cameron 0 siblings, 0 replies; 14+ messages in thread From: Jonathan Cameron @ 2021-08-17 15:54 UTC (permalink / raw) To: hui.liu Cc: Jonathan Cameron, robh+dt, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek On Tue, 17 Aug 2021 16:37:52 +0800 hui.liu <hui.liu@mediatek.com> wrote: > On Sat, 2021-08-14 at 17:10 +0100, Jonathan Cameron wrote: > > On Fri, 13 Aug 2021 11:46:24 +0800 > > hui.liu <hui.liu@mediatek.com> wrote: > > > > > On Thu, 2021-08-12 at 19:07 +0100, Jonathan Cameron wrote: > > > > On Thu, 12 Aug 2021 13:48:43 +0800 > > > > Hui Liu <hui.liu@mediatek.com> wrote: > > > > > > > > > Add support IIO_CHAN_INFO_RAW case. > > > > > > > > Why? > > > > > > > > We almost never support both RAW and PROCESSED as userspace > > > > should be > > > > fine to use either. There are a few reasons we've let drivers do > > > > this but I would like know why it matters to you and it > > > > definitely > > > > needs to be in the patch description. > > > > > > > > > > Hi Jonathan, > > > > > > 1. To support ADC consumers' different types of requirement: some > > > consumers want to call iio_read_channel_raw to get raw data, the > > > others > > > use iio_read_channel_processed to get voltage. > > > > Give an example of the consumer using the raw channel readback > > (without > > acess to any scaling information?) > > > > > > 2. In our origin driver, if consumer call > > > iio_read_channel_processed, > > > read back value is raw data. > > > > > > Could we use SCALE instead of PROCESSED in patch for next version, > > > or > > > what's your suggestion? > > > > That would unfortunately be a userspace ABI change. We can add > > interfaces > > but taking them away is normally a problem :( > > > > Your reasons here are fine, subject to information on what consumer > > cares > > about having _RAW, please resend the patch with this information > > added > > to the description. > > > > Thanks, > > > > Jonathan > > 1. We found afe/iio-rescale.c, dac/dpot-dac.c and multiplexer/iio-mux.c > call iio_read_channel_raw to get raw data. If they use our ADC driver, > I think we should support _RAW case. > If we support _RAW case, we will add more information in v2 > description. iio-rescale has recently gained support for processed. https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/drivers/iio/afe/iio-rescale.c?h=testing&id=53ebee9499805add3eef630d998c40812e6a1c39 dpot-dac is a rather obscure special case, so I doubt you actually have one of those. If iio-mux is relevant then we should add processed support to that driver as well. I would rather see those users of the interface fixed than us having to tweak lots of drivers to provide _raw when it isn't appropriate for that piece of hardware. Jonathan > > 2. Since we change _PROCESSED readback value from raw data to voltage, > our consumer will make the changes synchronously. > > > > > > > Thanks. > > > > > > > > > > > > > Signed-off-by: Hui Liu <hui.liu@mediatek.com> > > > > > --- > > > > > drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++- > > > > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/iio/adc/mt6577_auxadc.c > > > > > b/drivers/iio/adc/mt6577_auxadc.c > > > > > index 79c1dd68b909..e995d43287b2 100644 > > > > > --- a/drivers/iio/adc/mt6577_auxadc.c > > > > > +++ b/drivers/iio/adc/mt6577_auxadc.c > > > > > @@ -60,7 +60,8 @@ static const struct mtk_auxadc_compatible > > > > > mt6765_compat = { > > > > > .type = IIO_VOLTAGE, > > > > > > > > > > \ > > > > > .indexed = 1, > > > > > > > > > > \ > > > > > .channel = (idx), > > > > > \ > > > > > - .info_mask_separate = > > > > > BIT(IIO_CHAN_INFO_PROCESSED), \ > > > > > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > > > > > > > > > > \ > > > > > + BIT(IIO_CHAN_INFO_PROCESS > > > > > ED), \ > > > > > } > > > > > > > > > > static const struct iio_chan_spec mt6577_auxadc_iio_channels[] > > > > > = { > > > > > @@ -181,6 +182,19 @@ static int mt6577_auxadc_read_raw(struct > > > > > iio_dev *indio_dev, > > > > > struct mt6577_auxadc_device *adc_dev = > > > > > iio_priv(indio_dev); > > > > > > > > > > switch (info) { > > > > > + case IIO_CHAN_INFO_RAW: > > > > > + *val = mt6577_auxadc_read(indio_dev, chan); > > > > > + if (*val < 0) { > > > > > + dev_notice(indio_dev->dev.parent, > > > > > + "failed to sample data on > > > > > channel[%d]\n", > > > > > + chan->channel); > > > > > + return *val; > > > > > + } > > > > > + if (adc_dev->dev_comp->sample_data_cali) > > > > > + *val = mt_auxadc_get_cali_data(*val, > > > > > true); > > > > > + > > > > > + return IIO_VAL_INT; > > > > > + > > > > > case IIO_CHAN_INFO_PROCESSED: > > > > > *val = mt6577_auxadc_read(indio_dev, chan); > > > > > if (*val < 0) { > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case @ 2021-08-17 15:54 ` Jonathan Cameron 0 siblings, 0 replies; 14+ messages in thread From: Jonathan Cameron @ 2021-08-17 15:54 UTC (permalink / raw) To: hui.liu Cc: Jonathan Cameron, robh+dt, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek On Tue, 17 Aug 2021 16:37:52 +0800 hui.liu <hui.liu@mediatek.com> wrote: > On Sat, 2021-08-14 at 17:10 +0100, Jonathan Cameron wrote: > > On Fri, 13 Aug 2021 11:46:24 +0800 > > hui.liu <hui.liu@mediatek.com> wrote: > > > > > On Thu, 2021-08-12 at 19:07 +0100, Jonathan Cameron wrote: > > > > On Thu, 12 Aug 2021 13:48:43 +0800 > > > > Hui Liu <hui.liu@mediatek.com> wrote: > > > > > > > > > Add support IIO_CHAN_INFO_RAW case. > > > > > > > > Why? > > > > > > > > We almost never support both RAW and PROCESSED as userspace > > > > should be > > > > fine to use either. There are a few reasons we've let drivers do > > > > this but I would like know why it matters to you and it > > > > definitely > > > > needs to be in the patch description. > > > > > > > > > > Hi Jonathan, > > > > > > 1. To support ADC consumers' different types of requirement: some > > > consumers want to call iio_read_channel_raw to get raw data, the > > > others > > > use iio_read_channel_processed to get voltage. > > > > Give an example of the consumer using the raw channel readback > > (without > > acess to any scaling information?) > > > > > > 2. In our origin driver, if consumer call > > > iio_read_channel_processed, > > > read back value is raw data. > > > > > > Could we use SCALE instead of PROCESSED in patch for next version, > > > or > > > what's your suggestion? > > > > That would unfortunately be a userspace ABI change. We can add > > interfaces > > but taking them away is normally a problem :( > > > > Your reasons here are fine, subject to information on what consumer > > cares > > about having _RAW, please resend the patch with this information > > added > > to the description. > > > > Thanks, > > > > Jonathan > > 1. We found afe/iio-rescale.c, dac/dpot-dac.c and multiplexer/iio-mux.c > call iio_read_channel_raw to get raw data. If they use our ADC driver, > I think we should support _RAW case. > If we support _RAW case, we will add more information in v2 > description. iio-rescale has recently gained support for processed. https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/drivers/iio/afe/iio-rescale.c?h=testing&id=53ebee9499805add3eef630d998c40812e6a1c39 dpot-dac is a rather obscure special case, so I doubt you actually have one of those. If iio-mux is relevant then we should add processed support to that driver as well. I would rather see those users of the interface fixed than us having to tweak lots of drivers to provide _raw when it isn't appropriate for that piece of hardware. Jonathan > > 2. Since we change _PROCESSED readback value from raw data to voltage, > our consumer will make the changes synchronously. > > > > > > > Thanks. > > > > > > > > > > > > > Signed-off-by: Hui Liu <hui.liu@mediatek.com> > > > > > --- > > > > > drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++- > > > > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/iio/adc/mt6577_auxadc.c > > > > > b/drivers/iio/adc/mt6577_auxadc.c > > > > > index 79c1dd68b909..e995d43287b2 100644 > > > > > --- a/drivers/iio/adc/mt6577_auxadc.c > > > > > +++ b/drivers/iio/adc/mt6577_auxadc.c > > > > > @@ -60,7 +60,8 @@ static const struct mtk_auxadc_compatible > > > > > mt6765_compat = { > > > > > .type = IIO_VOLTAGE, > > > > > > > > > > \ > > > > > .indexed = 1, > > > > > > > > > > \ > > > > > .channel = (idx), > > > > > \ > > > > > - .info_mask_separate = > > > > > BIT(IIO_CHAN_INFO_PROCESSED), \ > > > > > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > > > > > > > > > > \ > > > > > + BIT(IIO_CHAN_INFO_PROCESS > > > > > ED), \ > > > > > } > > > > > > > > > > static const struct iio_chan_spec mt6577_auxadc_iio_channels[] > > > > > = { > > > > > @@ -181,6 +182,19 @@ static int mt6577_auxadc_read_raw(struct > > > > > iio_dev *indio_dev, > > > > > struct mt6577_auxadc_device *adc_dev = > > > > > iio_priv(indio_dev); > > > > > > > > > > switch (info) { > > > > > + case IIO_CHAN_INFO_RAW: > > > > > + *val = mt6577_auxadc_read(indio_dev, chan); > > > > > + if (*val < 0) { > > > > > + dev_notice(indio_dev->dev.parent, > > > > > + "failed to sample data on > > > > > channel[%d]\n", > > > > > + chan->channel); > > > > > + return *val; > > > > > + } > > > > > + if (adc_dev->dev_comp->sample_data_cali) > > > > > + *val = mt_auxadc_get_cali_data(*val, > > > > > true); > > > > > + > > > > > + return IIO_VAL_INT; > > > > > + > > > > > case IIO_CHAN_INFO_PROCESSED: > > > > > *val = mt6577_auxadc_read(indio_dev, chan); > > > > > if (*val < 0) { > > > > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case @ 2021-08-17 15:54 ` Jonathan Cameron 0 siblings, 0 replies; 14+ messages in thread From: Jonathan Cameron @ 2021-08-17 15:54 UTC (permalink / raw) To: hui.liu Cc: Jonathan Cameron, robh+dt, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek On Tue, 17 Aug 2021 16:37:52 +0800 hui.liu <hui.liu@mediatek.com> wrote: > On Sat, 2021-08-14 at 17:10 +0100, Jonathan Cameron wrote: > > On Fri, 13 Aug 2021 11:46:24 +0800 > > hui.liu <hui.liu@mediatek.com> wrote: > > > > > On Thu, 2021-08-12 at 19:07 +0100, Jonathan Cameron wrote: > > > > On Thu, 12 Aug 2021 13:48:43 +0800 > > > > Hui Liu <hui.liu@mediatek.com> wrote: > > > > > > > > > Add support IIO_CHAN_INFO_RAW case. > > > > > > > > Why? > > > > > > > > We almost never support both RAW and PROCESSED as userspace > > > > should be > > > > fine to use either. There are a few reasons we've let drivers do > > > > this but I would like know why it matters to you and it > > > > definitely > > > > needs to be in the patch description. > > > > > > > > > > Hi Jonathan, > > > > > > 1. To support ADC consumers' different types of requirement: some > > > consumers want to call iio_read_channel_raw to get raw data, the > > > others > > > use iio_read_channel_processed to get voltage. > > > > Give an example of the consumer using the raw channel readback > > (without > > acess to any scaling information?) > > > > > > 2. In our origin driver, if consumer call > > > iio_read_channel_processed, > > > read back value is raw data. > > > > > > Could we use SCALE instead of PROCESSED in patch for next version, > > > or > > > what's your suggestion? > > > > That would unfortunately be a userspace ABI change. We can add > > interfaces > > but taking them away is normally a problem :( > > > > Your reasons here are fine, subject to information on what consumer > > cares > > about having _RAW, please resend the patch with this information > > added > > to the description. > > > > Thanks, > > > > Jonathan > > 1. We found afe/iio-rescale.c, dac/dpot-dac.c and multiplexer/iio-mux.c > call iio_read_channel_raw to get raw data. If they use our ADC driver, > I think we should support _RAW case. > If we support _RAW case, we will add more information in v2 > description. iio-rescale has recently gained support for processed. https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/drivers/iio/afe/iio-rescale.c?h=testing&id=53ebee9499805add3eef630d998c40812e6a1c39 dpot-dac is a rather obscure special case, so I doubt you actually have one of those. If iio-mux is relevant then we should add processed support to that driver as well. I would rather see those users of the interface fixed than us having to tweak lots of drivers to provide _raw when it isn't appropriate for that piece of hardware. Jonathan > > 2. Since we change _PROCESSED readback value from raw data to voltage, > our consumer will make the changes synchronously. > > > > > > > Thanks. > > > > > > > > > > > > > Signed-off-by: Hui Liu <hui.liu@mediatek.com> > > > > > --- > > > > > drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++- > > > > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/iio/adc/mt6577_auxadc.c > > > > > b/drivers/iio/adc/mt6577_auxadc.c > > > > > index 79c1dd68b909..e995d43287b2 100644 > > > > > --- a/drivers/iio/adc/mt6577_auxadc.c > > > > > +++ b/drivers/iio/adc/mt6577_auxadc.c > > > > > @@ -60,7 +60,8 @@ static const struct mtk_auxadc_compatible > > > > > mt6765_compat = { > > > > > .type = IIO_VOLTAGE, > > > > > > > > > > \ > > > > > .indexed = 1, > > > > > > > > > > \ > > > > > .channel = (idx), > > > > > \ > > > > > - .info_mask_separate = > > > > > BIT(IIO_CHAN_INFO_PROCESSED), \ > > > > > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > > > > > > > > > > \ > > > > > + BIT(IIO_CHAN_INFO_PROCESS > > > > > ED), \ > > > > > } > > > > > > > > > > static const struct iio_chan_spec mt6577_auxadc_iio_channels[] > > > > > = { > > > > > @@ -181,6 +182,19 @@ static int mt6577_auxadc_read_raw(struct > > > > > iio_dev *indio_dev, > > > > > struct mt6577_auxadc_device *adc_dev = > > > > > iio_priv(indio_dev); > > > > > > > > > > switch (info) { > > > > > + case IIO_CHAN_INFO_RAW: > > > > > + *val = mt6577_auxadc_read(indio_dev, chan); > > > > > + if (*val < 0) { > > > > > + dev_notice(indio_dev->dev.parent, > > > > > + "failed to sample data on > > > > > channel[%d]\n", > > > > > + chan->channel); > > > > > + return *val; > > > > > + } > > > > > + if (adc_dev->dev_comp->sample_data_cali) > > > > > + *val = mt_auxadc_get_cali_data(*val, > > > > > true); > > > > > + > > > > > + return IIO_VAL_INT; > > > > > + > > > > > case IIO_CHAN_INFO_PROCESSED: > > > > > *val = mt6577_auxadc_read(indio_dev, chan); > > > > > if (*val < 0) { > > > > > > > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <a6211ac1b3ab14931499744023ee60c1e82424a8.camel@mediatek.com>]
[parent not found: <SI2PR03MB56901E5D00D47948BE0E9F989BC69@SI2PR03MB5690.apcprd03.prod.outlook.com>]
[parent not found: <9fa19fb18910a593d25fb894237b3c59764db53e.camel@mediatek.com>]
* Re: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case [not found] ` <9fa19fb18910a593d25fb894237b3c59764db53e.camel@mediatek.com> @ 2021-08-29 14:15 ` Jonathan Cameron 0 siblings, 0 replies; 14+ messages in thread From: Jonathan Cameron @ 2021-08-29 14:15 UTC (permalink / raw) To: hui.liu Cc: Jonathan Cameron, robh+dt, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek On Thu, 26 Aug 2021 10:27:34 +0800 hui.liu <hui.liu@mediatek.com> wrote: > Hi Jonathan, > > Our internal Kernel module CCCI use _RAW case, we described in the > previous mail. Could you give your suggestion? Fix your internal module? I would have assumed it would want calibrated values if available, so it seems a little odd to use _RAW. If there is a good reason for it doing so that you can talk about here then perhaps we can consider it. As a general rule we don't put any significant effort into supporting out of tree drivers so I'm not very keen on adding _RAW on the basis one uses it. Jonathan > > Thanks. > Hui > > > > > On Tue, 2021-08-17 at 16:54 +0100, Jonathan Cameron wrote: > > > On Tue, 17 Aug 2021 16:37:52 +0800 > > > hui.liu <hui.liu@mediatek.com> wrote: > > > > > > > On Sat, 2021-08-14 at 17:10 +0100, Jonathan Cameron wrote: > > > > > On Fri, 13 Aug 2021 11:46:24 +0800 hui.liu < > > > > > hui.liu@mediatek.com> > > > > > wrote: > > > > > > > > > > > On Thu, 2021-08-12 at 19:07 +0100, Jonathan Cameron wrote: > > > > > > > On Thu, 12 Aug 2021 13:48:43 +0800 Hui Liu > > > > > > > <hui.liu@mediatek.com> wrote: > > > > > > > > > > > > > > > Add support IIO_CHAN_INFO_RAW case. > > > > > > > > > > > > > > Why? > > > > > > > > > > > > > > We almost never support both RAW and PROCESSED as > > > > > > > userspace > > > > > > > should be fine to use either. There are a few reasons > > > > > > > we've > > > > > > > let drivers do this but I would like know why it matters > > > > > > > to > > > > > > > you and it definitely needs to be in the patch description. > > > > > > > > > > > > > > > > > > > Hi Jonathan, > > > > > > > > > > > > 1. To support ADC consumers' different types of requirement: > > > > > > some > > > > > > consumers want to call iio_read_channel_raw to get raw data, > > > > > > the > > > > > > others use iio_read_channel_processed to get voltage. > > > > > > > > > > Give an example of the consumer using the raw channel readback > > > > > (without acess to any scaling information?) > > > > > > > > > > > 2. In our origin driver, if consumer call > > > > > > iio_read_channel_processed, read back value is raw data. > > > > > > > > > > > > Could we use SCALE instead of PROCESSED in patch for next > > > > > > version, or what's your suggestion? > > > > > > > > > > That would unfortunately be a userspace ABI change. We can > > > > > add > > > > > interfaces but taking them away is normally a problem :( > > > > > > > > > > Your reasons here are fine, subject to information on what > > > > > consumer cares about having _RAW, please resend the patch with > > > > > this information added to the description. > > > > > > > > > > Thanks, > > > > > > > > > > Jonathan > > > > > > > > 1. We found afe/iio-rescale.c, dac/dpot-dac.c and > > > > multiplexer/iio- > > > > mux.c call iio_read_channel_raw to get raw data. If they use our > > > > ADC > > > > driver, I think we should support _RAW case. > > > > If we support _RAW case, we will add more information in v2 > > > > description. > > > > > > iio-rescale has recently gained support for processed. > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/drivers/iio/afe/iio-rescale.c?h=testing&id=53ebee9499805add3eef630d998c40812e6a1c39 > > > dpot-dac is a rather obscure special case, so I doubt you actually > > > have one of those. > > > If iio-mux is relevant then we should add processed support to > > > that > > > driver as well. > > > > > > I would rather see those users of the interface fixed than us > > > having > > > to tweak lots of drivers to provide _raw when it isn't appropriate > > > for > > > that piece of hardware. > > > > > > Jonathan > > > > > > > Hi Jonathan, > > > > For we have an internal use scenario: > > Our internal Kernel module CCCI(Communication interface between AP > > Core and Modem) would like get raw data from ADC, but CCCI driver > > have not do upstream now. > > > > If we no need add _RAW, we will only change _PROCESSED readback value > > in the next version of patch. > > > > > > > > > > 2. Since we change _PROCESSED readback value from raw data to > > > > voltage, our consumer will make the changes synchronously. > > > > > > > > > > > > > > > > Thanks. > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Hui Liu <hui.liu@mediatek.com> > > > > > > > > --- > > > > > > > > drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++- > > > > > > > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > > > diff --git a/drivers/iio/adc/mt6577_auxadc.c > > > > > > > > b/drivers/iio/adc/mt6577_auxadc.c index > > > > > > > > 79c1dd68b909..e995d43287b2 100644 > > > > > > > > --- a/drivers/iio/adc/mt6577_auxadc.c > > > > > > > > +++ b/drivers/iio/adc/mt6577_auxadc.c > > > > > > > > @@ -60,7 +60,8 @@ static const struct > > > > > > > > mtk_auxadc_compatible > > > > > > > > mt6765_compat = { > > > > > > > > .type = IIO_VOLTAGE, > > > > > > > > > > > > > > > > \ > > > > > > > > .indexed = 1, > > > > > > > > > > > > > > > > \ > > > > > > > > .channel = (idx), > > > > > > > > \ > > > > > > > > - .info_mask_separate = > > > > > > > > BIT(IIO_CHAN_INFO_PROCESSED), \ > > > > > > > > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > > > > > > > > > > > > > > > > \ > > > > > > > > + BIT(IIO_CHAN_INFO_PROCESS > > > > > > > > ED), \ > > > > > > > > } > > > > > > > > > > > > > > > > static const struct iio_chan_spec > > > > > > > > mt6577_auxadc_iio_channels[] = { @@ -181,6 +182,19 @@ > > > > > > > > static > > > > > > > > int mt6577_auxadc_read_raw(struct iio_dev *indio_dev, > > > > > > > > struct mt6577_auxadc_device *adc_dev = > > > > > > > > iio_priv(indio_dev); > > > > > > > > > > > > > > > > switch (info) { > > > > > > > > + case IIO_CHAN_INFO_RAW: > > > > > > > > + *val = mt6577_auxadc_read(indio_dev, chan); > > > > > > > > + if (*val < 0) { > > > > > > > > + dev_notice(indio_dev->dev.parent, > > > > > > > > + "failed to sample data on > > > > > > > > channel[%d]\n", > > > > > > > > + chan->channel); > > > > > > > > + return *val; > > > > > > > > + } > > > > > > > > + if (adc_dev->dev_comp->sample_data_cali) > > > > > > > > + *val = mt_auxadc_get_cali_data(*val, > > > > > > > > true); > > > > > > > > + > > > > > > > > + return IIO_VAL_INT; > > > > > > > > + > > > > > > > > case IIO_CHAN_INFO_PROCESSED: > > > > > > > > *val = mt6577_auxadc_read(indio_dev, chan); > > > > > > > > if (*val < 0) { > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case @ 2021-08-29 14:15 ` Jonathan Cameron 0 siblings, 0 replies; 14+ messages in thread From: Jonathan Cameron @ 2021-08-29 14:15 UTC (permalink / raw) To: hui.liu Cc: Jonathan Cameron, robh+dt, lars, pmeerw, srv_heupstream, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek On Thu, 26 Aug 2021 10:27:34 +0800 hui.liu <hui.liu@mediatek.com> wrote: > Hi Jonathan, > > Our internal Kernel module CCCI use _RAW case, we described in the > previous mail. Could you give your suggestion? Fix your internal module? I would have assumed it would want calibrated values if available, so it seems a little odd to use _RAW. If there is a good reason for it doing so that you can talk about here then perhaps we can consider it. As a general rule we don't put any significant effort into supporting out of tree drivers so I'm not very keen on adding _RAW on the basis one uses it. Jonathan > > Thanks. > Hui > > > > > On Tue, 2021-08-17 at 16:54 +0100, Jonathan Cameron wrote: > > > On Tue, 17 Aug 2021 16:37:52 +0800 > > > hui.liu <hui.liu@mediatek.com> wrote: > > > > > > > On Sat, 2021-08-14 at 17:10 +0100, Jonathan Cameron wrote: > > > > > On Fri, 13 Aug 2021 11:46:24 +0800 hui.liu < > > > > > hui.liu@mediatek.com> > > > > > wrote: > > > > > > > > > > > On Thu, 2021-08-12 at 19:07 +0100, Jonathan Cameron wrote: > > > > > > > On Thu, 12 Aug 2021 13:48:43 +0800 Hui Liu > > > > > > > <hui.liu@mediatek.com> wrote: > > > > > > > > > > > > > > > Add support IIO_CHAN_INFO_RAW case. > > > > > > > > > > > > > > Why? > > > > > > > > > > > > > > We almost never support both RAW and PROCESSED as > > > > > > > userspace > > > > > > > should be fine to use either. There are a few reasons > > > > > > > we've > > > > > > > let drivers do this but I would like know why it matters > > > > > > > to > > > > > > > you and it definitely needs to be in the patch description. > > > > > > > > > > > > > > > > > > > Hi Jonathan, > > > > > > > > > > > > 1. To support ADC consumers' different types of requirement: > > > > > > some > > > > > > consumers want to call iio_read_channel_raw to get raw data, > > > > > > the > > > > > > others use iio_read_channel_processed to get voltage. > > > > > > > > > > Give an example of the consumer using the raw channel readback > > > > > (without acess to any scaling information?) > > > > > > > > > > > 2. In our origin driver, if consumer call > > > > > > iio_read_channel_processed, read back value is raw data. > > > > > > > > > > > > Could we use SCALE instead of PROCESSED in patch for next > > > > > > version, or what's your suggestion? > > > > > > > > > > That would unfortunately be a userspace ABI change. We can > > > > > add > > > > > interfaces but taking them away is normally a problem :( > > > > > > > > > > Your reasons here are fine, subject to information on what > > > > > consumer cares about having _RAW, please resend the patch with > > > > > this information added to the description. > > > > > > > > > > Thanks, > > > > > > > > > > Jonathan > > > > > > > > 1. We found afe/iio-rescale.c, dac/dpot-dac.c and > > > > multiplexer/iio- > > > > mux.c call iio_read_channel_raw to get raw data. If they use our > > > > ADC > > > > driver, I think we should support _RAW case. > > > > If we support _RAW case, we will add more information in v2 > > > > description. > > > > > > iio-rescale has recently gained support for processed. > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/drivers/iio/afe/iio-rescale.c?h=testing&id=53ebee9499805add3eef630d998c40812e6a1c39 > > > dpot-dac is a rather obscure special case, so I doubt you actually > > > have one of those. > > > If iio-mux is relevant then we should add processed support to > > > that > > > driver as well. > > > > > > I would rather see those users of the interface fixed than us > > > having > > > to tweak lots of drivers to provide _raw when it isn't appropriate > > > for > > > that piece of hardware. > > > > > > Jonathan > > > > > > > Hi Jonathan, > > > > For we have an internal use scenario: > > Our internal Kernel module CCCI(Communication interface between AP > > Core and Modem) would like get raw data from ADC, but CCCI driver > > have not do upstream now. > > > > If we no need add _RAW, we will only change _PROCESSED readback value > > in the next version of patch. > > > > > > > > > > 2. Since we change _PROCESSED readback value from raw data to > > > > voltage, our consumer will make the changes synchronously. > > > > > > > > > > > > > > > > Thanks. > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Hui Liu <hui.liu@mediatek.com> > > > > > > > > --- > > > > > > > > drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++- > > > > > > > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > > > diff --git a/drivers/iio/adc/mt6577_auxadc.c > > > > > > > > b/drivers/iio/adc/mt6577_auxadc.c index > > > > > > > > 79c1dd68b909..e995d43287b2 100644 > > > > > > > > --- a/drivers/iio/adc/mt6577_auxadc.c > > > > > > > > +++ b/drivers/iio/adc/mt6577_auxadc.c > > > > > > > > @@ -60,7 +60,8 @@ static const struct > > > > > > > > mtk_auxadc_compatible > > > > > > > > mt6765_compat = { > > > > > > > > .type = IIO_VOLTAGE, > > > > > > > > > > > > > > > > \ > > > > > > > > .indexed = 1, > > > > > > > > > > > > > > > > \ > > > > > > > > .channel = (idx), > > > > > > > > \ > > > > > > > > - .info_mask_separate = > > > > > > > > BIT(IIO_CHAN_INFO_PROCESSED), \ > > > > > > > > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > > > > > > > > > > > > > > > > \ > > > > > > > > + BIT(IIO_CHAN_INFO_PROCESS > > > > > > > > ED), \ > > > > > > > > } > > > > > > > > > > > > > > > > static const struct iio_chan_spec > > > > > > > > mt6577_auxadc_iio_channels[] = { @@ -181,6 +182,19 @@ > > > > > > > > static > > > > > > > > int mt6577_auxadc_read_raw(struct iio_dev *indio_dev, > > > > > > > > struct mt6577_auxadc_device *adc_dev = > > > > > > > > iio_priv(indio_dev); > > > > > > > > > > > > > > > > switch (info) { > > > > > > > > + case IIO_CHAN_INFO_RAW: > > > > > > > > + *val = mt6577_auxadc_read(indio_dev, chan); > > > > > > > > + if (*val < 0) { > > > > > > > > + dev_notice(indio_dev->dev.parent, > > > > > > > > + "failed to sample data on > > > > > > > > channel[%d]\n", > > > > > > > > + chan->channel); > > > > > > > > + return *val; > > > > > > > > + } > > > > > > > > + if (adc_dev->dev_comp->sample_data_cali) > > > > > > > > + *val = mt_auxadc_get_cali_data(*val, > > > > > > > > true); > > > > > > > > + > > > > > > > > + return IIO_VAL_INT; > > > > > > > > + > > > > > > > > case IIO_CHAN_INFO_PROCESSED: > > > > > > > > *val = mt6577_auxadc_read(indio_dev, chan); > > > > > > > > if (*val < 0) { > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v1 2/2] iio: mtk-auxadc: update case IIO_CHAN_INFO_PROCESSED 2021-08-12 5:48 [PATCH v1 0/2] AUXADC: Mediatek auxadc driver Hui Liu 2021-08-12 5:48 ` [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case Hui Liu @ 2021-08-12 5:48 ` Hui Liu 1 sibling, 0 replies; 14+ messages in thread From: Hui Liu @ 2021-08-12 5:48 UTC (permalink / raw) To: robh+dt, jic23, lars, pmeerw Cc: srv_heupstream, hui.liu, zhiyong.tao, chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel, linux-arm-kernel, linux-iio, linux-mediatek Convert raw data to processed data. Signed-off-by: Hui Liu <hui.liu@mediatek.com> --- drivers/iio/adc/mt6577_auxadc.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c index e995d43287b2..cda03a653269 100644 --- a/drivers/iio/adc/mt6577_auxadc.c +++ b/drivers/iio/adc/mt6577_auxadc.c @@ -83,6 +83,10 @@ static const struct iio_chan_spec mt6577_auxadc_iio_channels[] = { MT6577_AUXADC_CHANNEL(15), }; +/* For Voltage calculation */ +#define VOLTAGE_FULL_RANGE 1500 /* VA voltage */ +#define AUXADC_PRECISE 4096 /* 12 bits */ + static int mt_auxadc_get_cali_data(int rawdata, bool enable_cali) { return rawdata; @@ -205,6 +209,10 @@ static int mt6577_auxadc_read_raw(struct iio_dev *indio_dev, } if (adc_dev->dev_comp->sample_data_cali) *val = mt_auxadc_get_cali_data(*val, true); + + /* Convert adc raw data to voltage: 0 - 1500 mV */ + *val = *val * VOLTAGE_FULL_RANGE / AUXADC_PRECISE; + return IIO_VAL_INT; default: -- 2.18.0 ^ permalink raw reply related [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-08-29 14:14 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-12 5:48 [PATCH v1 0/2] AUXADC: Mediatek auxadc driver Hui Liu
2021-08-12 5:48 ` [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case Hui Liu
2021-08-12 18:07 ` Jonathan Cameron
2021-08-12 18:07 ` Jonathan Cameron
2021-08-12 18:07 ` Jonathan Cameron
[not found] ` <042625639032bffe73b60a5c6274511e58e34ef4.camel@mediatek.com>
2021-08-14 16:10 ` Jonathan Cameron
2021-08-14 16:10 ` Jonathan Cameron
2021-08-14 16:10 ` Jonathan Cameron
[not found] ` <470d4a7fbbcbcaa35aa9dcbaab6a2b77f98dc528.camel@mediatek.com>
2021-08-17 15:54 ` Jonathan Cameron
2021-08-17 15:54 ` Jonathan Cameron
2021-08-17 15:54 ` Jonathan Cameron
[not found] ` <a6211ac1b3ab14931499744023ee60c1e82424a8.camel@mediatek.com>
[not found] ` <SI2PR03MB56901E5D00D47948BE0E9F989BC69@SI2PR03MB5690.apcprd03.prod.outlook.com>
[not found] ` <9fa19fb18910a593d25fb894237b3c59764db53e.camel@mediatek.com>
2021-08-29 14:15 ` Jonathan Cameron
2021-08-29 14:15 ` Jonathan Cameron
2021-08-12 5:48 ` [PATCH v1 2/2] iio: mtk-auxadc: update case IIO_CHAN_INFO_PROCESSED Hui Liu
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.