All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: David Stevens <stevensd@chromium.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
	linux-kernel@vger.kernel.org, Tom Murphy <murphyt7@tcd.ie>,
	iommu@lists.linux-foundation.org, Will Deacon <will@kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v4 2/6] dma-iommu: fix arch_sync_dma for map
Date: Fri, 13 Aug 2021 10:02:36 +0200	[thread overview]
Message-ID: <20210813080236.GB28020@lst.de> (raw)
In-Reply-To: <20210813073839.1562438-3-stevensd@google.com>

I have a really hard time reading following the patch.
Can you split folding__iommu_dma_map_swiotlb into iommu_dma_map_page
into a second cleanup patch?
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: David Stevens <stevensd@chromium.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
	Christoph Hellwig <hch@lst.de>, Joerg Roedel <joro@8bytes.org>,
	Will Deacon <will@kernel.org>,
	Lu Baolu <baolu.lu@linux.intel.com>, Tom Murphy <murphyt7@tcd.ie>,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/6] dma-iommu: fix arch_sync_dma for map
Date: Fri, 13 Aug 2021 10:02:36 +0200	[thread overview]
Message-ID: <20210813080236.GB28020@lst.de> (raw)
In-Reply-To: <20210813073839.1562438-3-stevensd@google.com>

I have a really hard time reading following the patch.
Can you split folding__iommu_dma_map_swiotlb into iommu_dma_map_page
into a second cleanup patch?

  reply	other threads:[~2021-08-13  8:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13  7:38 [PATCH v4 0/6] Fixes for dma-iommu swiotlb bounce buffers David Stevens
2021-08-13  7:38 ` David Stevens
2021-08-13  7:38 ` [PATCH v4 1/6] dma-iommu: fix sync_sg with swiotlb David Stevens
2021-08-13  7:38   ` David Stevens
2021-08-13  7:58   ` Christoph Hellwig
2021-08-13  7:58     ` Christoph Hellwig
2021-08-13  7:38 ` [PATCH v4 2/6] dma-iommu: fix arch_sync_dma for map David Stevens
2021-08-13  7:38   ` David Stevens
2021-08-13  8:02   ` Christoph Hellwig [this message]
2021-08-13  8:02     ` Christoph Hellwig
2021-08-13  7:38 ` [PATCH v4 3/6] dma-iommu: skip extra sync during unmap w/swiotlb David Stevens
2021-08-13  7:38   ` David Stevens
2021-08-13  8:03   ` Christoph Hellwig
2021-08-13  8:03     ` Christoph Hellwig
2021-08-13  7:38 ` [PATCH v4 4/6] dma-iommu: Check CONFIG_SWIOTLB more broadly David Stevens
2021-08-13  7:38   ` David Stevens
2021-08-13  8:03   ` Christoph Hellwig
2021-08-13  8:03     ` Christoph Hellwig
2021-08-13  7:38 ` [PATCH v4 5/6] swiotlb: support aligned swiotlb buffers David Stevens
2021-08-13  7:38   ` David Stevens
2021-08-13  8:04   ` Christoph Hellwig
2021-08-13  8:04     ` Christoph Hellwig
2021-08-14  8:39   ` kernel test robot
2021-08-14  8:39     ` kernel test robot
2021-08-14  8:39     ` kernel test robot
2021-08-13  7:38 ` [PATCH v4 6/6] dma-iommu: account for min_align_mask David Stevens
2021-08-13  7:38   ` David Stevens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210813080236.GB28020@lst.de \
    --to=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=murphyt7@tcd.ie \
    --cc=robin.murphy@arm.com \
    --cc=stevensd@chromium.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.